Quick Updates plugin [support]

[lat9]

Yep this is a mysqli thing, and I am not sure of the correct replacement for mysql_insert_id. You can try mysqli_insert_id and see if that works.. but I am not sure if an additional change is needed as well..

Or, to ensure future compatibility, you could use the $db->Insert_ID () function to retrieve that last inserted ID.

[DivaVocals]

Or, to ensure future compatibility, you could use the $db->Insert_ID () function to retrieve that last inserted ID.

So would the change from:

        $group_id = mysql_insert_id();

Look like this:

        $group_id = $db->Insert_ID();

[lat9]

Exactly! With the caveat that you'll need a

global $db;

statement if the processing occurs within a function.

[DivaVocals]

Exactly! With the caveat that you'll need a

global $db;

statement if the processing occurs within a function.

and THAT's where you lost me..

Drat!!! JUST when I thought I was getting it.. going back to the lab to see if I can figure out the answer on my own..

Edited to Add:

So altogether now..

function install_quick_updates() {
    global $db;
        $db->Execute("INSERT INTO ".TABLE_CONFIGURATION_GROUP." VALUES ('', 'Quick Updates', 'Quick Updates Configuration', '1', '1')");
        $group_id = $db->Insert_ID();

        $db->Execute("UPDATE ".TABLE_CONFIGURATION_GROUP." SET sort_order = ".$group_id." WHERE configuration_group_id = ".$group_id);
if (function_exists('zen_register_admin_page')) {
    if (!zen_page_key_exists('quick_updates_config')) {
            zen_register_admin_page('quick_updates_config', 'BOX_CATALOG_QUICK_UPDATES','FILENAME_CONFIGURATION', 'gID='.$group_id, 'configuration', 'Y', 103);
    }
}

[lat9]

Yes

[DivaVocals]

Yes

Well hotd@mn!

[chadderuski]

Hey Diva! You have a LAB?!?! LOL. I have a living room with too many computers! Got a letter from the electrical company telling me I use TWICE as much electricity as my neighbors. Go figure!

Anyway! I looked at your github updates...

Are you going to update the release for 1.5.3 here?
Will QuickUpdates still be backwards compatible?
Are you going to update the version number?

-chadd

[chadderuski]

Opps, my bad. I should have read back a few more pages. Confused myself ... my own experimental version of QuickUpdates is also v2.07!

Perhaps too late if you already submitted, but since you're dropping support for previous zencart version, mayhap a change to v3.0?

Just thinking out loud...

[DivaVocals]

Hey Diva! You have a LAB?!?! LOL. I have a living room with too many computers! Got a letter from the electrical company telling me I use TWICE as much electricity as my neighbors. Go figure!

Anyway! I looked at your github updates...

Are you going to update the release for 1.5.3 here?
Will QuickUpdates still be backwards compatible?
Are you going to update the version number?

-chadd

When I get some time in the next week I might update for 1.5.3.. If I do upgrade it, I have NO plans for backwards compatibility. It's JUST too much work and NOT worth my time/effort to maintain "parallell" versions of a module.. -- IMHO folks should simply UPGRADE and stop dinking around.. If they are STILL running <= v1.3.9 they REALLY need to upgrade and stop playing around..

I already updated the version number (v2.07)

That said I will only update my Github repo.. Not ready to submit it to the downloads section as there is still a MESS of crap in this module that needs to be cleaned up before it's ready to "release" IMHO (see below).. Some of these things I've already addressed in the Github repo (all that silly "popup" edit crap).. But this thing still doesn't properly work with the default editor, and the "Activate/Deactivate Commercial Margin" is not well well explained/documented.. Not sure if it works/doesn't work or WTF it's supposed to do..

Sources: http://www.zen-cart.com/showthread.p...54#post1228554

Will be submitting this tonight..

History:
~ Fixed the installer files and corrected the admin page registration code (there were some inconsistencies that I corrected).
~ Correct typos, inconsistent punctuation, inconsistent capitalization usage, and the use of some very awkward grammar in the admin config settings
~ Re-ordered some of the configuration items to a more logical order (for example: moved the popup description edit next to the description on/off setting)
~ Added better instructions in the configuration setting for the popup edit to WARN shopowners that you should not activate the popup edit without activating the description display. (activating one without the other shifts the column headings so they do not match the data column)
~ There is a missing heading column when the description is turned off. Fixed code so that the column headings correctly display when the description display setting is set to false (last column heading is missing)
~ Dropped ALL support for Zen Cart v1.3.x. If you are running versions of Zen Cart prior to v1.5.x, you should install v2.06a
~ LOTS of cleanup of the look of the layout as follows:
+ Fixed the product description layout so it STOPS pushing the entire layout off the screen (there is a no-wrap style in the stylesheet)
+ Removed hardcoded text alignment from EVERYWHERE (if needed text alignment/layout/styling should be done in the stylesheet)..
frankly all of that hardcoded text centering did not look good and made the overall layout look dated
+ Removed a LOT of odd settings from the stylesheet (right alignment of the product description input field for example WTH???)
+ Added IDs and classes to support some of the layout corrections I made

KNOWN BUGS I DISCOVERED:
(C Jones 11-29-2013) While making the v2.07 changes/updates, a few things that need addressing with this module were discovered. I can't address/fix these items (above my skill level to fix), but they are worth noting here.
1. The popup edit feature is nice, but possibly over engineered.. The display of the store side view product description is wholly unnecessary IMHO. a simply edit button to open the popup window is really all that's needed for this feature.. Even IF the store side view of the product description is a feature that most users desire, it should be an admin configurable item to turn on/off the product description display AND it needs work as it certainly doesn't work consistently in my testing.. MANY of my clients product descriptions when the popup edit feature is turned on either did not display at all or only partially displayed.. (for example the last line of the product description is the ONLY thing you see) I won't even begin to cover the CSS conflicts that occur because of classes and IDs from the product description sharing the same names as this mods classes and IDs..
2. The editor dropdown doesn't work.. In my testing, it defaults to CKEditor (my client's default editor), yet the editor doesn't render for the product description field (which is where I'd expect to see it). Tried forcing the editor change by changing to the text editor and then changing back to CK Editor.. still no dice..
3. The back button on the product preview page SHOULD return you back to the Quick Updates product list.. Instead you are returned to the catalog product list..
4. No support for products priced by attributes
5. No support for SBA (ANY version of SBA)

FEATURES THAT ARE NOT WELL DOCUMENTED:
I know that if I want to do a mass price increase that I have to activate the "Activate/Deactivate Commercial Margin". However this setting appears to do more, and it is not clear on what that is.. NO WHERE in the documentation is it clear what the "commercial margin" feature is or what it is supposed to "do". The help tip when I hover over the information icon in the UI shows this tip:
"Modify by commercial margin, if you check this box, your products will be stroked at the rates given. To stroke to 25%, means that the price is marked up of 33%"

The readme cryptically states:
"3) To make the products_purchase_price and margin feature work "products_purchase_price" (i.e. DECIMAL 15,4) and "products_margin" (i.e. DECIMAL 15,2) need to be added to your products tabel."

What EXACTLY does this all mean?? What is the purpose of this feature??

There is also code which appears to support wholesale pricing fields and NO WHERE in the readme is this functionality explained.

[chadderuski]

"Activate/Deactivate Commercial Margin" sounds like some long dead contribution... time for the weed whacker! I had a lot of that when I was cleaning up EasyPopulate ... what a tangled mess!