Page 76 of 76 FirstFirst ... 2666747576
Results 751 to 760 of 760
  1. #751
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    Quote Originally Posted by lat9 View Post
    Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

    Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.
    Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:
    Code:
    <?php
    if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
    ?>
    #spiffycalendar { left: 10px!important; }
    <?php
    }
    ?>

  2. #752
    Join Date
    Dec 2006
    Location
    Hudson Valley, New York USA
    Posts
    87
    Plugin Contributions
    0

    Default Re: Sales report 2.0

    Thanks for the fix carlwhat. I checked most of the places I could remember that use the SpiffyCal (Specials, SaleMaker, Featured Products) and your fix doesn't seem to adversely affect the ability to select a date, however on the Featured Products admin page it does push the calendar off the page to the right, but at least the browser can scroll over to select a date on that one.

    I will try lat9's fix instead.

  3. #753
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    1,401
    Plugin Contributions
    2

    Default Re: Sales report 2.0

    Quote Originally Posted by lat9 View Post
    Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:
    Code:
    <?php
    if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
    ?>
    #spiffycalendar { left: 10px!important; }
    <?php
    }
    ?>
    !important => i hate !important.... almost as much as i hate globals.... but a topic for another day.

    i'm going to investigate using datepicker. seems in use for collect info on the admin/product. and is part of the jquery ui library. might be a better solution and would make sense to be consistent through out.

    best.
    no good deed goes unpunished. help out with the green....

  4. #754
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    Quote Originally Posted by carlwhat View Post
    !important => i hate !important.... almost as much as i hate globals.... but a topic for another day.

    i'm going to investigate using datepicker. seems in use for collect info on the admin/product. and is part of the jquery ui library. might be a better solution and would make sense to be consistent through out.

    best.
    Yes, I try to avoid !important, but when it's the only option (other than carving up a core-file) ...

  5. #755
    Join Date
    May 2014
    Posts
    64
    Plugin Contributions
    0

    Default Re: Sales report 2.0

    Like carlwhat mentioned, I do think using the datepicker from jQuery UI would be better choice at this point.
    As this bug is NOT only in your plugin... it affected literary any plugins that use the SpiffyCal.
    Even the "E-Mail Archive Manager" face exact same bug problem!

    Therefore, it would be best if the Zen Cart's core file and/or the plugins migrated to jQuery's datepicker instead.
    (In fact, on my custom form used datepicker already... gotta test it out to see if I can substituted on SpiffyCal codes.)

  6. #756
    Join Date
    May 2014
    Posts
    64
    Plugin Contributions
    0

    Default Re: Sales report 2.0

    So many Zen Cart's admin pages are using SpiffyCalendar!
    https://i.imgur.com/Qq8TLqZ.png

    Sadly, that's not really good calendar to be use anymore.

    But, does not Zen Cart already implement Bootstrap?
    Then I suppose we can also use the Bootstrap's Datepicker!
    https://bootstrap-datepicker.readthedocs.io/en/latest
    https://buildmedia.readthedocs.org/m...datepicker.pdf

    ---

    However, it seems those two datepickers have to be in the "form."

    For example, in my custom "Rental Form," I have the following codes for the rental date ranges.
    https://i.imgur.com/gbVJvWj.png

    In this form, I set the end date based on starting date and starting date must be today or future's dates.
    Hence the reasons I have to have hidden fields to check on date values.

    HTML Code:
    <input type="hidden" id="rental_startdate_temp" value="<?php echo isset($_POST['rental_startdate']) ? $_POST['rental_startdate'] : ''; ?>" />
    <input type="hidden" id="rental_enddate_temp" value="<?php echo isset($_POST['rental_enddate']) ? $_POST['rental_enddate'] : ''; ?>" />
    
    <label class="inputLabel">Rental Dates:</label>
    
    <div id="two-column">
    <div id="left">
    <label class="inputLabelA" for="rental_startdate">Delivery</label>
    <input type="text" id="rental_startdate" name="rental_startdate" />
    </div>
    
    <div id="right">
    <label class="inputLabelB" for="rental_enddate">Return</label>
    <input type="text" id="rental_enddate" name="rental_enddate" />
    </div>
    </div>
    <br class="clearBoth" />
    In a separate JavaScript file...

    Code:
    $(function() {
    	
    	//Datepicker's on "Rental Starting Date" field.
        $( "#rental_startdate" ).datepicker({
    		minDate: 0,
    		changeMonth: true,
    		numberOfMonths: 3,
    		onSelect: function( selectedDate ) {
    			$( "#rental_enddate" ).datepicker( "option", "minDate", selectedDate );
    			$( "#rental_enddate_temp" ).val(selectedDate);
    		}
        });
    	
    	//Datepicker's on "Rental Ending Date" field.
        $( "#rental_enddate" ).datepicker({
    		minDate: 0,
    		changeMonth: true,
    		numberOfMonths: 3,
    		onSelect: function( selectedDate ) {
    			$( "#rental_startdate" ).datepicker( "option", "maxDate", selectedDate );
    			$( "#rental_startdate_temp" ).val(selectedDate);
    		}
    	});
    
    			// If user had put rental starting date, data will be retrieved from hidden field.
    			if ($("#rental_startdate_temp").val()!= '') {
    				var rentStartDateText = $("#rental_startdate_temp").val();
    				$("#rental_startdate").val(rentStartDateText);
    			}
    			
    			// If user had put rental ending date, data will be retrieved from hidden field.
    			if ($("#rental_enddate_temp").val()!= '') {
    				var rentEndtDateText = $("#rental_enddate_temp").val();
    				$("#rental_enddate").val(rentEndtDateText);
    			}
    });
    The "Keyword Capturing Dashboard" plugin is also using jQuery's datepicker.
    https://i.imgur.com/szb76jT.png

    So I am positive that datepicker can be completely replace the SpiffyCalendar.
    However, it seems that codes were optimized around it and hence it is not simply just replace SpiffyCalendar into the datepicker one... There has to be some dependencies that possibly have to ensure the replacement is properly done.

  7. #757
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    I've just submitted v3.3.0 of Sales Report to the Zen Cart moderators for review and will post back when it's available for download.

    This release contains changes associated with the following GitHub issues:

    #5: zc156, calendar displays off-screen
    #6: Correct various PHP Notices.
    #8: Correct error when specific products/customers indicated, but no list supplied.
    #9: Add a setting to exclude orders-status values.
    #10: "Remember" the admin's selection for 'Open report in new window'.
    #11: Convert javascript to jQuery.
    #12: Convert HTML to HTML5.
    #13: Use the customer's name from the order, not the customers table.

  8. #758
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    Quote Originally Posted by lat9 View Post
    I've just submitted v3.3.0 of Sales Report to the Zen Cart moderators for review and will post back when it's available for download.

    This release contains changes associated with the following GitHub issues:

    #5: zc156, calendar displays off-screen
    #6: Correct various PHP Notices.
    #8: Correct error when specific products/customers indicated, but no list supplied.
    #9: Add a setting to exclude orders-status values.
    #10: "Remember" the admin's selection for 'Open report in new window'.
    #11: Convert javascript to jQuery.
    #12: Convert HTML to HTML5.
    #13: Use the customer's name from the order, not the customers table.
    Now available for download!

  9. #759
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    I've just submitted v3.3.1 of Sales Report to the Zen Cart moderators for review; I'll post back here once it's available for download.

    This release contains changes associated with the following GitHub issues:


    #14: Correct PHP 7.3 warning
    #15: Correct custom date-range not remembered

  10. #760
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    8,843
    Plugin Contributions
    69

    Default Re: Sales report 2.0

    Quote Originally Posted by lat9 View Post
    I've just submitted v3.3.1 of Sales Report to the Zen Cart moderators for review; I'll post back here once it's available for download.

    This release contains changes associated with the following GitHub issues:


    #14: Correct PHP 7.3 warning
    #15: Correct custom date-range not remembered
    Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9

 

 
Page 76 of 76 FirstFirst ... 2666747576

Similar Threads

  1. v139b Sales Report
    By irishshopper in forum General Questions
    Replies: 1
    Last Post: 26 Jan 2014, 01:00 AM
  2. Sales Report
    By jgold723 in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 9 Nov 2011, 05:58 PM
  3. Sales report
    By tlahtine in forum All Other Contributions/Addons
    Replies: 2
    Last Post: 27 Dec 2010, 10:01 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR