New products is showing *all* products

[dbrewster]

Hello again.

Working on my test site first.

The New Products listing is showing ALL products, even though:

1) I set Admin > configuration > Maximum value > New Product Listing - Limited to ... 7 days

2) I checked my products table and changed all the 0000-00-00 00:00:00 (artifact of EZPopulate) to 2006-01-01 00:00:00.

Still, all those products with products_date_added going back even to 2005, are showing up in New Products.

Doesn't New Products draw its list from products table, products_date_added field?

THANKS in advance!

[DrByte]

Yes, that's what it's supposed to do.

What version of Zen Cart ?
What addons are installed?
What version of MySQL/PHP?

[dbrewster]

What version of Zen Cart ?

Upgraded 1.3.0.2 --> 1.3.5

What addons are installed?

Many modifications, but none that would impact this.
Cross Sell 1.3.0, Purchase Order, USPS with handling % option, Comodo Trust (with thawte substituted), css flyout categories, MZMT, custom order motive based on order source, tax exempt, email address exporter. and a custom product type called "register" which doesn't have any special features yet.

What version of MySQL/PHP?

PHP 4.4.1
MySQL 4.0.25

My testing website

[dbrewster]

Reverting /includes/modules/pages/products_new/header_php.php to the previous version (1.3.0.1) fixed this problem.

Perhaps this has something to do with it:

line 19  $display_limit = zen_get_products_new_timelimit();

version 1.3.5: changed to

            $display_limit = zen_get_new_date_range();

these functions are defined in includes/functions/functions_lookups.php

[Ajeh]

In v1.3.5 you should have everywhere:
$display_limit = zen_get_new_date_range();

Are you sure you did not have a file out of date?

I see all lines for:

$display_limit = zen_get_products_new_timelimit();

commented out ...

[Ajeh]

Oh good grief ... some idiot ... left in a:
return "";

before the proper return value ...

and forgot to finish the code ... gads ...

NOTE: NEW CODE 9-10-2006
Change the code to read:

// build date range for new products
  function zen_get_new_date_range($time_limit = false) {
    if ($time_limit == false) {
      $time_limit = SHOW_NEW_PRODUCTS_LIMIT;
    }

    // 120 days; 24 hours; 60 mins; 60secs
    $date_range = time() - ($time_limit * 24 * 60 * 60);
// echo 'Now:      '. date('Y-m-d') ."<br />";
// echo $time_limit . ' Days: '. date('Ymd', $date_range) ."<br />";
    $zc_new_date = date('Ymd', $date_range);
    switch (true) {
    case (SHOW_NEW_PRODUCTS_LIMIT == 0):
      $new_range = '';
      break;
    case (SHOW_NEW_PRODUCTS_LIMIT == 1):
      $zc_new_date = date('Ym', time()) . '01';
      $new_range = ' and p.products_date_added >=' . $zc_new_date;
      break;
    default:
      $new_range = ' and p.products_date_added >=' . $zc_new_date;
    }
    return $new_range;
  } 

How terribly embarassing ...

Thanks for the catch ...

[Darkwander]

I have the same problem, but am unsure what i am suppose to do..

// display limits
// $display_limit = zen_get_products_new_timelimit();
$display_limit = zen_get_new_date_range();

$products_new_query_raw = "SELECT p.products_id, p.products_type, pd.products_name, p.products_image, p.products_price,

That is my lines from the page
header_php.php

from directory
/public_html/shop/includes/modules/pages/products_new/

[Ajeh]

Check the bugfix in this thread for the New Products ...

http://www.zen-cart.com/forum/showth...165#post259165

[Darkwander]

Thanks for your help..

[dbrewster]

Thanks for the fix, Ajeh-san!