Stock by Attribute v4.0 addon for v1.3.5-1.3.9

[izar74]

Yeah, you're the first one to report anything about it. Issues confirmed to exist and have been corrected through the following "comparison" commit (though this was discovered through use of EO 4.1.7 on ZC 1.5.5 that was slightly modified to work with SBA).

https://github.com/mc12345678/Stock_...3d1a60cda91485

These exist on the master branch of the plugin.

Hi again,

thank you for the answer. I applied all the changes, now no error log is generated but if i try to update and order containing an article with no SBA variants defined but with variants i get a warning and no update are made.
To be more specific i tested:
1. adding products with SBA variant -->work fine
2. adding products without any variants ---> work fine
3. adding products with variants no SBA defined --> work fine
4. modifing product with variants no SBA defined --> ERROR no update are made to just variants

To be precise now it show both the warning:

"Product 2 in the list below, named 'Incenso', with a quantity of 1 did not exist. Attribute(s) selected:
Quantita: 100
Its attribute(s) were not updated."

And after the green message: "Success: Order has been successfully updated."
The order has 2 article:
n°1 has SBA attributes and if I modify it, It got update correctly.
n°2 has no SBA attribute defined and if i try to update the attributes it wont, BUT if i modify quantity or price it work, so the only thing not updated are the attributes.

here a screen of it


Hope it will help

[mc12345678]

Info certainly did thank you for being so thorough. I haven't tested this, but would appreciate feedback on it.

In admin/includes/init_includes/init_eo_sba.php, line 171 add the following:

if (!$_SESSION['pwas_class2']->zen_product_is_sba($product_id)) continue;

                        $product_id = $old_product['id'];

                        if (!$_SESSION['pwas_class2']->zen_product_is_sba($product_id)) continue;
  
                        // Handle attributes
                        if(!empty($product_options) && is_array($product_options))

[izar74]

Thanks to you for your effort, I'm merely trying to solve this

Ok Modified and tested, the result is that now no warning appears and it correctly change the attributes. The problem is that it wont change the price associated with the attributes.

Let me be clear, in the image i posted You can see that the second products "Incenso" has a base price of 5 with a base attribute of 50g, the other attributes is 100g and should apply a +5.00 to the item (it does correctly during the normal buying process).
Now editing the orders wont show any warning and if You change the attribute it will be updated correctly, but the price will remain always 5.00.

I'm going to do some more testing with mixed product if i came up with something else i'll post it

[izar74]

Sorry i realize only after writing that probabily It's not something that concern SBA module but it's an Edit Order plugin problem cause it affect all the article (SBA or not).
I will test this to be sure.

[izar74]

Hi again,

confirmed everything works fine. Adding and removing articles and modifing it is ok!

Thanks a lot for the help

[mc12345678]

Hi again,

confirmed everything works fine. Adding and removing articles and modifing it is ok!

Thanks a lot for the help

Thanks for the feedback. It has helped to make the plugin better. I can recall wanting to have those two changes in place, but had moved onto something else before either identifying the issue or it becoming a problem. I think I had just been merrily testing the SBA operation so much that I didn't go back to finish off the remaining. (think I even commented on its limitations at the time of posting awaiting some feedback that you have thankfully provided.)

[thymine]

Hi all,

I am new to 1.55e, just did a fresh install and i cant seems to find the option to display stock level on the attribute


Already did the options for
Config > Product type > General > Show Quantity in Stock = 1
Config > Stock > Show Quantity in Stock > true



Sync'ed a few times already but still not showing

Anyone could give me some tips on where should i start looking? Thank you!

[mc12345678]

Hi all,

I am new to 1.55e, just did a fresh install and i cant seems to find the option to display stock level on the attribute


Already did the options for
Config > Product type > General > Show Quantity in Stock = 1
Config > Stock > Show Quantity in Stock > true



Sync'ed a few times already but still not showing

Anyone could give me some tips on where should i start looking? Thank you!

For single attribute product/option names like shown above, the option name type needs to be modified to the newly added (new to your ZC) SBA Basic select (dropdown) either through the option name manager or thanks to the support of fbroz through one of the two scripts in the configuration section.

If that has already been done, there should also be a setting in configuration->Stock: SBA Show Stock Level on Product Info Page which is really the option of concern because it operates independent of the display of the total product count.

[thymine]

For single attribute product/option names like shown above, the option name type needs to be modified to the newly added (new to your ZC) SBA Basic select (dropdown) either through the option name manager or thanks to the support of fbroz through one of the two scripts in the configuration section.

If that has already been done, there should also be a setting in configuration->Stock: SBA Show Stock Level on Product Info Page which is really the option of concern because it operates independent of the display of the total product count.

Thank you MC, you solved my problem! Yes the SBA Basic select (dropdown)!!

[mc12345678]

This affects a "limited" group meeting the following conditions:
1. Software downloaded from the master branch of the github repository at https://github.com/mc12345678/Stock_...butes_Combined
2. obtained between Jul 28th, 2017 and Oct 15th, 2017.
3. Product is tracked by SBA and has only one option name (attribute).
4. one or more option values (variant) is out-of-stock.

The condition observed is that when looking at the product info page, the list of attribute options contains some random like information such as the same option value listed more than once some with the out-of-stock notification some without, blank squares/selections, etc...

Specific resolution to this is to update the includes/classes/observers/class.products_with_attributes_stock.php file; however, there have also been some additional enhancements to the admin side. Basically the recommendation would be to update the includesand admin/includes files that are not template or version specific related.

The current commit leading to what would also be at the master thread right now is: https://github.com/mc12345678/Stock_...9a50e8a56750f2.