eway $1000 bug - help!

[emtecmedia]

Hi,

I have installed the eway module i found on this forum but there is a bug with any order over the value of $1000, it only charges the customer $1 instead of $1000.

I believe it has something to do with line 231 of eway.php attached. Code is: $my_totalamount = number_format($order->info['total'], 2) * 100;

The idea is to convert the dollar and cent value to just cents, as eway processes all transactions in cents. So $25.25 would be 2525cents. But something goes wrong when the value is more than $1000.

If anyone has any ideas or experience with this kinda thing using other payment modules that would be great.

Thanks,
Brad.

[DrByte]

This post addresses this bug, and a second one:
http://www.zen-cart.com/forum/showthread.php?t=41952

However, I believe the "correct" fix for this is the following:

$my_totalamount = number_format($order->info['total'], 2, '.', '') * 100;

(This forces 2 decimal places, with a . to separate, and says to NOT use the standard comma as a thousands-separator.)

[paulm]

No experience at all with that module, but maybe it happens because 1000 is formatted as 1.000 or 1,000 ?

$my_totalamount = number_format($order->info['total'], 2, ',', '') * 100;

(in which the hardcoded ',' should be replaced by the decimal separator definition?)

The second '' removes the thousands separator.

[emtecmedia]

Can anyone else confirm this would fix the problem?

[paulm]

Two isn't enough? ;-)
(one of which being a Zen Cart dev)

note: use DrByte's '.' in stead of my ',' .

(eway is from the US I assume now, where I live we usually use the ',' )

[emtecmedia]

Sorry, I only saw the 1 post before! Thanks guys, very much appreciated!

[paulm]

Sorry, I only saw the 1 post before!

Yeah, I already thought so :-)

[reuben]

Actually Dr Byte, eWay's policy is that amounts should be specified with no place holders at all.

Therefore your fix, according to eWay's spec, is "incorrect".

Cheeky.

[xman888]

Hello,

I have just installed the Eway Module, and was wondering if I too need to correct the $1000 bug, or if the Eway Module has been improved on since the bug became apparent.

Cheers,
Anthony

[emupilot]

I believe I have fixed this issue in the new eway contrib.
Works for me but the latest version (2.1) is still being approved, wait for it, don't get v2.