[Done v1.3.7] account creation bug when displaying create-account-success page

[unn]

Earlier today I installed zencart on my server. I used wget unzip changed the ownership and group on the files to be used by my apache user. Install went smoothly. I go to create a test user and I get the following error.

Warning:  Invalid argument supplied for foreach() in /home/httpd/vhosts/eastmedent.com/httpdocs/store/includes/templates/template_default/templates/tpl_create_account_success_default.php on line 26

I did a little research on the forums, thinking that this was a common problem, oddly I found that it only happened when upgrading or using a mod by NotGoddess. Both of which I haven't done, as this is a default install, completely fresh.

A little about my server:
Apache on Red Hat
PHP 4.3.2
MYSQL 3.23.58

I gave it a shot at debugging what's going on and I'm feeling it has to do with line 41 of the the create_account_success header_php.php. But today is one of those days where I just can't think.

  $addressArray[] = array('firstname'=>$addresses->fields['firstname'],
                          'lastname'=>$addresses->fields['lastname'],
                          'address_book_id'=>$addresses->fields['address_book_id'],
                          'format_id'=>$format_id,
                          'address'=>$addresses->fields); 

Any help would be greatly appreciated.

Thanks,
David

[DrByte]

I can't reproduce the problem unless I delete code from the files, making the array unavailable.


in the header_php.php file, as you mentioned, line 41 produces the array:

  $addressArray[] = array('firstname'=>$addresses->fields['firstname'],
                          'lastname'=>$addresses->fields['lastname'],
                          'address_book_id'=>$addresses->fields['address_book_id'],
                          'format_id'=>$format_id,
                          'address'=>$addresses->fields);

Then line 26 of the template produces the output by looping through the array:

  foreach ($addressArray as $addresses) {

If the header_php.php file is missing code, then I could see this happening.

I suppose if you failed to actually save a valid address, then the error would appear too, since that array isn't initialized outside of the loop that produces the address data for output.

To initialize the array and suppress the error, you could add this on line 37 of the header_php.php file:

$addressArray = array();

, right above this line:

while (!$addresses->EOF) {

Thus, if you have some sort of database problem preventing the address from being saved, or a sessions problem preventing the customer's session id from being retained, then you'll see no address displayed, but also no error.

[unn]

Thanks for your quick reply. The thing is I didn't delete anything from any files as it was a completely fresh install. I have two instances of zencart on my server for two different clients and its the first time this happened. As for saving a valid address I am using my actual address, not some made up one.

But after initializing the array like you said the create_account_sucesss page seems to work fine.

I can't imagine that this is a database issue because even before when the error was occuring my info was being inserted correctly, though I couldn't log in.

Even though you provided a work around, DrByte, if you're interested in looking into this problem further, I'd be more then happy to provide any information you need.

[DrByte]

I'm puzzled as to why there would be no data returned, and thus trigger the error you mentioned ... as long as you're not importing customer records.

Can you reproduce the error on-demand if the fix above is not applied? Can it be produced repeatedly? If so, please post your server (ie: PHPinfo output) and browser specs.

[unn]

On my powerbook, yeah I can always produce the error in Firefox 2. Using Safari on my coworkers computer it seemed works fine, with the fix off. See php info here.

[jetx]

Your two client sites wouldn't be sharing the same database would they?