[Done v1.3.7] Coupon Admin - Percentage error with DECIMAL datatype

[Granitepants]

Found a potential bug with the coupon administrator when using a percentage discount.

I just downloaded Zen Cart and began playing with it before realizing it was not optimized for the newer versions of PHP/MySQL. Turns out that when I tried to create a coupon using a percentage, I got the following error:

1366 Incorrect decimal value: '5.0000%' for column 'coupon_amount' at row 1

Appears that the DECIMAL datatype in MySQL changed the way it is stored. Details can be found here:

http://dev.mysql.com/doc/refman/5.0/...l-changes.html

Long story short - DECIMAL is no longer stored as a string, but tables created in older versions of MySQL will keep the old behavior. I guess if someone upgrades to the latest version of MySQL, they won't notice this problem.

Guess I have three options:

Downgrade MySQL and probably PHP (most logical)
Rewrite the code (me?..yea right)
Change the coupon_amount datatype(tried, didn't work, not best solution anyway)

Currently using:
Apache 2.0.55
PHP 5.1.6
MySQL 5.0.26

Any suggestions? Great application by the way. Y'all done good.

[JeffD]

We are using very similar versions of PHP and MySQL

MySQL 5.0.21-community
Apache/2.2.2 (Win32) mod_ssl/2.2.2 OpenSSL/0.9.8b PHP/5.1.4

and we use percentage coupons with no problem whatsoever, but we do comment out the following in the my.ini file.

#sql-mode="STRICT_TRANS_TABLES,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"

Perhaps this might be all that is necessary for you to do?

Jeff

[Granitepants]

Re-installed with your suggestion and it worked. Appears I had a fourth option. Thanks for you help Jeff.

[JeffD]

Glad that worked for you!

You're very welcome...

Jeff

[wilt]

Hi the problem as suggested is caused by a tightening of the way mySql validates values to be entered into a DECIMAL field. As it is no longer a form of string any non numeric chars will cause an error,

There is a simple code fix.

in admin/coupon_admin.php at around line 227/228 and after these lines,

        $coupon_type = "F";
        if (substr($_POST['coupon_amount'], -1) == '%') $coupon_type='P'; 

add

        $_POST['coupon_amount'] = preg_replace('/[^0-9.]/', '', $_POST['coupon_amount']); 

HTH

[Granitepants]

Thanks Wilt. I reinstalled after changing the my.ini back to the original settings, but I added the % into the preg_replace function:

preg_replace('/[^0-9.%]/', '',

worked great.