Gift Wrapping Contribution

[strelitzia]

I've been working on upgrading my first site to 1.5.6a, and just discovered that admin/includes/classes/order.php has been deprecated.

Is there a solution to keep giftwrap working as the module edited this file.

[swguy]

It's on my list. If you go to my home page, there's a list of my modules showing which have been updated for 1.5.6 and which still need work.

[gernot]

Hi swguy,
I'm also intending to install this useful module in 1.5.6b one way or another, and wonder if the MyISAM table engine for the table initiated in "orders_wrap.sql" is still the best choice, or if InnoDB or some other engine would be recommended now. Just a thought, no idea if relevant or not!

[swguy]

ENGINE=MyISAM is how the Zen Cart tables are created by default.

[gernot]

Ah, OK, thanks for setting me straight!

[gernot]

Just to report back that copy/pasting the diffs from this module when compared to 1.5.5a code, into 1.5.6b zencart files works well.
Obviously, copying the core files as they are is a no-no, and I imagine most people have already incorporated some changes, so merging is normal activity.

For the custom templates, I note that tpl_checkout_confirmation_default.php exists in the classic_responsive template (which I use), the other two files need to be copied over template_default template.

The admin/includes/classes/order.php file no longer exists, as we know, so that work simply falls away (store front class order.php does the job).

I did not try to update the HTML code to the standard of 1.5.6b, no doubt some improvement in column alignments or some such might happen, I might have time to tweak the code over the weekend, but this is just to give a heads up that the module absolutely still does work.

Thanks swguy!

[swguy]

I'll try to get the update to Gift Wrap done this week. I have fallen off the wagon with my 156 updates!

[gernot]

Thanks! Any changes I am happy to test them.
I also note that in my demo cart, I found that there are plenty of gift-related attributes, including wrapping, set up for some products.
In that case, there is actually the possibility of choosing wrapping at product selection from the attributes (with their own pricing), and wrapping from this module.
Not sure how to resolve this, maybe just disable the gift wrapping attribute on products if one is intending to use this module....

[swguy]

Gift Wrap has been updated for Zen Cart 1.5.6.

[gernot]

Thanks a stack for the cosmetic changes needed (and one logic check). I could revise my initial copy/paste with those extra changes, looks a bit nicer indeed. Thank you once again!