[DONE v1.3.8] Quantity Discounts Show when Store Status == 1

[chadderuski]

Hi! I think i found a bug!

thank you for the help. I made a couple corrections to the template that eliminated the login from the menu, and then made the settings you suggested in admin. This appeared to work until I shockingly discovered that if price quantity breaks are enable, that these are displayed dispite store status.

see this here at a fresh install with test data and a product that I added breaks to:


http://chicagophoto.net/shop/index.p...&products_id=1

I didn't expect this and will have to immediately delete any price breaks I had entered to get them off the site. If you could direct me to the correct file to look at I will see what I can do to fix it for myself. Hopefully fixed in next update!!!

Thank you!!!

[Ajeh]

Upgrade ... this was fixed sometime ago ...

What version are you running?

[Ajeh]

Then again ... let me look into this further ...

[Ajeh]

That .. er ... unexpected feature can be fixed with editing the file:
/includes/modules/products_quantity_discounts.php

Change the case:

  case (CUSTOMERS_APPROVAL == '2' and $_SESSION['customer_id'] == ''):
  // customer may browse but no prices
  $zc_hidden_discounts_on = true;
  $zc_hidden_discounts_text = TEXT_LOGIN_FOR_PRICE_PRICE;
  break; 

To read:

  case (STORE_STATUS == 1 || CUSTOMERS_APPROVAL == '2' and $_SESSION['customer_id'] == ''):
  // customer may browse but no prices
  $zc_hidden_discounts_on = true;
  $zc_hidden_discounts_text = TEXT_LOGIN_FOR_PRICE_PRICE;
  break; 

Moving to Bug Reports ...

[chadderuski]

Thanks Linda! I'm glad I was able to contribute something positive. I'll adjust the code per your post. I knew it was likely an easy fix.

Yes, this was a fresh install of 1.3.7 with your test data.

And thank you for checking this carefully! I know you must get an unbelievable amount of posts that are simply user error, in the FAQ, or fixed with an update.

-cj

Long-time programmer, but only still speak pigeon-php

[Ajeh]

I appreciate your posting it ... things like this amaze me at times as that has been there for so long ...