Possible logic bug in zone comparisions

[hem]

I I had a problem where the tax was not being calculated once I logged in. Turns out my problem was this piece of code in functions_taxes.php:

    if (STORE_PRODUCT_TAX_BASIS == 'Store') {
      if ($zone_id != STORE_ZONE) return 0;
    } 

Being in Ireland we do not have zones (there's counties but there would not be a different VAT rate per county). And I have the tax basis set to store. However, sometime in the past I had created a zone just called "Republic of Ireland" and set the Store Zone to that. I subsequently deleted it. This left my Store Zone reading "190" (the zone ID of the deleted record) with no way to clear it in the configuration. I ended up setting to 0 via SQL.

My suggested change to the code would be:

    if (STORE_PRODUCT_TAX_BASIS == 'Store' && STORE_ZONE!=0) {
      if ($zone_id != STORE_ZONE) return 0;
    } 

And also if STORE_ZONE==Zone being deleted UPDATE SET STORE_ZONE=0

[kobra]

However, sometime in the past I had created a zone just called "Republic of Ireland" and set the Store Zone to that. I subsequently deleted it.

And it appears that you then did not reset the store zone to anything

[hem]

You can't- the drop down is empty. Hence the bug.

[kobra]

You should set a Zone even if all the UK countries - what if a USA or AU tries to but from your shop?

Zones does not specifically mean postal zones from the script perspective it is what ever you define it to be

[hem]

I would expect in that instance that the fall back would be country rather than zone.

And the ROI is not in the UK. I don't mind but many do...

[kobra]

I would expect in that instance that the fall back would be country rather than zone.

And the ROI is not in the UK. I don't mind but many do...

But it could be in a zone that you define...

I would suspect that the "bug" is that when the set zone is deleted from the admin that the DB entry is not

[hem]

I would suspect that the "bug" is that when the set zone is deleted from the admin that the DB entry is not

Correct- hence my pseudo-code suggestion in the root