In file: includes/modules/pages/advanced_search_result/header_php.php
The ending ?> seems to be missing in 1.3.8
With a diff viewer the last line has changed from ?> to //EOF
I'm in the process of updating my shop so I can't confirm if it actually breaks anything(?)
Results 1 to 3 of 3
-
5 Dec 2007, 01:22 PM #1
Zen Follower
- Join Date
- Mar 2004
- Location
- Finland
- Posts
- 488
- Plugin Contributions
- 3
[Not a bug] Missing ?> in advanced_search_result/header_php.php
Working with Zen Cart since 2003 :: www.prr.fi
Author of the original Finnish language pack for Zen Cart since 2004
-
5 Dec 2007, 02:05 PM #2
Totally Zenned
- Join Date
- Apr 2007
- Location
- Herts. UK
- Posts
- 890
- Plugin Contributions
- 4
Re: Missing ?> in advanced_search_result/header_php.php
Hi,
PHP doesn't require the closing tag, it is assumed when the end of the file is reached. Leaving them out helps prevent accidents, like additional whitespace after the closing tag, which cause errors (headers already sent message).
More information can be found here...
http://uk.php.net/basic-syntax.instruction-separation
Regards,
Christian.Last edited by CJPinder; 5 Dec 2007 at 02:11 PM. Reason: Added link to more information.
-
Re: Missing ?> in advanced_search_result/header_php.php
Christian is correct. And this will be an increasing practice in future versions of Zen Cart.
An FAQ has been added for future reference:
https://www.zen-cart.com/tutorials/i...hp?article=313.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole
Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.
Similar Threads
-
v151 [Not a Bug] tpl_account_history_info & header_php lacks global order total module
By twitchtoo in forum Bug ReportsReplies: 2Last Post: 5 Feb 2014, 04:45 PM -
v151 [No bug]extra opening in includes\modules\pages\advanced_search_result\header_php.php
By Design75 in forum Bug ReportsReplies: 3Last Post: 10 Apr 2013, 03:46 PM -
[Not a bug] Missing double quotes in html_output.php
By ckosloff in forum Bug ReportsReplies: 4Last Post: 12 Aug 2009, 02:18 AM -
productArray - not in header_php.php?
By mdewyer in forum General QuestionsReplies: 0Last Post: 8 Jul 2008, 02:53 AM -
[not a bug] Checkout Shipping's header_php.php
By conor in forum Bug ReportsReplies: 4Last Post: 29 Mar 2007, 09:41 PM
Bookmarks