[Done v1.3.9] Website payments pro total amounts bug

[chmac]

G'day,

My brother has been having a problem with ZenCart using PayPal Website Payments Pro. The issue is that ZenCart was passing a series of values which did not add up to the order total. This was only on sites which were displaying prices including tax.

A fix, albeit a fairly hacky fix, is attached.

Hopefully this will help some other people with the same problem.

Update: To apply this patch without using the patch command, follow these steps:
1) Backup your files, database, and everything else that matters
2) Make a copy of includes/modules/payment/paypalwpp.php and call it includes/modules/payment/paypalwpp.php.orig
3) Edit the file includes/modules/payment/paypalwpp.php
at line 1446 add this code:
if (DISPLAY_PRICE_WITH_TAX == true)
$optionsST['ITEMAMT'] -= $optionsST['TAXAMT'];
I've included a copy of just this code in the attached file, I recommend copying & pasting it from there, so the indentation is correct.
4) Save the file, enjoy :)

[pinasiob]

IT WORKS FINE !
Thanks a lot from Italy...

Thanks, thanks, thanks !

[amoros]

This hack let me display prices with taxes and have PayPal Express checkout work correctly.

But I had to set TAX rates to NONE on shipping on the shipping module, otherwise it will not work and PayPal will reject paiement.

MODULE --> SHIPPING --> Choose the shipping module --> EDIT --> Tax Rate = NONE !!!


This is a problem for Shipping modules which send prices without Taxes (VAT excluded), like UPS...

[amoros]

So, now, does anyone have a final solution for this problem. I crawled trough many posts for hours and nobody seems to know how to solve this on zencart.

We already have missed some sales due to this.

Please help !

[crisand]

Hi,
What do we need to change in paypal express to make it work? Sorry!

[fergusmacdonald]

We have shipping taxes set to VAT, the same as all of our products, and this fix works perfectly.

[solucionoproblemas]

thanks a million, it solved the problem for me!!

[aronchi]

I've applied the patch but I still have this problem:

my configuration:

Cifre decimali delle Tasse(decimals in taxes) 0 Info
Mostra i Prezzi con Tasse(show prices with taxes) incluse true Info
Mostra i Prezzi con Tasse incluse in Admin (show prices with taxes in admin) true Info
Calcolo Tasse Prodotti basato su Store (tax calcolation store based) Info
Calcolo Tasse Spedizione basato su Store (shipping tax calculation store based) Info
Visualizzazione Tasse di Vendita (show selling taxes) 0

Can you help me?

zen cart 1.3.8a italian.

[ParadiseFun]

Works with me!

[Tropheus]

Hi chmac.

Will this patch work with PayPal Express?, it appears to be the same problem with miss matched amounts?