Google Checkout module for ZC 1.3.x (beta)

[ropu]

I'm about ready to scrap this, but figured I'd give it one more shot....

I ran the Responsehandler test again and got these results:



I was encouraged by the fact my response time was far less than 3 seconds, so again I placed a sandbox order and got the default shipping rates - not the UPS rates. Then, I logged into my Merchant Sandbox and retreived the following error message:



I've read and re-read all the posts in this forum over and over again, and am really at a loss as to what is causing these errors.

I'm not a programmer and certainly no expert on the meaning of the results in the above test, so perhaps there is something you can tell me that can help me fix it???

Also, what I'd really like to know is....who are you, Ropu? Do you work for Google? I can't imagine you'd spend as much time on this mod as you seem to if you were doing it for free, or for a few Paypal donations.

The obvious reason that store owners want this mod installed is for the free charges until the end of the year. My average order is about $500, so the 2.5% savings I would experience equals $12.50 more in my pocket on just about every order I fill. That adds up. But I really can't become a Google Beta tester...I simply don't have the time....I have a business to run.

So if you do work for Google, Ropu, tell them you need help in getting a stable release to market for the Zen Cart community ASAP....a release that even a novice user can install effortlessly. If you are doing this from the kindness of your heart, and not getting paid, then please email me when you have a stable production version and I will Paypal you my donation. And please let us all know who you are.

hI jay

as u can see in the XML response, u have sent an invalid XML message. it seems that u didn't put any XML in the textarea. try adding the xml that the integration section shows u as an error and try again

thx

ropu

[ropu]

Well it appeared this was working last eve, but now it appears not. If anyone has suggestions to repair my noob logic above, please do suggest.

Thanks,
Woody

woody, i use this code to detect virtual goods

    <?php
      if(MODULE_PAYMENT_GOOGLECHECKOUT_VIRTUAL_GOODS == 'True' && $cart->get_content_type() != 'physical' ) {
        echo '<div class="warning">' . MODULE_PAYMENT_GOOGLECHECKOUT_TEXT_VIRTUAL . '</div>';
      }
    ?>

hope this helps

ropu

[ropu]

ropu,

On the Zen Cart admin orders index page, a line item appears for each order, which includes the shipping method employed to process the order.

So in my installation "itemnational" or "iteminternational" or "free", should display for the shipping method.

However on the admin orders index page "table" is displayed as the "shipping method" when purchasing with Google Checkout.

Any suggestions on displaying the actual shipping module name instead? (as other payment modules do).

Thanks,
Woody

Will be in RC2

thx

ropu

[ropu]

1. Regards to Google Checkout info posted to ZC admin orders page...

I observe ALL the responses from Google Checkout display in the comments area in Zen Cart admin orders page.

Keep in mind all info posted to the comments area is available to the customer if they log into their Zen Cart (via MyAccount) which is possible if an customer with an preexisting Zen Cart account submits an order through Google Checkout or if a new customer wants access to their order through Zen Cart... which will likely be the case when downloads are supported by Google Checkout.

So it would be best if the Google Checkout mod posted most of the responses to an area on the orders page which is only accessible to the admin. (similar to as the PayPal IPN payment mod does... display the data in an HTML table above the order comments area).

The only Google Checkout responses that should be displayed in the comments area is info that the customer should specifically have access to and would also likely be submitted to the customer through an email notification. That would include state changes from pending to processing (or other orders status changes such as canceled or refunded). (again just like the PayPal IPN mod does).

If you don't have PayPal IPN mod installed or not sure which I refer to please let me know and I can show you an example of what data PayPal data shows in the comment boxes (and thus is accessible by the customer) and what data is posted to the admin orders page (which is NOT accessible by the customer).

2. On a related admin issue...

For an order submitted through Google Checkout I observe displayed in the first comment box on the ZC admin orders page "Buyer's Password: 34600848543"

If a customer already has a Zen Cart account, then checks out through Google Checkout with the same email address, it appears Google Checkout relates that order data to the preexisting Zen Cart account. If this is the case is the previous customer Zen Cart password overwritten with the new password created by Google Checkout, or does the pre-existing Zen Cart customer account password still hold true?

Also say if a customer whom never has set-up a Zen Cart account checks out with Google Checkout, and then later revisits the shop and decides to set-up a new account. How does that process work? Zen Cart would see an account was already set-up with that specific email address and thus not allow the customer to create a new Zen Cart account with that email address.

But the customer might not understand this and become confused. What is the mechanism in place to deal with such an issue. Maybe prompt customer to click on "password forgotten" link to obtain via email the account password created by Google Checkout.

And are there any security risks to consider here?

Hope this all makes sense.

Thanks,
Woody

woody, i dont have Paypal IPN, y u can mail me screenshoots would be nice

i've also added that if the user is a prexistance one, (he bought logged in Zencart), the User/pass line wont be shown, as his pass is not changed. (v1.3RC2 NOT beta)

Regarding the user creation, is inevitable to create one. This users are stored in google_checkout table for cross reference GC buyer id- zencart buyer id.

The password is the buyer number id. but created just the first time. if he logs in, and changed, that one will be preserved.

i he tries to create a user with his GC mail, he must prompt for a forgotten password... any other idea to get by passed this??

ropu

[ropu]

ropu,

Here is some strangeness I'm observing while testing the mod in sandbox mode...

As a customer I add a single item to my shop cart then check out via Google Checkout. Then on the Google Checkout page I decide to not complete the transaction (for any reason) and then I close my browser window. Then I later revisit the shop. When I do, I unexpectedly observe the shopping cart sidebox is displayed. And the contents of the SC sidebox is "1 ea. - " with "Total $0.00". That is no actual product name is listed, just 1 each with no price and then a zero total.

This is strange as the shopping cart sidebox should not display when there were no items in the shop cart. It appears that Zen Cart is attempting to recall contents of the abandoned shop cart (when the Google Checkout order was not completed) but cannot. It's as if a 'ghost" non-item is still in the shopping cart.

But this does not become a real issue until I add an item to shop cart then proceed to the shopping cart page. At that point a yellow warning box appears stating the item in my shop cart is no longer available in inventory and has been deleted from my shopping cart.

Although this applies to the "ghost" item and not the item I just added to my shop cart, it is confusing nevertheless and not suppose to be occurring. A customer might think like I did that the message had to do with the item I just added to the shopping cart.

I installed the new Google Checkout mod on two different ZC 1.37 test shop installs and observe the same behavior. Anyone else able to replicate?

Woody

please post the step-by-step to reproduce it, and i'll test it

also tell me if u can do it in http://demo.globant.com/~brovagnati/zen_demo2/

thx

ropu

[Woodymon]

woody, i use this code to detect virtual goods

    <?php
      if(MODULE_PAYMENT_GOOGLECHECKOUT_VIRTUAL_GOODS == 'True' && $cart->get_content_type() != 'physical' ) {
        echo '<div class="warning">' . MODULE_PAYMENT_GOOGLECHECKOUT_TEXT_VIRTUAL . '</div>';
      }
    ?>

Thanks ropu,

Just tried that and this portion of the code

$cart->get_content_type() != 'physical' 

causes the page to not fully load.

Error in web server error log is:

PHP Fatal error:  Call to a member function get_content_type() on a non-object in /home/myaccount/public_html/myshop/includes/templates/mytemplate/templates/tpl_product_info_display.php on line 130

Uncertain how to interpret "Call to a member function on a non-object"
Something to do with passing a parameter correctly and/or data type?

In /includes/classes/shopping_cart.php I see

class shoppingCart extends base {
    .
    .
    .
  function get_content_type($gv_only = 'false') {
    global $db;
    .
    .
    .
    if ($gv_only == 'true') {
      return $gift_voucher;
    } else {
      return $this->content_type;
    }
  } 

Any ideas?

Thanks,
Woody

[ropu]

Thanks ropu,

Just tried that and this portion of the code

$cart->get_content_type() != 'physical' 

causes the page to not fully load.

Error in web server error log is:

PHP Fatal error:  Call to a member function get_content_type() on a non-object in /home/myaccount/public_html/myshop/includes/templates/mytemplate/templates/tpl_product_info_display.php on line 130

Uncertain how to interpret "Call to a member function on a non-object"
Something to do with passing a parameter correctly and/or data type?

In /includes/classes/shopping_cart.php I see

class shoppingCart extends base {
    .
    .
    .
  function get_content_type($gv_only = 'false') {
    global $db;
    .
    .
    .
    if ($gv_only == 'true') {
      return $gift_voucher;
    } else {
      return $this->content_type;
    }
  } 

Any ideas?

Thanks,
Woody

yes, sorry my mistake, i forgot to add this

$cart = $_SESSION['cart']; 

btw, the error is saying that u are trying to call to a method on a variable that is not an object.
ropu

[ropu]

Hi ropu-

Your 1.3-RC2beta update fixed my shipping issues!!!!! Thank you!!!!

With that said below are some suggestions for mod improvement (in order of priority):

1. Email formatting issues for messages sent to both shop admin and customer, accepting email in text format only. (test email format support is a MUST!)

2. Email addressing issues (customer should at least be able to reply to the "Order Receipt" message and thus the reply to address should be the shop admin email address).

3. On the last Google Checkout page which displays after an order is processed, provide an option for a link and a redirect to a Zen Cart checkout success page.

4. Support for "split login page" functionality built into Zen Cart 1.37.

Other suggestions:

- a few additional clarifications/edits in the mod docs
- clean-up of "shipping methods generator" readme and more comprehensive explanation/example on how to use the "shipping methods generator" is needed.

I will PM you my suggestions regards to the above.

Also is it possible to generate a wishlist in this thread for features we would like to see implemented in the Google Checkout for Zen Cart mod. Of course with an understanding of the current limitations and status of the Google Checkout system itself.

Thanks again for making shipping happen. Now we can test the mod more thoroughly ;-)

Woody

woody, the email format is a google issue, i've mail them with ur last suggestions.

yes, u are right bout the shipping_genaration readme, but know that i wrote it in 5 mins after finishing on friday, i'll update it.

regarding the wish list, i PM dr Byte asking if we can have a forum just like pay pal, where inside it we can have different thread (as u suggested me ), one could be that wish list.

im waiting for a positive answer from him

ropu

[Woodymon]

yes, sorry my mistake, i forgot to add this

$cart = $_SESSION['cart']; 

btw, the error is saying that u are trying to call to a method on a variable that is not an object.
ropu

getting closer...I think.

I used this code

<?php
    $cart = $_SESSION['cart']; 
    if ( MODULE_PAYMENT_GOOGLECHECKOUT_VIRTUAL_GOODS == 'True' && $cart->get_content_type() != 'physical' ) {
        echo '<div class="warning">' . MODULE_PAYMENT_GOOGLECHECKOUT_TEXT_VIRTUAL . '</div>';
      }
?>

Then I visited an eBook product page. The page rendered as normal but the expected warning text did not display.

So after:
$cart = $_SESSION['cart'];

For debugging I added:
echo $cart;

And I observed:

Object id #4

Any ideas?

Thanks,
Woody

[dharma]

Thank you ropu and everyone for their diligence in developing GCO for ZC. I gave up testing around page 30, but have been tuning in to these forums ever since.

since ZC as of 1.3.7 has Paypal Express Checkout code in the core files, I wanted to suggest that in the next version of GCO be compatible with the existing PPE (have both PPE and GCO working at the same time). As it stands now, there is merging of some template files, to get both working....which isn't a big deal (as a computer novice it will take me a few days to do correctly or copy chain_man's code (thanks!) )....but I don't think I can stay on-top of merging files, with every ZC/paypal express update.

I have learned a great deal about ZC, mods and editing code in these last few months, but think when it comes to accepting payments, this should be along with paypal part of the core/base files, and not a mod left to a few hard working people....but fully supported by the ZC developers and included in each new ZC release.