Image Handler 2 (for ZC v1.3.8 ONLY) Support

[kuroi]

As a matter of interest Kuroi, and no criticism intended, do your mods validate?

Yes, they do. I use the HTML Validator add-in for Firefox that gives me an icon on every page to show if it is valid or not. It's a bit more difficult to keep track of in the Admin side of Zen Cart as there is still old, non-validating osCommerce code in there, but my mods never add non-validating code and, subject to a rule of minimal intrusion into core code, I remove or correct it where it falls into the areas which I am changing anyway.

Writing valid code isn't some geeky, ideal. It's just common-sense. It's so much easier to develop this way, than to try to fix the structural and cross-browser compatibility issues that arise later if you don't. That stills leaves the ... coughs ... Internet Explorer idiosyncrasies to be dealt with, but they're a known and widely documented quantity.

I like your idea of a campaign for valid mods, but I fully understand where Dr Byte is coming from. Performing a full test of all conditions, on all affected pages, for each of the hundreds of mods in the downloads section simply wouldn't be a feasible task. However, any non-validating code should be reported back to mod authors via their support threads.

[Chuckl]

Francocauter, I think you'll find that the Product General module pages and/or templates have the necessary code to display the popup hoverbox or image handler images, and that Document General and Document Product do not. e.g. Document General might be set up without any popup larger image support at all.

Comparing the header_php, main_template_vars and tpl_ files for the different product type might give you an idea of what needs to be changed or added.
Or possibly temporarily rename or copy Product General files to the Document General equivalents until the images start to appear?

[crabdance]

Hello,
I have posted a part of this message in another area and thought that "this" must be the place to ask for help. Sorry about the extra posts. I am having the following issues:

1. Image Handler functionality does not work in Internet Explorer (no pop-up images... works fine in FF).

2. My layout gets hosed in Internet Explorer if I use more than 3 products across a row (3 works fine but 4 or 5 do not).

I really need help with this folks... my site is starting to go live and these are the only problems that I have that need to be resolved.

PLEASE HELP!
thank you in advance... I appreciate it very much.

[crabdance]

Ok everyone... here is some more info on the outstanding issues I have. As I said before IE would not work with 4 or 5 images per row and it would break the layout. Well, just for grins, I tried to set it to 6 images per row and you guessed it.... IE worked fine and dandy using 6 items per row. Doesn't make a bit of sense to me but that's what happened. So I consider that problem fixed.... 6 across is fine for me.

That leaves the Image Handler hover functionality not working or not creating any images in IE. Works great in FF. When I hover over an image in IE, nothing happens. Nothing at all. Still looking for a fix for this one. I'm hoping that some of you veterans out there can help me.

Thanks for your help and listening to me go on and on... lol
-cd-

[gothstone]

Fird my post above and replace your imagehover javascript, that will fix your hover problems in IE.

[crabdance]

Fird my post above and replace your imagehover javascript, that will fix your hover problems in IE.

Hi GothStone, thanks for trying to help. It did not do the trick though (I'm sorry to say). Can you think of anything else that it might be? I put the javascript file in my template folder/jscript location. Does it need to go anywhere else?

I will keep looking... Hope you can come up with something else. I DO appreciate your help... thanks a bunch

-cd-

[francocauter]

Hi There
I have this problem with IE7 (Only when there is additional images) with a "Document Product":
http://www.mkstay.co.uk/index.php?ma...&products_id=2

We have repaired the the same problem for the "Product General":
http://www.mkstay.co.uk/index.php?ma...&products_id=1

Do you have a solution so it works with the whole of the zen cart system and not just for the single problem?

Best Regards
Franco

[blag]

Yes, they do. I use the HTML Validator add-in for Firefox that gives me an icon on every page to show if it is valid or not. It's a bit more difficult to keep track of in the Admin side of Zen Cart as there is still old, non-validating osCommerce code in there, but my mods never add non-validating code and, subject to a rule of minimal intrusion into core code, I remove or correct it where it falls into the areas which I am changing anyway.

Writing valid code isn't some geeky, ideal. It's just common-sense. It's so much easier to develop this way, than to try to fix the structural and cross-browser compatibility issues that arise later if you don't. That stills leaves the ... coughs ... Internet Explorer idiosyncrasies to be dealt with, but they're a known and widely documented quantity.

I like your idea of a campaign for valid mods, but I fully understand where Dr Byte is coming from. Performing a full test of all conditions, on all affected pages, for each of the hundreds of mods in the downloads section simply wouldn't be a feasible task. However, any non-validating code should be reported back to mod authors via their support threads.

I am only suggesting that the Administrators of ZC, whosoever they may be, create a body of guru volunteers which validates and Certifies the code for a given mod when installed in a 'fresh' and unmodified example of the then 'current' release of ZC.

I fully appreciate that it would be impossible to check every mod's effect on every other mod, but my suggestion would at least give the potential user some degree of reassurance in that it is clean code when used in a specified 'base' environment. Any changes in either ZC, or in a mod, would require that the mod is re-submitted for Certification.

The un-certified mods could still exist in the downloads area, but Certified mods woul be identified somehow.

This could be financed quite easily I would have thought. Let's say that each download requires that the user pays a modest sum for the right to download a 'certified' mod, say $1 irrespective of the complexity of the mod, then ZC Admin might generate quite a bit of income. This income could be used to reimburse those who are responsible for issuing the Certification!! (Personally I wouldn't object to paying $1 for a mod - many are worth much more - and I don't have a problem in the Admin using the money because it is for the benefit of all users, which is why we contribute the mods in the first place)

It's comforting to know that your mods do validate - I need to check my own modest contribution I suppose!!!

[crabdance]

Hello everyone,

I have found out something else about my Image Handler 2 installation. When I go to admin->Image Handler2->preview I see nothing but blank images instead of the stock images that come with Image Handler2. I did a right click on one image, clicked on "view image" and I got the following error: "/biz/biz/admin/images/ih-test.png does not exist." Notice that the "biz" folder is listed twice but in my directory tree it's really only listed once.

Any idea of what could be causing this? Could this have anything to do with the issues I'm having with IE not showing popup images?

thanks,
-cd-

[gothstone]

Hi GothStone, thanks for trying to help. It did not do the trick though (I'm sorry to say). Can you think of anything else that it might be? I put the javascript file in my template folder/jscript location. Does it need to go anywhere else?

I will keep looking... Hope you can come up with something else. I DO appreciate your help... thanks a bunch

-cd-

That file needs to go in includes/templates/template_default/jscript/ . I have no clue why, but I've never had any luck putting it in my customtemplate directory.