Order Editor 1.3.7 Issues

[srturner47]

Stevenh76 -- Great! I'll fix the ot_group_pricing in the next version which I am working on right now.

There will be even more problems with the split tax version on the next version, as tax is also stored in the orders table, which wasn't being written before. I've fixed that, but it further complicates how the Split Tax line works. The orders_products table also has a tax line I believe that I plan to fix soon. I just don't know if there is a good way to make the edit orders mod jive with the SplitTax mod.

Still working on the shipping tax issue, but progress has been made. I've fixed the downloads issue, which actually ended up being tricky. I'm going through and trying to make sure that any other database changes that should be made are being made. There are tons of little changes that don't seem to affect anything, but may cause undesirable behaviors in certain rare situations, so I'm trying to be consistent with updates across different database tables.

This is still primarily a bug-fix release I am working on, but I think I will tag it 1.6, because it will be a major bug fix release. I'll keep you posted and hopefully have this out in the next week or so.

[stevenh76]

There will be even more problems with the split tax version on the next version, as tax is also stored in the orders table, which wasn't being written........

Agree, editing order involves so many detailed aspects. It's a hard work indeed and it's even harder to get everything run correctly. Thanks srturner47! We are all longing for the update.

[srturner47]

Bad News -- I've looked into the shipping tax issue and it appears that Zen Cart doesn't store any database information about whether or not taxes were charged on shipping and if so at what percentage rate. This data is only stored in the shipping module configuration.

Hence, it would be almost (I say almost because I guess you could check the name of the shipping and try to cross-reference that to the shipping type used and then find whether or not taxes were included for this type of shipping. But, this kind of flies in the face of this mod as any changes to the name of the shipping line would mess this up. Plus, shipping lines vary based on weight, so you'd have to write code for every shipping type and ignore the weight part. Too messy -- not worth it, and would fail in certain situations.) impossible to implement proper Shipping Taxes when editing an order.

So, I've thought it over, and I think the easiest and most flexible way to handle this would be to add a tax box next to the shipping amount. Unlike the products tax box, this would always default to 0% because there would be no database entry for it. If you need to add shipping taxes for an order when updating, you'd need to enter the tax amount in that box.

What do you think? Not a perfect solution, but I'm not sure a perfect solution exists. Let me know if anyone has any better ideas.

[stevenh76]

Yeah, I realized that too. There is no tax rate about shipping stored in order table. To get the correct shipping tax rate, we have to look up the configuration of appropriate shipping mod. Or I just have an idea -- can we just get the shipping tax by doing like what Zen Cart does during customer checkout procedure? I mean, we invoke the functions provided by Zen Cart. This seems to be complicated too, so I highly agree with your idea and just add an input box beside the shipping fee for shipping tax rate. Let users specify the tax rate for shipping.

Simplicity is always good!

[stevenh76]

Problems on adding new products!

When I add new product to an order, I found that the price was not correct. The price will be ok if it has no special price or other prices. But if a product has special price or quentity discount, the mod will still apply the normal price to the item. Users have to correct the price by hand.

I guess this problem is as hard as the shipping tax rate to fix. It's a quite complicated bug and we should leave it as is. The only thing that store admins should put more attention to is to check the price when they add new products.

[srturner47]

Yes, I know about the specials pricing problem. This shouldn't be too difficult to fix, so I am hoping to have a solution to this problem when I release the new version.

The shipping tax is much more complicated as the only things stored in the database about shipping is the cost and a field that is meant to be displayed along with it. You'd have to somehow figure out which shipping type was used to determine which taxes should be applied, which would not be easy to do.

[spinnywoman]

spinnywoman -- make sure all files are in the right directories.

Hi there. Triple checked. The problem seems to be with orders.php - post editing the two lines as follows. I am running 1.3.8.

Find:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=delete', 'NONSSL') . '">' . zen_image_button('button_delete.gif', IMAGE_DELETE) . '</a>');
Replace With:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDER_EDIT, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_details.gif', IMAGE_DETAILS) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=delete', 'NONSSL') . '">' . zen_image_button('button_delete.gif', IMAGE_DELETE) . '</a>');

Find:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');
Replace With:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDER_EDIT, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');

Ruth

[srturner47]

It is unlikely that the problem is with orders.php. Once you click edit, everything is handled in edit_orders.php.

[comraddan]

One of our customers placed an order online using a coupon that gave them 30% off. Shortly after we received the order they emailed us to let us know that they ordered two of an item and they needed just one. So I installed this add on and I was able to change the quantity and things looked fine, but two issues:

1) the shipping did not get updated to reflect the change
2) and the tax was not figuring correctly due to the coupon. It looks like the tax was figured with the subtotal not taking the 30% off into account. So the tax was higher than it should have been. On another order with a dollar off coupon, I did a quick test and things looked like they were figured correctly(except the shipping still)

Other than that this is definatly a great add on to Zen Cart!

[srturner47]

Thanks for the feedback. This is valuable information. I've been hard at work trying to sort out all the bugs and problems, but there are a lot of small things that need to be done, so it is taking a little longer than I thought. I just finished adding one-time attribute charges and price factors and offsets. I didn't even know what these did before I started working on this, so part of this has been discovery for me. There are sure a lot of options for an order, especially with attributes!

The shipping will never be updated automatically with this mod; you'll have to edit the shipping amount by hand. It would be too difficult to implement this, and it doesn't take much work to just change the shipping manually.

The taxes are calculated individually for each item using the assigned tax rate for that item. So, I don't think that a coupon should be calculated correctly when it comes to taxes. I'll look into this and see if the mod takes care of this somehow. If there is a problem, I'll see if there is a way to fix it.

It may be another week or so until I get this out, but the new version should fix most problems!