Stock by Attribute v4.0 addon for v1.3.5-1.3.9

[mc12345678]

I've installed the plugin and everything seems to be working except for one minor issue I have no idea how to go about to fix it.

I have a product with two options, the full size and a sample on a pulldown menu. The full size accepts discounts, the sample does not.
For the full size product price appears right next to the attribute in parenthesis without a discount. The sample size product price and the discount price appear right next to the attribute both in separate parenthesis.

Shouldn't this be the other way around? full size - full price and discount, sample size - full price and no discount?

Any ideas how should I go about to fix this?

Thank you for the help.

Yes, the display should be opposing and I believe it has been an issue for a while. I've made an initial correction, though who knows what other outlier I need to consider, but I'm also trying to incorporate processing using the new Zen Cart 1.5.7 attributes file such that ideally, that file doesn't need to be touched going forwards.

I'll try to prep a commit just for this price display issue and reference it back here.

I don't know if this helps in any way but I was playing with the settings and when I turned off SBA Original Price Struck Through the sale price on the item that doesn't accept sales got removed. I have the feeling that setting isn't supposed to do that

Like I said and you identified, backwards. :) I have a feeling that I was trying to find when not to apply the extra price display and then forgot to negate it so that it would show the extra price only when the item was discounted. I did discover that when I did that, that I also had to account for display only, default type attributes, otherwise it added 0.00 to the selection which is undesirable in routine use. Like said, may have missed some "outlier". Think I can have that solution in a PR soon. Then I have a lot of other changes to incorporate as I said for Zen Cart 1.5.7 and in some cases just to align the code with the way I've been corrected for standard ZC code.

But, yes, if that feature is turned off then only the "final" price is displayed not the potential full price with the final price. Also, at the moment, dropdowns do not get the "strike-through" because standard dropdowns do not support html, have to use some sort of javascript based dropdown to do that, which is a desired feature not yet incorporated.

This appears to be resolved by the following Pull Request: https://github.com/mc12345678/Stock_.../pull/64/files

It does still apply the content to standard dropdowns which could be worked out; however, hasn't been removed (yet).