Quote Originally Posted by zamzom View Post
So far so good.
Thank you mc12345678 for your quick attention and neat corrections.
I will keep reporting other issues when I come accross.

Few more things I recently encountered:
Now, the search functions in the admin/products_with_attributes_stock page. However, if the search results are more than one page, next page button does not work. It takes you to the full list of products' second page. I coudn't go into the reason of that because I have more important issues I have to fix first, but I am suspecting that it is due to POSTed values again.

Another thing I have noticed; SBA makes modifications in functions_lookups.php file in two functions:
zen_get_products_stock
zen_check_stock

PHP Code:
/**
 * functions_lookups.php
 * Lookup Functions for various core activities related to countries, prices, products, product types, etc
 *
 * @package functions
 * @copyright Copyright 2003-2016 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Author: mc12345678  Tue Feb 2 16:23:08 2016 -0500 Modified in v1.5.5 $
 * 
 * Stock by Attributes 1.5.4 15-12-21 mc12345678
 */ 
Nevertheless, it seems in ZC 1.5.8 these functions are moved into functions_products.php and a notifier mechanism is incorporated.
I wonder if these modifications can be carried there as is?
Regarding the logs of display of items meeting the search criteria when navigating to another page:
I was able to duplicate the issue using the Zen Cart default product and found a solution. I tested by searching for product with the letter e. I was presented more than one page of product when using the sba default of 25 items per screen.
Navigating to another page using either the dropdown or next page resulted in going to the selected page but included product that didn't have the letter e.
The cause is that the call to display the links does not include the parameters associated with filtering, sorting or the like.
That information should be included/added to the fourth parameter of the displaylinks method of the splitPageResults class object in a way to respect the page change and omission of any other parameter that should not apply in a page change.

An update is to follow along with the previous changes being more discreet.