I did more testings and found few small bugs. I went through all ot modules and three of them are modified.
Discount coupons had a lot to do. For any reason, the tax re-calculation modes were kind of reversed. I had some doubt at the beginning, but other modules code (GV and group discount) confirmed that.
Other discount modules, GV and Group Pricing needed few corrections too but lighter than coupons module.
I am ready to make new PRs (lost penny and coupon), it might be easier for others to review or modify. Although now that V2.0.0 is released, I am not sure anybody will still have some energy left...
Thread: Discount coupon value
Results 1 to 10 of 27
Threaded View
-
10 Apr 2024, 07:36 PM #21
Zen Follower
- Join Date
- Jun 2008
- Location
- Japan
- Posts
- 205
- Plugin Contributions
- 7
Re: Discount coupon value
Last edited by pilou2; 10 Apr 2024 at 07:39 PM.
Reply With QuoteSimilar Threads
-
v155 Discount Coupon - Minimum Order Value Excluding Tax
By allmart in forum Discounts/Coupons, Gift Certificates, Newsletters, AdsReplies: 12Last Post: 20 Jul 2020, 06:38 PM -
Subdomain Discount coupon help popup incorrectly uses main domain link and coupon ID.
By GTHENRY in forum General QuestionsReplies: 6Last Post: 19 Jun 2011, 07:06 AM -
[fixed 1.3.9a] Group Discount and Discount Coupon Tax Calculation Issue
By bobtabin in forum Bug ReportsReplies: 18Last Post: 12 Mar 2010, 06:37 PM -
Ideas/Suggestions for Discount Coupon - How to give a credit and a discount
By vegascoug in forum Discounts/Coupons, Gift Certificates, Newsletters, AdsReplies: 0Last Post: 15 Nov 2007, 05:40 PM -
Coupon welcome message showing discount when coupon is expired
By tracyselena in forum Discounts/Coupons, Gift Certificates, Newsletters, AdsReplies: 4Last Post: 26 Jan 2007, 06:32 PM
Bookmarks