Okay I took a looksee at this, and Clyde, you are right.. This wasn't so much a "fix" to a "problem" (which implies the comments were not working -- they in fact WERE working) as it was a modification to the e-mail template used.. Thanks for the clear explanation!
One thing I have been wanting to tackle is implementing the FULL alignment of the comments code in edit_orders.php to match up to the comments code used in orders.php and eliminate the need for the common_orders_functions.php file altogether. (common_orders_functions.php contains the send email functions used by both Super Orders and Edit Orders)
I have already done the same thing to a new version of Super Orders (not submitted yet). I spent a little time this past weekend doing the same for Edit Orderst, and I think I've got it working along with some other MINOR tweaks:
- Remove more of the hardcoded text in Edit Orders (the default shipping tax value can be entered in the admin versus having to be hardcoded into the edit_order.php file)
- Add an order navigation feature like the one in Super Orders
To be clear the reason for making this change is NOT because there is an issue with comments in Edit Orders at all.. The current comments functionality work just fine.. The reason for the change is so that IF the default orders.php is modified in an upcoming release of Zen Cart (as it did in the 1.38 vs 1.39 flavors of this file), the path to update Edit Orders will be CLEARER to see.. IMHO this is a LOT more difficult to see when the methods used between the two are different. So now the comments code between the two is the same.. I've been testing it and it is working with or with out the Ty Package integration. (Super Orders integration works as always as these changes do not affect this)
Bookmarks