Edit Orders v3.0 for ZC 1.3.9 [Support Thread]

[DivaVocals]

Now we're getting somewhere. Please provide a DIRECT LINK to the CORRECT zip file. And please DOUBLE CHECK it. Because I just downloaded it, again, for the third time, FROM YOUR SITE, [link redacted], and those files you're telling me that are not part of the zip are indeed part of the zip I am downloading from your site. Thank you!

Just so it's clear for others following this post I WILL NOT post a direct link to anything available on my site on this forum. (besides I think it's pretty clear anyway where to go once you are on my site) I will also be asking the admins to remove all the direct links you've posted as well.. Now.. Let me clarify WHY..

There is a REASON why I WILL NOT post a direct link to anything available on my site on this forum.. there is a reason why I direct people to the link in my signature.. (and no I don't know that all browsers don't display the signatures on this forum.. how would I know this??) It is AGAINST the rules to post links or support modules that are NOT available in the Zen Cart downloads.. I ONLY made this add-on available on my site because I am a tad BUSY right now with work and projects.. I need to finalize the readme file BEFORE I submit this to the Zen Cart downloads. However, I KNEW folks were looking for this update.. So I put it up on my site for those folks who can get away with the down and dirty install instructions in the readme and don't need the fully vetted/edited readme right now. Once I submit this to the free-downloads (and I WILL do this as soon as I finish the readme this week), it will no longer be available on my site..

Hope that helps clear things up..

[jmsnyder23]

How do you add a new downloadable product to an order? I can't figure that out.

[DivaVocals]

How do you add a new downloadable product to an order? I can't figure that out.

How to add a product has not changed (covered in the readme), but I don't know if adding a downloadable product will necessarily make the download available to the customer.. You will have to test this and let us know..

[laurelsstitchery]

Diva - I have a quick question. When a customer places an order that includes a discount coupon ($2.00 off for example), when I go back in and edit the order, sometimes the discount coupon gets reversed and added to the order total instead of being subtracted. I've noticed that happens only if I add an item to an order. If I make any other sort of change (delete item, edit shipping cost, etc.) the discount remains correct. Any idea on why this might be happening? It's no rush or anything on this. What I've been doing is just erasing the discount coupon, entering into the line below where it was and updating and then it works fine. I'd like to eventually eliminate that step though. :)

[DivaVocals]

Diva - I have a quick question. When a customer places an order that includes a discount coupon ($2.00 off for example), when I go back in and edit the order, sometimes the discount coupon gets reversed and added to the order total instead of being subtracted. I've noticed that happens only if I add an item to an order. If I make any other sort of change (delete item, edit shipping cost, etc.) the discount remains correct. Any idea on why this might be happening? It's no rush or anything on this. What I've been doing is just erasing the discount coupon, entering into the line below where it was and updating and then it works fine. I'd like to eventually eliminate that step though. :)

The changes to Edit Orders I have been involved in have been in the realm of cosmetic/esthetic changes, MINOR functional glitches/fixes, and integration with often asked about mods (namely Super Orders).

Meaning??

Well honestly I've made VERY few changes to the core code that drives Edit Orders, and I won't pretend that I know how to fix some of the MANY THINGS that's wrong with it.. otherwise I woulda tried to address the KNOWN issues I have posted about. I'll take a look, but don't hold your breath hoping I'll know how to fix this..

[laurelsstitchery]

The changes to Edit Orders I have been involved in have been in the realm of cosmetic/esthetic changes, MINOR functional glitches/fixes, and integration with often asked about mods (namely Super Orders).

Meaning??

Well honestly I've made VERY few changes to the core code that drives Edit Orders, and I won't pretend that I know how to fix some of the MANY THINGS that's wrong with it.. otherwise I woulda tried to address the KNOWN issues I have posted about. I'll take a look, but don't hold your breath hoping I'll know how to fix this..

Like I said, no big deal. :) I definitely won't hold my breath!

[DivaVocals]

Like I said, no big deal. :) I definitely won't hold my breath!

Please don't an anbulance on a Sunday drive will get there faster..

[GumboStandards]

Just so it's clear for others following this post I WILL NOT post a direct link to anything available on my site on this forum. (besides I think it's pretty clear anyway where to go once you are on my site) I will also be asking the admins to remove all the direct links you've posted as well.. Now.. Let me clarify WHY..

There is a REASON why I WILL NOT post a direct link to anything available on my site on this forum.. there is a reason why I direct people to the link in my signature.. (and no I don't know that all browsers don't display the signatures on this forum.. how would I know this??) It is AGAINST the rules to post links or support modules that are NOT available in the Zen Cart downloads.. I ONLY made this add-on available on my site because I am a tad BUSY right now with work and projects.. I need to finalize the readme file BEFORE I submit this to the Zen Cart downloads. However, I KNEW folks were looking for this update.. So I put it up on my site for those folks who can get away with the down and dirty install instructions in the readme and don't need the fully vetted/edited readme right now. Once I submit this to the free-downloads (and I WILL do this as soon as I finish the readme this week), it will no longer be available on my site..

Hope that helps clear things up..

Thank you, Diva! I was wondering why the convoluted procedure. I realized the mod hadn't been approved yet by "Zen Cart, Inc." but was unaware of the link rules, which is/was a bit baffling, but I am sure the reasoning behind it is sound. Namely, that I totally agree that once a mod is in Zen Cart's downloads area, no links to it existing outside should exist (or at least the mod should remove it from wherever) and managing the links to the "beta"/external version posted in the forum would be a nightmare. This also clears up why Edit Orders 2 is separate from Edit Orders 3 and why Edit Orders 4 will be separate from Edit Orders 3.

Thanks again for all that you do for Zen Cart. I've been running across other mods of yours that I may be putting into use in the future. Your readmes and installation procedures make things a step or three above many other mods out there.

[DivaVocals]

Thank you, Diva! I was wondering why the convoluted procedure. I realized the mod hadn't been approved yet by "Zen Cart, Inc." but was unaware of the link rules, which is/was a bit baffling, but I am sure the reasoning behind it is sound. Namely, that I totally agree that once a mod is in Zen Cart's downloads area, no links to it existing outside should exist (or at least the mod should remove it from wherever) and managing the links to the "beta"/external version posted in the forum would be a nightmare. This also clears up why Edit Orders 2 is separate from Edit Orders 3 and why Edit Orders 4 will be separate from Edit Orders 3

You're welcome.. Though I wouldn't call directing people to my site versus a direct link convoluted.. It's pretty clear when you get there how to get to the downloads, and the add-ons are all clearly named/labeled. Going forward, if I post an add-on on my site pre-submission I will continue to simply direct people to the link to my site in my signature. So far there's been no problems with folks finding things..

As for the rules... The reasons have been made very clear.. the Zen cart admins do not want to allow this forum to be used to support add-ons which are not available in the downloads section. (the rules for the forum are clearly posted) There seems to be a LITTLE wiggle room for "beta" or "pre-release" versions. So when it seems appropriate I will continue to post pre-submission add-ons on my site, but if the admins direct me to stop this, then trust me I am NOT going to get banned from this forum over ANY free download.

As for why the various Edit Orders versions are separated, the reason there is quite simple too (and I have posted these reasons before). They are separated because they are meant for different versions of Zen Cart, and SHOULD be seperated so it's CLEAR for folks when they download it that they are for different versions of Zen Cart. Hence the major version number change (versus a minor version number change) Edit Orders 2 was NEVER hosted on the Zen Cart site. struner (a LONG TIME maintainer of the add-on) was hosted it on his site for a very long time..

Thanks again for all that you do for Zen Cart. I've been running across other mods of yours that I may be putting into use in the future. Your readmes and installation procedures make things a step or three above many other mods out there.

I appreciate that.. Though honestly all I've done is tidied up some stuff and made better user docs.. the folks who've helped me with some of these updates truly deserve the REAL credit!!!

[DivaVocals]

I found someone who could help me sort out this issue. Here is the fix to make it show only the default language, which in my case was language ID 1. If your language ID is something else, change language_id=1 to language_id=YOUR_ID

in admin/edit_orders.php

REPLACE:

$result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM " . TABLE_PRODUCTS . " p LEFT JOIN " . TABLE_PRODUCTS_DESCRIPTION . " pd ON pd.products_id=p.products_id LEFT JOIN " . TABLE_PRODUCTS_TO_CATEGORIES . " ptc ON ptc.products_id=p.products_id LEFT JOIN " . TABLE_CATEGORIES_DESCRIPTION . " cd ON cd.categories_id=ptc.categories_id ORDER BY categories_name");

WITH:

$result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM zen_products p LEFT JOIN zen_products_description pd ON pd.products_id=p.products_id LEFT JOIN zen_products_to_categories ptc ON ptc.products_id=p.products_id LEFT JOIN zen_categories_description cd ON cd.categories_id=ptc.categories_id WHERE pd.language_id=1 ORDER BY categories_name");

THEN REPLACE:

$result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id'");

WITH:

$result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id' AND pov.language_id=1 AND po.language_id=1");

If the code above works (and I haven't tested it to know if it resolved the issues it was supposed to resolve) I believe that the code below is the better way of going about this.. I haven't tested this and I'll need someone to grade my homework and let me know if I got this right.. It should avoid anyone having to hard code in table names and language IDs. (which the posted code does and is not recommended) I've included the approximate line numbers to make finding things easier..

in YOUR_ADMIN_FOLDER/edit_orders.php

Around line 2267 find:

    // ############################################################################
    //   Get List of All Products
    // ############################################################################

        $result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM " . TABLE_PRODUCTS . " p LEFT JOIN " . TABLE_PRODUCTS_DESCRIPTION . " pd ON pd.products_id=p.products_id LEFT JOIN " . TABLE_PRODUCTS_TO_CATEGORIES . " ptc ON ptc.products_id=p.products_id LEFT JOIN " . TABLE_CATEGORIES_DESCRIPTION . " cd ON cd.categories_id=ptc.categories_id ORDER BY categories_name"); 

Replace with:

    // ############################################################################
    //   Get List of All Products
    // ############################################################################

        $result = $db -> Execute("SELECT products_name, p.products_id, categories_name, ptc.categories_id FROM " . TABLE_PRODUCTS . " p LEFT JOIN " . TABLE_PRODUCTS_DESCRIPTION . " pd ON pd.products_id=p.products_id LEFT JOIN " . TABLE_PRODUCTS_TO_CATEGORIES . " ptc ON ptc.products_id=p.products_id LEFT JOIN " . TABLE_CATEGORIES_DESCRIPTION . " cd ON cd.categories_id=ptc.categories_id where pd.language_id = '" . (int)$_SESSION['languages_id'] . "' ORDER BY categories_name"); 

Around line 2371 find:

            // Get Options for Products
            $result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id'"); 

Replace with:

            // Get Options for Products
            $result = $db -> Execute("SELECT * FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa LEFT JOIN " . TABLE_PRODUCTS_OPTIONS . " po ON po.products_options_id=pa.options_id LEFT JOIN " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov ON pov.products_options_values_id=pa.options_values_id WHERE products_id='$add_product_products_id' AND pov.language_id = '" . (int)$_SESSION['languages_id'] . "' AND po.language_id = '" . (int)$_SESSION['languages_id'] . "'");