Conditional shipping option?

[Ajeh]

The webservices module does not appear to have a version number. But I believe it is 1.3.2

The current FedEx from numinix's site is Version: 1.4.5 ... you should really consider upgrading to that ...

[split63]

What version of FedEx fedexwebservices are you running>

If you customize the fedexwebservices.php and add the code in RED:

        if (sizeof($methods) == 0) return false;
        $this->quotes['methods'] = $methods;
        if ($this->tax_class > 0) {

does it fix this issue?

Yes, it did fix the issue.
I will look into to updating the webservices modules

[Ajeh]

Thanks for the update that this worked for you ...

It was a good catch to run into this in FedEx as I see FedEx needs this extra code for the:

        if (sizeof($methods) == 0) return false;
        $this->quotes['methods'] = $methods;

as well as UPS ... it only happens when the configuration has settings that result in no quotes such as configuring the shipping module to only show for National or International shipping but not both or when the selected options all result in no quote ...

USPS already has this code in it in the July 28, 2013 J5 release so that one does not run into this issue ...

[split63]

Ajeh,

I had not noticed it, but the handling_fee which can be set in fedex webservices is no longer working. Not mater what value I set it to, it adds 0. There is likely an issue in your original suggested code modification. I have reposted it below.

Try this ...

Customize the file:
/includes/modules/shipping/fedexwebservices.php

with the code in RED:

              $methods[] = array('id' => str_replace('_', '', $rateReply->ServiceType),
                                 'title' => ucwords(strtolower(str_replace('_', ' ', $rateReply->ServiceType))) . $transitTime,
                                 'cost' => $cost + (strpos($this->types[$rateReply->ServiceType]['handling_fee'], '%') ? ($cost * (float)$this->types[$rateReply->ServiceType]['handling_fee'] / 100) : (float)$this->types[$rateReply->ServiceType]['handling_fee']));
$chk_cost = ($cost + (strpos($this->types[$rateReply->ServiceType]['handling_fee'], '%') ? ($cost * (float)$this->types[$rateReply->ServiceType]['handling_fee'] / 100) : (float)$this->types[$rateReply->ServiceType]['handling_fee']));
if ($_SESSION['usps_first_class'] == 0 || $chk_cost < $_SESSION['usps_first_class']) {
  $_SESSION['usps_first_class'] = $chk_cost;
}
//echo 'FedEx Cost Calc: ' . $chk_cost . ' $_SESSION[usps_first_class]: ' . $_SESSION['usps_first_class'] . '<br><br>';
// bof: check FedEx for > 40.00
            }
          }
        }
        $this->quotes['methods'] = $methods;

[Ajeh]

Could you Zip your files:
/includes/modules/shipping/fedexwebservices.php
/includes/modules/shipping/usps.php

and post them?

I am not seeing the conflict on the handling fee off the top of my head ...

[split63]

Ajeh,

Please see attachment

shipping.zip

[Ajeh]

I do not recognize this version of:
fedexwebservices.php

where and when did you get the original version of this?

[split63]

Hard to say. The files are not internally dated or versioned.
I do know that prior to the conditional shipping changes the handling charge was working.

There is a newer version of fedexwebservices, but I have not upgraded to it because the current version has worked fine. Plus I did not want to have to port the changes made to the current file to the new version. It seemed potentially like a lot of pain for no gain.

[Ajeh]

I really don't know how this ever worked ...

From the looks of this code, you only have one setting on the Handling Fee and not a number of them, correct?

If so, see what happens if you use this for the $methods[]:

             $methods[] = array('id' => str_replace('_', '', $rateReply->ServiceType),
                                 'title' => ucwords(strtolower(str_replace('_', ' ', $rateReply->ServiceType))) . $transitTime,
                                 'cost' => $cost + ( strpos(MODULE_SHIPPING_FEDEX_WEB_SERVICES_HANDLING_FEE, '%') ? ($cost * (float)MODULE_SHIPPING_FEDEX_WEB_SERVICES_HANDLING_FEE / 100) : (float)MODULE_SHIPPING_FEDEX_WEB_SERVICES_HANDLING_FEE) );

[Ajeh]

I am not sure how that change for USPS affected FedEx, but that fix for the FedEx is an educated guess as I really cannot run that code to test it ...