Edit Orders v4.0 Support Thread

[lhungil]

... adding a discount coupon on an order with taxes, the total is calculated incorrectly. Everything else works fine, with every scenario, except this. ...

Can you provide exact steps starting before the order exists all the way through to editing the order? This will better help me understand what you mean by "the total is calculated incorrectly" and where things may have gone wrong.

Have you applied any modifications to Zen Cart's handling of taxes such as "TaxCloud" or a "VAT module"?

Any debug logs (post inside code blocks - use the # in the editor)? Even if these appear unrelated they may be useful.

What are the sort orders for your order total modules? What are the settings for the coupon order total module (ot_coupon)? These are vital to help duplicate your store setup.

What are the settings for the specific coupon?

[ShopVille]

Hi TIA.
My store is using text attributes with multiple lines of text, when editing a order the attribute looses the line breaks and combines into one line without spaces, is there any fix for it to keep the formatting?

Perhaps this can help?
https://www.google.ca/search?safe=ac...j=1&gws_rd=ssl

[lhungil]

... Text Attributes multiple lines of text ...

As long as the attribute is configured correctly in Zen Cart (to allow multiple lines), these work in both Zen Cart and Edit Orders...

If you are experiencing issues, please post related details including attribute settings (option names, values, product attribute, debug logs, modifications to attribute handling, etc).

[delia]

Has anyone ever run into an order that wouldn't update? This is in a 1.3.9h cart where editing orders has not been a problem. This one very large order is now missing the name and address info after attempting to update. After hitting the update button, the url remains the same but the screen refreshes and shows the home page of the site. The quantities do not update. There has to be over 50 line items with a few attributes.

The order was entered in with logon as customer which also hasn't been an issue before. Site has been up and working since 2012 with no issues.

I've been trying to get them to upgrade so in the end that's what we'll probably have to do and hope the problem goes away. Just wondering if anyone had had this happen to them.

[DivaVocals]

I personally remember far more issues when using the older versions of Edit Orders (3.x and 4.0). It regularly produced tax errors, corrupted data (or data formats) in the various order related tables, failed to validate inputted data, did not use the order total modules to process the order totals, etc. The old versions also did not provide the best user experience for an administrative user. For example: no dropdowns to use when selecting order total modules, no way to search when adding a product, did not automatically apply coupons or low order fees, and did not attempt to detect / notify / correct various error conditions.

**nods in agreement** as the person who took on maintaining the older versions of Edit Orders when the original developer stepped away, there was a "known issues" thread I posted which listed all of these issues. Thank GOODNESS you came along and took this dog with fleas off my hands and gave her a MUCH NEEDED flea bath!! The difference has been night and day, and those of use who rely on this module have been grateful. As you stated, this module works on 99% of the stores out there with NO ISSUES what so ever!! So kudos to you.. and a donation from my client who uses and can't live without this module is coming before the end of the year!! (yeah I did browbeat him in a GOOD way into it!! he wanted me to pass on his gratitude to you!!)

[carlwhat]

Hello Everyone!
Great mode, but I'm having an issue I seem not to find the answer for.
Clean ZC 1.5.1 install, with Super Orders and Edit Orders 4.1.4, + other modules.

In edit orders, adding a discount coupon on an order without taxes, the total is calculated correctly.
However, adding a discount coupon on an order with taxes, the total is calculated incorrectly. Everything else works fine, with every scenario, except this.
Has anyone encountered this before? Can someone point me in the right direction to figure this one out?
Thanks a bunch for the help!

i have found many issues with regards to this module. and it is very sensitive to the order in which someone edits an order. i have found entering a discount code only AFTER having completed all item entry/modification to be the only way to get it to work.

as previously stated by lhungil (i think), one needs to hit update twice when processing an order with discounts and taxes.

as mvstudio (and i) ran into a problem with regards to the correct calculation of orders with discounts and taxes, the problem starts with the 3rd (and future) times one hits enter. then the totals all go off...

i have tracked down this problem (at least as it relates to me) to the function eo_update_database_order_totals and specifically when it updates the ot_coupon. the ot_coupon will continue to subtract the taxable amount of the discount even if it has already done it before.

i was able to resolve this problem by the following "hack" in the ot_coupon module. i changed this code:

if (DISPLAY_PRICE_WITH_TAX != 'true') {
$order->info['total'] -= $tax;
}

to:

if (DISPLAY_PRICE_WITH_TAX != 'true') {
// fix for admin side of edit orders
if (!isset($_SESSION['coupon_amount']) && (IS_ADMIN_FLAG == false)) {
$order->info['total'] -= $tax;
$_SESSION['coupon_amount'] = $od_amount['total'];
}
}

the IS_ADMIN_FLAG is necessary so that orders entered by customers are not affected. and the variable is $_SESSION['coupon_amount'] is really just a flag here, as opposed to needing that amount down the line.

hope that helps someone. no guarantees or implied warranties or anything else....

[lhungil]

... This is in a 1.3.9h cart where editing orders has not been a problem. ...

Edit Orders 4.x is not intended for use under Zen Cart 1.3.x, so would not be surprised if problems occurred. This goes doubly for Edit orders 4.1+ as it contains some functions from Zen Cart 1.5.x and directly utilizes the Zen Cart 1.5.x classes and functions to display, edit, and update the order.

Perhaps the site is using one of the older versions for Zen Cart 1.3.x such as Edit Orders 3.x (no longer actively maintained or supported)?

... I've been trying to get them to upgrade so in the end that's what we'll probably have to do and hope the problem goes away. ...

Sounds like a good plan. Keep us up to date!

... Has anyone ever run into an order that wouldn't update? ... Just wondering if anyone had had this happen to them.

I ran into similar issues on occasion in the older versions of Edit Orders. With Edit Orders 4.1.x (under Zen Cart 1.5.x), I have rarely seen the same behavior reported.

The most common causes under Zen Cart 1.5.x with Edit Orders 4.1.x are one or more of the following:

• Third party order total modules (crashing when loaded from the Zen Cart admin)
• Core file merges not applied correctly
• Corrupt or missing database records
• Known bugfixes not applied to the latest version

Usually a quick look at the Zen Cart debug logs will provide a nudge in the right direction.

[lat9]

Running EO 4.1.4 on ZC 1.5.1. The ot_onetime_discount module is enabled with sort-order 260 and ot_tax is enabled with sort-order 300. When a 1-time discount is applied to an order, the tax is not recalculated.

Any ideas? I thought I'd post here before I head off to see what's up in the code.

[lhungil]

Running EO 4.1.4 on ZC 1.5.1. The ot_onetime_discount module is enabled with sort-order 260 and ot_tax is enabled with sort-order 300. When a 1-time discount is applied to an order, the tax is not recalculated. ...

Strange since tax processing is not done directly by Edit Orders (handed off to Order Total classes).

Is VAT involved (I remember discussions in the past related to VAT, but was not able to duplicate in a stock Zen Cart or get enough info on modifications to test)?

Have you tried pressing the "update" button a second time (to retrigger calculation by the order total modules)? Anything jumping out when enabling debug "order totals"?

[lat9]

No VAT, just regular US taxes. I also tried the double-update trick ... no go.

Update: Unlike the coupon processing (where tax can optionally be recalculated), there are no tax-related calculations perofmred by the 1-time discount.