Stock by Attribute v4.0 addon for v1.3.5-1.3.9

[mc12345678]

Now I believe I know why the conversation is now here...

Anyway, with all the fixes and merges that have been done on Github, an old man like me gets confused... or maybe I'm just dense (my wife added that)... But, where can I get the absolute latest functional version for 1.5.1 please?

Mal

https://github.com/potteryhouse/stoc...tribute_1.5.3/

is the version that supports ZC 1.5.1

All the files have been brought to a single branch with a branch stub available to test/publish other changes before incorporating into the master branch.

[mc12345678]

Sent you a PM with links to my site. The original item (with 2 attributes) works as expected, but now a new item I made with only 1 attribute is now displaying "out of stock" next to all the attributes in the dropdown. If I add a 2nd attribute to that very item then the "out of stock" messages go away. Is this a "bug" or is there somewhere else to turn off out of stock messages on single attribute items?

Understand, so yes there is a difference in how single and multiple attributes are handled. Currently single attributes are handled through 1) the setting in Dynamic Dropdowns configuration as to whether to be active for single, multiple or all attributes. The Dynamic Dropdown code provided in the SBA module does not fully work with the current JavaScript and the previous sequenced dropdown code has been updated/modified to function and provide options that are similar to what was created by potteryhouse/jeking for single attributes. There remains a few things to be incorporated and wrinkles to iron out.

So, when addressing issues with this, like before, details are needed to understand the setup and identify the potential issues first before a deep code review.

It was my understanding (as I have tried to minimize touching the results of what potteryhouse and jeking were expecting, that the display of out-of-stock for single attribute dropdowns was optional and controlled in the configuration menu. I will say, that if the expectation is that no product is to display out-of-stock, then the text could be removed from the define keeping the constant on the left, and have the single quotes on the right be empty. That's a cheat way and doesn't fix the central problem, but would work in the interim until the source of the issue is found.

Unfortunately and as somewhat pointed out by malaperth, there have been a number of changes, merges, pushes, etc... that it may be difficult to determine the difference(s) that may be present possibly contributing to this. Sorry for also being a bit of a pain, but could you identify the SBA version and ZC version associated to try to validate the issue, and on what date SBA was downloaded? (Thinking that may be the best way to determine if the issue has since been resolved by other updates.)

[tronage]

Sorry for also being a bit of a pain, but could you identify the SBA version and ZC version associated to try to validate the issue, and on what date SBA was downloaded? (Thinking that may be the best way to determine if the issue has since been resolved by other updates.)

No pain at all and I'm very appreciative of the time and effort that you have taken to respond. It is quite refreshing! I'm using the SBA 1.5.4-master that I downloaded on 6/1/15. from the link I posted in my previous post. And I'm currently running Zen 1.5.4 And prior to installing I checked the overwrite files, and none of them needed a merge (in other words the handful of add-ons I've installed did not make any changes to the overwrite files in the SBA package).

I also figured out "something" that may either help in tracking it down, or it at least fixes my functionality... previously to get rid of the pop-up issue I set "Enable Dynamic Dropdowns" to off, and that killed the popup from popping (yay), so based on what you said about the different handling I figured maybe turning on the dynamic for single attributes would do "something", so setting this to "On for single attribute only". Now my multi-attributes still don't pop and don't show out of stock (yay) and my single attribute also does not display out of stock (double yay).

So I'm not sure if that is a work around, or a help in finding a bug, or a working as intended, but (at least for now) it seems to function as I would like it to.
Thanks!

[mc12345678]

No pain at all and I'm very appreciative of the time and effort that you have taken to respond. It is quite refreshing! I'm using the SBA 1.5.4-master that I downloaded on 6/1/15. from the link I posted in my previous post. And I'm currently running Zen 1.5.4 And prior to installing I checked the overwrite files, and none of them needed a merge (in other words the handful of add-ons I've installed did not make any changes to the overwrite files in the SBA package).

I also figured out "something" that may either help in tracking it down, or it at least fixes my functionality... previously to get rid of the pop-up issue I set "Enable Dynamic Dropdowns" to off, and that killed the popup from popping (yay), so based on what you said about the different handling I figured maybe turning on the dynamic for single attributes would do "something", so setting this to "On for single attribute only". Now my multi-attributes still don't pop and don't show out of stock (yay) and my single attribute also does not display out of stock (double yay).

So I'm not sure if that is a work around, or a help in finding a bug, or a working as intended, but (at least for now) it seems to function as I would like it to.
Thanks!

So, if it is worth anything, I need to verify the version uploaded to the version I just tested, but I also don't recall changing anything about Dynamic Dropdowns recently, but with the following settings I was able to continue using Dynamic Dropdowns and control the notification of the out-of-stock statement. (Mind you, out-of-stock could be changed to something like on-back order, or other terminology.)

Enable Dynamic Dropdowns	2
Product Info Single Attribute Display Plugin	multiple_dropdowns
Show Out of Stock Attributes	True
Product Info Multiple Attribute Display Plugin	sba_sequenced_dropdowns
Mark Out of Stock Attributes	Right
Display Out of Stock Message Line	False
Prevent Adding Out of Stock to Cart	True
SBA Number of Records to Displayed	25

The first setting identifies that DD is to only apply on multiple attribute products.
The Show Out of Stock attributes part allows display of attributes that would be well considered out-of-stock.
The Mark Out of Stock Attributes adds the text that is normally Out Of Stock to the left, right, or not at all in the drop down window.
The Display Out of Stock Message Line couples the javascript popup and the text that appears after acknowledging the out-of-stock popup so that if set to True, then will get the popup, if set to false, then will not.
The "Prevent Adding Out of Stock to Cart" option appears to only control notification that a product is out-of-stock upon trying to add the product to the cart; however, does not yet prevent/cancel adding the product to the cart.

Just some testing that was performed to investigate this as well as another issue....

[tronage]

Going off of what you are saying, I did some experimenting. I turned the dynamic dropdowns to 1 (so it is on for both single and multi). Here is how I have my dynamic Drop downs set:
Enable Dynamic Dropdowns 1
Product Info Single Attribute Display Plugin single_dropdown
Show Out of Stock Attributes True
Product Info Multiple Attribute Display Plugin sba_sequenced_dropdowns
Mark Out of Stock Attributes None
Display Out of Stock Message Line False
Prevent Adding Out of Stock to Cart False
SBA Number of Records to Displayed 25

For my experiment, I only made changes to "Product Info Multiple Attribute Display Plugin". Here are the results for a product with 2 attributes (color and size):
single_radioset - works as expected
single_dropdown - works as expected (What I'll probably start using since I like dynamic and this one currently works)
multiple_dropdowns - Broken - displays the first attribute for BOTH dropdowns (ex: Color: and then below that Color: again when the 2nd should be Size)
sequenced_dropdowns - Broken - Color and Size dropdowns are "empty" clicking them just shows "First Select Color" with no options, and "next select size" with no options. (Even though I do have "Show Out of Stock Attributes" set to True)
sba_sequenced_dropdowns - Broken - Even through I have "display out of stock message line" set to false (which you said should stop the javascript pop up) I STILL get the pop-up message when I make a selection, and after I dismiss the pop-up text appears below the dropdowns with a similar out of stock message.

With dynamic turned OFF multi-attribute - works as expected, and no out of stock messages. Single-attribute starts showing a rogue out of stock line...

So I wanted to compare what the out of stock message looks like when it SHOULD show (Dynamic on, mark on right) to the message that shouldn't show (with dynamic off) Something interesting I found:
With Dynamic drop downs on, and "mark out of stock Attributes" set to "right" on my single attribute items I get:
"Red - Out of stock"
BUT if I set dynamic drop downs to 0 (off) and not change anything else I get:
"Red Out of Stock"

The difference is the lack of a "-" and a capitol "S" in stock. This might help aid it tracking things down since the two phrases being displayed are different I'm thinking... I'm no programmer, but I can help search:

from the source download, I'm seeing the lowercase "s" version here:
\includes\languages\dutch\extra_definitions\dynamic_dropdowns_sba.php(2): define('TEXT_OUT_OF_STOCK', 'Out of stock');
\includes\languages\english\extra_definitions\dynamic_dropdowns_sba.php(2): define('TEXT_OUT_OF_STOCK', 'Out of stock');
\includes\languages\french\extra_definitions\dynamic_dropdowns_sba.php(2): define('TEXT_OUT_OF_STOCK', 'Out of stock');

And I'm seeing the upper case "S" version here:
\admin\stock_by_attr_install.php(673): ('Show Out of Stock Attributes', 'PRODINFO_ATTRIBUTE_SHOW_OUT_OF_STOCK', 'True', 'Controls the display of out of stock attributes.', :configuration_id:, 10, now(), NULL, 'zen_cfg_select_option(array(\'True\', \'False\'),'),
\admin\stock_by_attr_install.php(674): ('Mark Out of Stock Attributes', 'PRODINFO_ATTRIBUTE_MARK_OUT_OF_STOCK', 'Right', 'Controls how out of stock attributes are marked as out of stock.', :configuration_id:, 30, now(), NULL, 'zen_cfg_select_option(array(\'None\', \'Right\', \'Left\'),'),
\admin\stock_by_attr_install.php(675): ('Display Out of Stock Message Line', 'PRODINFO_ATTRIBUTE_OUT_OF_STOCK_MSGLINE', 'True', 'Controls the display of a message line indicating an out of stock attributes is selected.', :configuration_id:, 40, now(), NULL, 'zen_cfg_select_option(array(\'True\', \'False\'),'),
\admin\stock_by_attr_install.php(676): ('Prevent Adding Out of Stock to Cart', 'PRODINFO_ATTRIBUTE_NO_ADD_OUT_OF_STOCK', 'True', 'Prevents adding an out of stock attribute combination to the cart.', :configuration_id:, 50, now(), NULL, 'zen_cfg_select_option(array(\'True\', \'False\'),'),
\includes\classes\pad_sba_sequenced_dropdowns.php(253): $out.=" alert('All selections of the attributes below this one are Out of Stock. Please select a different option.');\n";
\includes\languages\dutch\extra_definitions\products_with_attributes.php(13): define('PWA_OUT_OF_STOCK', ' Out of Stock: ');
\includes\languages\english\extra_definitions\products_with_attributes.php(13): define('PWA_OUT_OF_STOCK', ' Out of Stock: ');
\includes\languages\french\extra_definitions\products_with_attributes.php(13): define('PWA_OUT_OF_STOCK', ' Out of Stock: ');

Again I'm not a programmer, but if I ended up wanting to change the text to maybe "Special order item" or something like that I would just change the define text in one of the files above (I guess the dynamic php if I'm using dynamic and pwa php if I'm not?)?

Let me know if any of this helps.

[mc12345678]

Looked over the recent discussion on the topic and didn't see the following addressed. (If I missed it, my apologies) how are the multiple attribute combinations generated? Are they a series of single attributes with one attribute each with a quantity or as a combination of attributes with a quantity associated with each combination?

What other plugins are installed as with a fresh install of ZC and SBA, those issues have yet to be encountered. FYI, the other types of DD display have not been modified from the version available for download from the plugins section. This allows users to continue with whatever rewritten version(s) they may have as developed by others.

[mc12345678]

The other question related to this is what type of dropdown is used? Using the default ZC dropdown or the SBA dropdown?

[tronage]

The other question related to this is what type of dropdown is used? Using the default ZC dropdown or the SBA dropdown?

The dropdown type I'm using for the options are SBA Select List (dropdown) basic
As I said earlier I only have a handful of addons, none of which I think would be relevant (they are usps, ups and paypal). And prior to install none of the overwrites had any thing to be merged. As for your last question, I'm not sure I follow, but I will tell you my process of adding an item:
1) create the item
2) assign the attributes using the attribute controller
3) use the products with attributes stock (aka SBA) to find the item I created,
4) click the "add quantity for product variant"
5) then if there is just a few, I'll pick the drop down combination, enter my custom id and quantiy. If there is a bunch, I'll hit the all attributes combo option, setting quantity to zero. Then on the page that spits out, I'll go in and just add the custom id's to the fields. The item I've used for testing was entered via manualy selecting the dropdowns and entering the custom id and quantity.

[mc12345678]

The dropdown type I'm using for the options are SBA Select List (dropdown) basic
As I said earlier I only have a handful of addons, none of which I think would be relevant (they are usps, ups and paypal). And prior to install none of the overwrites had any thing to be merged. As for your last question, I'm not sure I follow, but I will tell you my process of adding an item:
1) create the item
2) assign the attributes using the attribute controller
3) use the products with attributes stock (aka SBA) to find the item I created,
4) click the "add quantity for product variant"
5) then if there is just a few, I'll pick the drop down combination, enter my custom id and quantiy. If there is a bunch, I'll hit the all attributes combo option, setting quantity to zero. Then on the page that spits out, I'll go in and just add the custom id's to the fields. The item I've used for testing was entered via manualy selecting the dropdowns and entering the custom id and quantity.

So I haven't attempted to duplicate the scenario specifically to see if this is the case, but below should be two images showing the two different scenarios to which I speak. They are created by different means on the front end in the admin. The first is as described many attributes each with their own stock. The second is many attributes combined as individual variant "products" each combination of attributes having a single quantity of availability.

Indiv_multi.jpg


Combo_multi.jpg

Then with regards to:

5) then if there is just a few, I'll pick the drop down combination, enter my custom id and quantiy. If there is a bunch, I'll hit the all attributes combo option, setting quantity to zero. Then on the page that spits out, I'll go in and just add the custom id's to the fields. The item I've used for testing was entered via manualy selecting the dropdowns and entering the custom id and quantity.

Could you elaborate on just a few what?
Just a few option names such as color, size, brand? or just a few option values under each option name? Such as perhaps two colors, two sizes, 1 brand, then would manually select each of the four combinations possible?

Asking for a couple of reasons, one is to identify the current system response by the choice of options (and associated changes necessary) and to figure out why with no plugins that directly affect this one why the results are so significantly different. I'll double check the files that are uploaded as compared to those that are satisfactorily working otherwise both locally and by others thus far...

[tronage]

I forgot I'm also using WinchesterBlack template... don't know if that counts as an "add-on" since I wouldn't think it messes with function, more just layout and color. And, I think I kinda get it (I apologize). I've been using the terms single and multi to reference how many attributes. So when I've been saying single, I am referring to the single-multi you show (one item, that has just one attribute, populated by say color, so item widgets, comes in red, green, and blue. zero stock in each. This is the scenario that when I turn off the dynamic, shows the odd out of stock message.

When I have been saying multi, I'm referring to multi-attributes, so this would be like your combo-multi, meaning widgets come in red, green, blue, and small, med, large. Therefore there is a matrix formed for 9 options, each with their own id and stock. These are the ones that seem to all be "broken" in some way when using any type of dynamic other then the single drop or the radio button (the first 2 options). the rest all have quirks as I described in my previous message.

To answer your question regarding "by just a few", I mean, lets say I have widgets in red green and blue. So in the "products with attributes stock (aka SMB)" page I would find my item, click add quantity for product, and then being there is only 1 drop down, with 3 options (total 3 variants) I would select a atribute, fill in the id and quantity and hit submit for each. But now if I had a 2nd item Widgets with Colors red, orange, yellow, green, blue, and purple. And sizes xs, s, m, l, XL, 2XL, that would yield 36 combinations, so rather then doing each one individually (since I already know the stock for all is zero) I would pick "all-attributes-combo" for both color and size, leave description and id blank, and fill in quantity as zero, and hit submit. I would then be presented with a matrix of all 36 possible options, to which I would just click on the ID spot for each one and fill in the IDs for them.

Now I can tell you regardless if an item had one attribute or two (I don't think I have any items with three), all items I entered when I originally posted were all entered by manually selecting from the drop-downs for each item or item combo. It wasn't until maybe yesterday I figured out my way to speed up the process by using the all-attributes-combo, and I have to say since I know all my stock is currently zero, I've been lazy and using it on pretty much all my items (even if it is just one attribute with two choices). I find it much easier to fill in item ids into a matrix (reminds me of using excel), then manually doing each on a form and clicking submit.

I hope that at least gives you the information you need. And I hope I answered your questions sufficiently.