[Closed] FEEDBACK ON BETA of v1.5.5

[mc12345678]

If you're complaining that one must fill in the settings in order to see the normal home page, then yes, that is intentional ... so that you do fill in that info.
If you're asking for a way to "let someone else, like the storeowner, fill that in later", then you can simply go into the Configuration->My Store area and blank out the store name or the store owner ... and the wizard will then automatically display again on the home page, prompting for setup.

Would say complain is a strong word in this regards... Had an initial observation and considered the various impacts. It really is great to see such functionality added to the store side versus the install side. And now a developers workaround has been identified: temporarily fill in information if it is needed to see past the "registration" screen and clear some of that info when ready to get the store owner on board. Nice...

[lat9]

Yes. All the more incentive for them to convert their db to utf8 ;)

Wouldn't it be nicer to simply use the HTML entities for those characters in the upgrade script (e.g. Réunion instead of Réunion) rather than making the future update to UTF8 more difficult?

[DrByte]

While a minor impact, it does also mean that other templates to be used with this version of ZC may need some minor tweaking to account for that change.

I would say, if anything that perhaps documentation of the template "flag" change would help other perspective template developers. I know, get too detailed and will miss something, too broad and the masses are unhappy. :)

Fair. Those id/classes were never mentioned in the default/supplied css files.

[DrByte]

Okay.. Sorta tough to read through the documentation when there doesn't appear to be any?

the install.txt file in the root says (areas related to the documentation highlighted in red):

When using the github "download the zip" button, a number of dev-only things are excluded, including the /docs/ folder.
You can access the docs folder directly in github (to get latest updates in real time), or at www.zen-cart.com/docs (which will be updated when v155 is fully released)

[DrByte]

includes/classes/order.php
generation of a database table id is not collected for potential use before initiating a notify action. lines 888-890.

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', $sql_data_array);

The $sql_data_array is added to the table Orders Products Attributes, but the position of that addition is not immediately captured and could be lost in the initiation of the notify.

Earlier in the code a similar addition is performed at lines 802-804:

      zen_db_perform(TABLE_ORDERS_PRODUCTS, $sql_data_array);

      $order_products_id = $db->Insert_ID();

      $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_PRODUCT_LINE_ITEM', array_merge(array('orders_products_id' => $order_products_id), $sql_data_array));

suggest the same type of designation and assignment:

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $order_products_attributes_id = $db->Insert_ID();

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', array_merge(array('orders_products_attributes_id' => $order_products_attributes_id), $sql_data_array));

It would seem that though the additional assignment would not be necessary for discovery of the same information in the table (ie. the database table can be searched for successful addition of the $sql_data_array), it is inconsistent with the guidelines and suggestions of the forum for design by NOT collecting the insertion id before performing an action against the $db variable/the database table before collecting that new number and is inconsistent with code a few lines back...

FWIW, this was also posted previously as a code suggestion.

https://github.com/zencart/zencart/pull/692/files

[mc12345678]

When using the github "download the zip" button, a number of dev-only things are excluded, including the /docs/ folder.
You can access the docs folder directly in github (to get latest updates in real time), or at www.zen-cart.com/docs (which will be updated when v155 is fully released)

Super! (On the availability of the docs in github as I didn't go back to see if they were there o not after that minor discovery.) Certainly would like to at least leaf through them to see if there are any obvious issues. And really look forward to the updated docs online at least those similar to: http://www.zen-cart.com/docs/phpdoc-1-5-0/

Otherwise I can continue to search through the github version of ZC when I'm away from a computer.

[DrByte]

So far during install have also noticed that there is nothing indicating what version this install is to provide...

Done .

[Ajeh]

Wouldn't it be nicer to simply use the HTML entities for those characters in the upgrade script (e.g. Réunion instead of Réunion) rather than making the future update to UTF8 more difficult?

That would be a bad plan ... try adding it to the end of United States on countries and make an order ...

Notice the terrible mess on TEXT emails and the Account History page that it makes ...

[DrByte]

Came back to revisit this after installing the software, but in tpl_modules_attributes, there is a check/variable called $options_html_id on line 30 that does not appear to be defined in includes/modules/attributes.php nor anywhere else in the code...

Anyone have any ideas why it is there? Won't there be a problem identified that referencing an array that is never created, nor assigned? Maybe not so much an issue with recalling data that hasn't been assigned, but still seems like it could end up being random.

Fixed the missing $options_html_id stuff.
https://github.com/zencart/zencart/c...9f8835a1aa32da

Its purpose is to allow for javascript targeting of specific CSS IDs on the page, to allow dynamic update stuff.

[DrByte]

Developer's tool kit: search of information in an observer using the look-up classes or things in classes files does not provide results... Example, vanilla install, search in look-up classes or things in classes on: products_viewed_counter extends

No results, place the same search criteria in the Look-up in all files entry and the default observer is searched.



DTK: Not sure what's going on, but I expected different results: using the template search (wanted to see if template override files in the modules directory would be searched since not in the dropdown list for that selection). Entered the following search:

params' => 'class="productListing-hea

Fixed:
- observers folder is now searched
- the overrides for modules and sidebox templates are now searched
- previous search terms are repopulated (into the same search that was last used)