User tracking mod

[mc12345678]

@jaydamuss,

Please accept my apologies as I was able to identify an error with the install code once I was on someone else's system and they had the same issue occur. Certainly there were some other factors at play, but I was able to identify the one minor issue that caused the database not to get updated with the version number (causing the process to repeat) and as a result of that error occurring there was another "catch all" that had to get more code, so.. I have uploaded an updated version of User Tracking that incorporates the other changes that I was working on basically that the data displayed is collected in a series of tables prior to being displayed. The thought was that this would maybe make transition to ZC 1.6.0 "easier". Not yet sure about that, but it was a path down which I had started and wanted to finish.

Anyways, also completed the transition of links to $_POST buttons instead of "links" (underline style). Here is the list of changes applied to the update:

Updated 06/10/2017 Version 1.5.4 mc12345678:
1. Revised the installer to restore the expected operation. Bug had been introduced that prevented recognition of full installation.
2. Incorporated an additional check/correction to support reperformance of the installation if an error was introduced during installation,
helping to move forward from the above problem.
3. Generalized the installer further to not depend on the file extension taking only 4 characters in length.
4. Added install file to recognize this version.
5. Updated the geodata to the 8 June 2017 version.
6. Cleaned up code a little by removing closing php statements.
7. Prevent the install auto_loader from activating from the catalog side.
8. Rename class constructors to be PHP 7.0 compliant.
9. Modified the display of the User Tracking information
to use the generic admin table type class/object.
10. The idea is/was that it may make transition to ZC 1.6.0
easier, though could also be undone as necessary.
11. Further completed the transition of GET links to POST buttons.
12. Incorporated the type conversion issue identified
by davewest at: https://www.zen-cart.com/showthread....racking+mktime
13. Generally adjusted the lines of the main page to use
spaces instead of tabs, aligned code to support improved
readability.
14. Incorporated associated language file modifications,
even if the language is/was not translated yet.

And I finally got my local User Tracking git files pushed to my github so that in the future it would be easier to discuss the code and not have to download it to a local computer just to look at it.

So, for the installer, to quickly get that to be quiet and correct.
See the changes made/shown for the admin/includes/init_includes/init_user_tracking.php file found at this github path:
https://github.com/mc12345678/User_T...ec9cc9bb045087

[jaydamuss]

@jaydamuss,

Please accept my apologies as I was able to identify an error with the install code once I was on someone else's system and they had the same issue occur. Certainly there were some other factors at play, but I was able to identify the one minor issue that caused the database not to get updated with the version number (causing the process to repeat) and as a result of that error occurring there was another "catch all" that had to get more code, so.. I have uploaded an updated version of User Tracking that incorporates the other changes that I was working on basically that the data displayed is collected in a series of tables prior to being displayed. The thought was that this would maybe make transition to ZC 1.6.0 "easier". Not yet sure about that, but it was a path down which I had started and wanted to finish.

Anyways, also completed the transition of links to $_POST buttons instead of "links" (underline style). Here is the list of changes applied to the update:


And I finally got my local User Tracking git files pushed to my github so that in the future it would be easier to discuss the code and not have to download it to a local computer just to look at it.

So, for the installer, to quickly get that to be quiet and correct.
See the changes made/shown for the admin/includes/init_includes/init_user_tracking.php file found at this github path:
https://github.com/mc12345678/User_T...ec9cc9bb045087

i thank you soo much, the messages have gone and now works perfect :)
cheers

[mc12345678]

i thank you soo much, the messages have gone and now works perfect :)
cheers

No, yet again, thank you for reporting the issue. As said, hadn't occurred on my side, so wouldn't have known to do anything without the report. :)

As an aside, I'm going back through the installer as used on other plugins and making some notes as although there were a few things to improve, some of the rewrites to try to resolve this issue were unnecessary and just complicated things.

[tonyreynolds]

I am running 1.5.4 and installed the User-tracking-V.1.5.4. I made the file changes as suggested and installed all files as indicated. I get an error. I followed all troubleshooting tips including a complete uninstall and re-install and get the same errors:

[13-Jun-2017 12:53:01 America/New_York] PHP Warning: file_get_contents(): http:// wrapper is disabled in the server configuration by allow_url_fopen=0 in /hermes/bosnaweb07a/b261/ipg.garsquaredcom/obiecue/includes/functions/plugin_support.php on line 38
[13-Jun-2017 12:53:01 America/New_York] PHP Warning: file_get_contents(http://www.zen-cart.com/downloads.ph...heck&id=1744): failed to open stream: no suitable wrapper could be found in /hermes/bosnaweb07a/b261/ipg.garsquaredcom/obiecue/includes/functions/plugin_support.php on line 38
[13-Jun-2017 12:53:01 America/New_York] PHP Warning: in_array() expects parameter 2 to be array, null given in /hermes/bosnaweb07a/b261/ipg.garsquaredcom/obiecue/includes/functions/plugin_support.php on line 42

Any suggestions?

Tony

[mc12345678]

Yeah, that's because of the version checking that is in the install file (admin/includes/init_includes/init_user_tracking.php) and how it is implemented on ZC 1.5.4, though it is interesting that it is happening with the plugin and not with the routine operation of the admin (unless something is being done to bypass the main screen where the issue is likely to appear)... Anyways, you could/should be able to do any of the following, though the first action probably will have to relate to a file modification.

Could remove the admin/includes/auto_loaders/config.user_tracking_install.php file, and then could modify ad
min/includes/init_includes/init_user_tracking.php

Towards the end of the file, modify:

// Version Checking 
if ($zencart_com_plugin_id != 0 && SHOW_VERSION_UPDATE_IN_HEADER && (!defined($module_constant . '_PLUGIN_CHECK') || constant($module_constant . '_PLUGIN_CHECK'))) {
    $new_version_details = plugin_version_check_for_updates($zencart_com_plugin_id, $current_version);
    if ($_GET['gID'] == $configuration_group_id && $new_version_details != FALSE) {
        $messageStack->add("Version ".$new_version_details['latest_plugin_version']." of " . $new_version_details['title'] . ' is available at <a href="' . $new_version_details['link'] . '" target="_blank">[Details]</a>', 'caution');
    }
}

to either add the below red text:

// Version Checking 
if (false && $zencart_com_plugin_id != 0 && SHOW_VERSION_UPDATE_IN_HEADER && (!defined($module_constant . '_PLUGIN_CHECK') || constant($module_constant . '_PLUGIN_CHECK'))) {
    $new_version_details = plugin_version_check_for_updates($zencart_com_plugin_id, $current_version);
    if ($_GET['gID'] == $configuration_group_id && $new_version_details != FALSE) {
        $messageStack->add("Version ".$new_version_details['latest_plugin_version']." of " . $new_version_details['title'] . ' is available at <a href="' . $new_version_details['link'] . '" target="_blank">[Details]</a>', 'caution');
    }
}

Or remove that entire block of code.

Ideally, the includes/functions/plugin_support.php file would get updated to the recently available copy from ZC 1.5.5: https://github.com/zencart/zencart/b...in_support.php (or perhaps that from 1.6.0 might be further improved?)

Technically though if SHOW_VERSION_UPDATE_IN_HEADER is set to false, then this shouldn't have been an issue... I'll also look at changing the criteria for performing the check, but ideally, there shouldn't be an issue with the check being attempted... Right? :)

[tonyreynolds]

I made these changes:
edited the init_user_tracking.php as suggested. Removed the config.user_tracking_install.php file and dropped in the plugin_support.php file from git hub. Those errors are gone.
Now I get this error:

PHP Parse error: syntax error, unexpected '<' in /hermes/bosnaweb07a/b261/ipg.garsquaredcom/obiecue/BBQadmin/user_tracking.php on line 390


I removed the line since it was commented out and the plugin is working.

Thanks,
Tony

Yeah, that's because of the version checking that is in the install file (admin/includes/init_includes/init_user_tracking.php) and how it is implemented on ZC 1.5.4, though it is interesting that it is happening with the plugin and not with the routine operation of the admin (unless something is being done to bypass the main screen where the issue is likely to appear)... Anyways, you could/should be able to do any of the following, though the first action probably will have to relate to a file modification.

Could remove the admin/includes/auto_loaders/config.user_tracking_install.php file, and then could modify ad
min/includes/init_includes/init_user_tracking.php

Towards the end of the file, modify:

// Version Checking 
if ($zencart_com_plugin_id != 0 && SHOW_VERSION_UPDATE_IN_HEADER && (!defined($module_constant . '_PLUGIN_CHECK') || constant($module_constant . '_PLUGIN_CHECK'))) {
    $new_version_details = plugin_version_check_for_updates($zencart_com_plugin_id, $current_version);
    if ($_GET['gID'] == $configuration_group_id && $new_version_details != FALSE) {
        $messageStack->add("Version ".$new_version_details['latest_plugin_version']." of " . $new_version_details['title'] . ' is available at <a href="' . $new_version_details['link'] . '" target="_blank">[Details]</a>', 'caution');
    }
}

to either add the below red text:

// Version Checking 
if (false && $zencart_com_plugin_id != 0 && SHOW_VERSION_UPDATE_IN_HEADER && (!defined($module_constant . '_PLUGIN_CHECK') || constant($module_constant . '_PLUGIN_CHECK'))) {
    $new_version_details = plugin_version_check_for_updates($zencart_com_plugin_id, $current_version);
    if ($_GET['gID'] == $configuration_group_id && $new_version_details != FALSE) {
        $messageStack->add("Version ".$new_version_details['latest_plugin_version']." of " . $new_version_details['title'] . ' is available at <a href="' . $new_version_details['link'] . '" target="_blank">[Details]</a>', 'caution');
    }
}

Or remove that entire block of code.

Ideally, the includes/functions/plugin_support.php file would get updated to the recently available copy from ZC 1.5.5: https://github.com/zencart/zencart/b...in_support.php (or perhaps that from 1.6.0 might be further improved?)

Technically though if SHOW_VERSION_UPDATE_IN_HEADER is set to false, then this shouldn't have been an issue... I'll also look at changing the criteria for performing the check, but ideally, there shouldn't be an issue with the check being attempted... Right? :)

[mc12345678]

I made these changes:
edited the init_user_tracking.php as suggested. Removed the config.user_tracking_install.php file and dropped in the plugin_support.php file from git hub. Those errors are gone.
Now I get this error:

PHP Parse error: syntax error, unexpected '<' in /hermes/bosnaweb07a/b261/ipg.garsquaredcom/obiecue/BBQadmin/user_tracking.php on line 390


I removed the line since it was commented out and the plugin is working.

Thanks,
Tony

Comments to these changes:

I made these changes:
edited the init_user_tracking.php as suggested. Removed the config.user_tracking_install.php file and dropped in the plugin_support.php file from git hub. Those errors are gone.

Dropping in the plugin_support.php file from github should have resolved the issue without editing init_user_tracking.php or removing the config.user_tracking_install.php file. (in fact now that those two portions have been performed, you will not receive in admin notification of an updated copy of user tracking being available from the ZC forum.)

PHP Parse error: syntax error, unexpected '<' in YOUR_SECRET_ADMIN/user_tracking.php on line 390

I removed the line since it was commented out and the plugin is working.

This is/was an error introduced in both "trimming" down the code that was on the live test version and "trying" to leave behind a possible "screen" (page source) indicator of where in the process the table was being presented. I have identified it as an issue on github and will be editing the file to address it. There are two ways that it could be addressed, I haven't evaluated yet which option is the way desired to go. It is/was intended to be an html comment (part of how the modification was being performed which was to build a table around the data that was being displayed to validate that relatively speaking the output was equivalent for the two methods). So it could either be deleted as was done above, or it could be "displayed" by encompassing in php related identifiers such as:

?><!--        <table border="0" width="100%" cellspacing="0" cellpadding="0"> --><?php

LASTLY, and probably most important for this store, suggest revising the admin directory name... :/ It should not be posted as a matter of norm and remain known only to those that have a need to access it.


Thank you for identifying the issues and way you resolved the problem(s).

[mc12345678]

By the way, the fix to admin/user_tracking.php file has been posted to github at the following commit: https://github.com/mc12345678/User_T...74511700d32b45

This will be incorporated into the next version. Please identify any other issues (possibly with solution) to be incorporated.

Thanks all!

[tonyreynolds]

Good point and thanks. Changes made to the admin directory.....

Tony


LASTLY, and probably most important for this store, suggest revising the admin directory name... :/ It should not be posted as a matter of norm and remain known only to those that have a need to access it.


Thank you for identifying the issues and way you resolved the problem(s).[/QUOTE]

[tonyreynolds]

Comments to these changes:


Dropping in the plugin_support.php file from github should have resolved the issue without editing init_user_tracking.php or removing the config.user_tracking_install.php file. (in fact now that those two portions have been performed, you will not receive in admin notification of an updated copy of user tracking being available from the ZC forum.)



This is/was an error introduced in both "trimming" down the code that was on the live test version and "trying" to leave behind a possible "screen" (page source) indicator of where in the process the table was being presented. I have identified it as an issue on github and will be editing the file to address it. There are two ways that it could be addressed, I haven't evaluated yet which option is the way desired to go. It is/was intended to be an html comment (part of how the modification was being performed which was to build a table around the data that was being displayed to validate that relatively speaking the output was equivalent for the two methods). So it could either be deleted as was done above, or it could be "displayed" by encompassing in php related identifiers such as:

?><!--        <table border="0" width="100%" cellspacing="0" cellpadding="0"> --><?php

LASTLY, and probably most important for this store, suggest revising the admin directory name... :/ It should not be posted as a matter of norm and remain known only to those that have a need to access it.


Thank you for identifying the issues and way you resolved the problem(s).

I undid all the edits to the original state, updated the user_tracking.php and kept the plugin_support.php file. Everything works properly. Thanks again.
TR