SitemapXML v.2

[mc12345678]

Hi,

Quick bug fix:
File includes/modules/pages/sitemapxml/sitemapxml_products.php
Find

mysqli_free_result($products->resource);

Replace by

//mysqli_free_result($products->resource);

Could go a little further with moving a few lines into the code bracket:

Changing:

  $sitemapXML->SitemapClose();
}
mysqli_free_result($products->resource);
unset($products);
unset($catsArray);

to:

  $sitemapXML->SitemapClose();
  mysqli_free_result($products->resource);
  unset($products);
}
unset($catsArray);

The variable $products is only set within that if statement group and therefore regarding the mysqli_free_result there wouldn't be anything to free if $sitemapXML->SitemapOpen('products', $last_date) returns false.

[ttfan]

It seems that some of my disabled products are included in the sitemap. Is this normal?

[mc12345678]

It seems that some of my disabled products are included in the sitemap. Is this normal?

When did the XML files get generated as compared to the product going disabled? If you generate the files again, do the inactive product drop off?

[Jeff_Mash]

Hey guys! I am upgrading to 1.5.5.f and just installed the mod. Seems to be working, except the Configuration Menu is not formatting correctly.

Here is a screenshot:

Attachment 17654

Any idea what is wrong? We had existing configuration from our previous install, so do we need to uninstall the Sitemap Configuration table, and then do a fresh install?

[mc12345678]

Hey guys! I am upgrading to 1.5.5.f and just installed the mod. Seems to be working, except the Configuration Menu is not formatting correctly.

Here is a screenshot:


Any idea what is wrong? We had existing configuration from our previous install, so do we need to uninstall the Sitemap Configuration table, and then do a fresh install?

Seems that the line:
Active plugins sitemapxml_categories.php;sitemapxml_mainpage.php;sitemapxml_manufacturers.php;s itemapxml_products.php;sitemapxml_products_reviews.php;sitemapxml_testimonials.p hp
Is too long... it's not editable and I don't know if the code has a trim to apply to it, but if the list were generated with a space between each module, perhaps it would wrap around and allow the edit box to either be on the right or down at the bottom.

As far as anything wrong with the module itself, no that is not the cause of this responsive screen response. The configuration menu is made of a set of code to apply to all configurations and just renders what is in the database.

[Jeff_Mash]

Seems that the line:
Active plugins sitemapxml_categories.php;sitemapxml_mainpage.php;sitemapxml_manufacturers.php;s itemapxml_products.php;sitemapxml_products_reviews.php;sitemapxml_testimonials.p hp
Is too long... it's not editable and I don't know if the code has a trim to apply to it, but if the list were generated with a space between each module, perhaps it would wrap around and allow the edit box to either be on the right or down at the bottom.

As far as anything wrong with the module itself, no that is not the cause of this responsive screen response. The configuration menu is made of a set of code to apply to all configurations and just renders what is in the database.

Yeah, I just was doing a little experiment and the problem is definitely due to that "Active Plugins" line. When I remove the value from the database, the Admin Menu looks normal.

I have no idea why it's even a configuration variable if it's not editable. Here is a screenshot to illustrate that point:

Attachment 17655

[mc12345678]

Yeah, I just was doing a little experiment and the problem is definitely due to that "Active Plugins" line. When I remove the value from the database, the Admin Menu looks normal.

I have no idea why it's even a configuration variable if it's not editable. Here is a screenshot to illustrate that point:

Attachment 17655

Well, the "edit" is by the selection of modules in the program itself. Those options get stored in the database and the effect of storing it as a contiguous string was not something of an issue before. Otherwise the menu is still functional just looks weird.

[Jeff_Mash]

Well, the "edit" is by the selection of modules in the program itself. Those options get stored in the database and the effect of storing it as a contiguous string was not something of an issue before. Otherwise the menu is still functional just looks weird.

I just thought it was strange to give an "update" button, when you can't really update anything in that variable configuration.

Overall, it's not a huge deal since the module still works. I just wonder, "Is your menu all wonky like mine with that long string?" Or do you not have a long string in your Active Plugins value?

[strelitzia]

I'm getting the following error logged when installing on zc 1.5.5f, running on PHP 5.6.30

PHP Warning: Illegal string offset 'SITEMAPXML_DIR_WS' in /Applications/MAMP/htdocs/tier1test/stOry-NTp-cOast/includes/modules/sitemapxml_install.php on line 34

Any ideas what is causing this?

[mc12345678]

I'm getting the following error logged when installing on zc 1.5.5f, running on PHP 5.6.30

PHP Warning: Illegal string offset 'SITEMAPXML_DIR_WS' in /Applications/MAMP/htdocs/tier1test/stOry-NTp-cOast/includes/modules/sitemapxml_install.php on line 34

Any ideas what is causing this?

Are lines 19 or 22 of the same file commented out?