Reward Points Full Suite v2.5 (for ZC v1.5x) Support Thread

[mesnitu]

Great!
That's for sure, this module needs to be updated.
I do remember having issues on module upgrade, I had to completely remove and then install.
But I have this working on the latest zc version with PHP 7.1.... or at least I think I have this working.
Tomorrow I'll test some more.

[tmccaff]

I am going to test this today. So far changed the MYSQL statements and those class functions to __construct.

[tmccaff]

A bug?

You cant enable both ot_reward_points and ot_reward_points_discount.

[tmccaff]

this line in ot_reward_points module:

$ot_module=DIR_FS_CATALOG_MODULES.'order_total/'."ot_reward_points_discount.php";
        if(file_exists($ot_module))
        {
            include($ot_module);
            $module=new ot_reward_points_discount;
            $module->remove(); 

I think is wrong as it should be ot_reward_points correct?

[tmccaff]

Anyone have fix for One Page Checkout for this? Can someone explain why this code is needed? Since you can't enable both it seems on 1.5.5

$ot_module=DIR_FS_CATALOG_MODULES.'order_total/'."ot_reward_points_discount.php";
        if(file_exists($ot_module))
        {
            include($ot_module);
            $module=new ot_reward_points_discount;
            $module->remove();
        }
    } 

[mesnitu]

have you try this:
#post1313855

I do remember that something is mentioned on the One page checkout support thread

[tmccaff]

No I didn't try that but here is what I was told but don't know what to do with it:

hanks I see that now; quick question it says to add this code in ot_reward_points.php after function collect_posts

PHP Code:

PHP Code:

if (isset($_SESSION['redeem_flag']) && $_SESSION['redeem_flag']) 
            $_POST['redeem_flag'] = $_SESSION['redeem_flag']; 

Here is the code in that function. Do I need to replace this code with one above? instead of request it's supposed to be session?

PHP Code:

function collect_posts()  
    { 
        if($_REQUEST['redeem_checkout_flag']) 
         if((isset($_REQUEST['redeem_flag']) && $_REQUEST['redeem_flag']) || (isset($_REQUEST['redeem_points']) && $_REQUEST['redeem_points']>0)) 
         { 
            $_SESSION['redeem_points']=$this->get_points_redeeming(); 
            $_SESSION['redeem_value']=$_SESSION['redeem_points']*GetRedeemRatio($_SESSION['customer_id']); 
         } 
         else 
          $this->clear_posts(); 
    } 

[delia]

tmccaff what version of php are you testing this on? Should work on 7 as 1.5.5f is designed for 7 and PCI certified only on php7

[tmccaff]

@delia thanks for responding. PHP 7.1 to my understanding you need to change some of the code to work with one page but not sure how or where to change this.

Also I think there is a bug if you enable rewards_points or rewards_points_discounts not both can be enabled just one. Not sure if that's a bug or what.

[delia]

so you are not on php 7. Rats. Other than that bug, you have it working in zc 1.5.5?