Edit Orders v4.0 Support Thread

[Dave224]

Just installed EO 4.3.1 on ZC 1.5.5e and starting to test. I'm not sure what should happen if a new product is added to the order wrt the shipping charge. Should the shipping charge be automatically updated? Or must it be manually updated? I'm using the Flat Rate shipping module and the EO recalculate totals checkbox is checked (default in config).

Also, if an order was created with another shipping module, store pickup in my case, should ALL other shipping methods that apply to that shipping zone be available in the shipping pull down menu? In my case, the Flat Rate module is not present.

Finally, I've noticed discussion of an edit orders log in other posts. How do you activate the edit orders logging process?

Thank you!

[lat9]

Just installed EO 4.3.1 on ZC 1.5.5e and starting to test. I'm not sure what should happen if a new product is added to the order wrt the shipping charge. Should the shipping charge be automatically updated? Or must it be manually updated? I'm using the Flat Rate shipping module and the EO recalculate totals checkbox is checked (default in config).

Also, if an order was created with another shipping module, store pickup in my case, should ALL other shipping methods that apply to that shipping zone be available in the shipping pull down menu? In my case, the Flat Rate module is not present.

Finally, I've noticed discussion of an edit orders log in other posts. How do you activate the edit orders logging process?

Thank you!

EO does not recalculate shipping; if the addition of a product to the order requires that shipping be updated, that's a manual process.

The shipping dropdown-selection "should" include all available shipping options.

To enable the EO debug, head over to your admin's Configuration->Edit Orders to change that setting. The debug creates file(s) in the /logs/edit_orders directory, one-per-order: debug_edit_orders_xx.log, where xx is the order number.

[Dave224]

Thanks! When you said logging was a config item, I figured there was a problem in installation. All shipping modules now appearing in drop down.

Shipping tax is entered in percent (10.0 for 10%), correct?

What tax adjustments should EO make if a misc cost or a one time discount is applied and the order qualifies for tax?

[lat9]

Thanks! When you said logging was a config item, I figured there was a problem in installation. All shipping modules now appearing in drop down.

Shipping tax is entered in percent (10.0 for 10%), correct?

What tax adjustments should EO make if a misc cost or a one time discount is applied and the order qualifies for tax?

Shipping tax is entered as a full value (as you indicated). EO makes no tax adjustments for misc-cost or one-time-discount additions, you've got to "bake" any tax-related updates into the addition/subtraction.

[Dave224]

Hmmm. That's not what I'm seeing. I get a tax increase for a misc cost. No effect on tax for a one time discount. Can you suggest a place to look for the problem? ot_misc_cost??? OE somewhere?? ot_tax???

Thanks for your rapid responses!

[lat9]

Hmmm. That's not what I'm seeing. I get a tax increase for a misc cost. No effect on tax for a one time discount. Can you suggest a place to look for the problem? ot_misc_cost??? OE somewhere?? ot_tax???

Thanks for your rapid responses!

I'll need to look at the innards ... tomorrow ... to give you an accurate answer.

[Dave224]

Actually, the current code allows a lot of flexibility. The Misc Cost will accept positive and negative cost adjustments. When the cost adjustment is negative, a credit is applied, and the tax is reduced by the tax on the cost adjustment. For a positive cost adjustment, the total increases by the adjustment plus the tax on the adjustment. Neglecting quantity and group discounts, this behavior is the same as increasing or decreasing the price of a taxable product.

Unfortunately, the one-time discount adjustment always calculates a discount for both positive and negative adjustments. If the sign were honored, you could use one-time discount for after-tax (non-taxed) credits and after-tax costs.

Because I want the flexibility of both before and after tax credits and costs, I'm going to search for where the one-time discount input is processed and see if I can get it to honor the adjustment sign. Rewording some of the displayed text may also be helpful.

Dave

[Dave224]

Well that was easy! Comment out one line in includes/modules/order_total/ot_onetime_discount.php. Enter a negative number for an after-tax discount; enter a positive number for an after-tax cost increase. Line 91 in EO v4.3.1 (shown below).

// if($discount > 0) $discount = $discount * -1;  edit to allow after-tax discount (-) or cost increase (+)

Text can be changed by overriding the file: includes/languages/english/modules/order_total/ot_onetime_discount.php

Do you see any problems with this change?

Dave

[lat9]

Dave, looks good. I'll consider perhaps an order-total customization switch (when it's enabled) to let store owners control what the onetime-discount does.

Thanks for the updates.

Update: GitHub issue created to track the change-request: https://github.com/lat9/edit_orders/issues/65

[Dave224]

I'm now integrating the admin_new_order add-on with EO 4.3.1 and zc 155e. The add-on requires and uses EO. Attempting to add a new order from admin fails in a call to EO function eoOrderIsVirtual with a null $eo at edit_order_functions.php line 293. The full backtrace follows (edited to remove the beginning portion of paths):

[31-Jan-2018 16:25:36 America/New_York] PHP Fatal error: Call to a member function eoOrderIsVirtual() on null in admin/includes/functions/extra_functions/edit_orders_functions.php on line 293
[31-Jan-2018 16:25:36 America/New_York] PHP Stack trace:
[31-Jan-2018 16:25:36 America/New_York] PHP 1. {main}() .../admin/new_order.php:0
[31-Jan-2018 16:25:36 America/New_York] PHP 2. order_total->process() .../admin/new_order.php:252
[31-Jan-2018 16:25:36 America/New_York] PHP 3. ot_tax->process() .../includes/classes/order_total.php:68
[31-Jan-2018 16:25:36 America/New_York] PHP 4. zen_get_tax_locations() .../includes/modules/order_total/ot_tax.php:31

A post in the admin_new_order support forum mentioned that the add-on works if the code that creates the order totals, including line 252 in new_order.php, is removed, the add-on appears to work. I'm not sure removing the code is the best approach. It seems to me that $eo needs to be established somewhere, but where? Perhaps in function zen_get_tax_locations in edit_orders_functions.php? Or in new_order.php? Should $eo be set to a new editOrders object?

Also, are there other things that should be done if EO is entered through the order_totals path rather than at the beginning of edit_orders.php?

Thanks for any assistance you can provide.

Dave