Edit Orders v4.0 Support Thread

[Dave224]

I'm just grasping at straws at this point. I hope you two can figure this out!

It would be nice to know what $order->info['total'] and $order->info['tax'] is supposed to include and what is not to be included at the point in EO logic "after adjustments" in the EO debug logs.

[swguy]

Same problem occurs with Group Discounts. Run the order with no discount, add the customer to a discount group, edit the order - the total is wrong.

Group Discount include tax = false, include shipping = false, recalculate tax = standard.

Original Order:
Sub-Total $500
FL Tax 7% 35.00
Total $535.00


Add Group discount of 25%:

Sub-Total $500
Group Discount $125
FL Tax 7% 26.25
Total $392.50

should be $401.25.

[lat9]

Are you thinking about something else maybe? The built-in Group Pricing module is an order total module just like the Quantity Discounts order total module. It doesn't change prices. It gives you a single line item discount.

Yep, I was thinking about the built-in quantity discounts' processing.

[Dave224]

If I trick function eoGetOrderTotalTax to return the tax on the quantity discount and make it a negative quantity, the order total and order tax is correct. In my test cases, the discount is $5.00 and the tax is 6%, or $0.30. See code below.

        // -----
        // Cycle through the order-totals to see if any are currently taxed.  If so, remove the
        // tax from the current order in preparation for its recalculation.
        //
        foreach ($order->totals as $current_total) {
            if (in_array($current_total['class'], array('ot_subtotal', 'ot_tax', 'ot_shipping', 'ot_total'))) {
                continue;
            }
            $current_total_tax = $eo->eoGetOrderTotalTax($oID, $current_total['class']);
            $current_total_tax = -0.3; // trick out function for test case
            $order->info['tax'] -= $current_total_tax;
        }

[lat9]

If I trick function eoGetOrderTotalTax to return the tax on the quantity discount and make it a negative quantity, the order total and order tax is correct. In my test cases, the discount is $5.00 and the tax is 6%, or $0.30. See code below.

        // -----
        // Cycle through the order-totals to see if any are currently taxed.  If so, remove the
        // tax from the current order in preparation for its recalculation.
        //
        foreach ($order->totals as $current_total) {
            if (in_array($current_total['class'], array('ot_subtotal', 'ot_tax', 'ot_shipping', 'ot_total'))) {
                continue;
            }
            $current_total_tax = $eo->eoGetOrderTotalTax($oID, $current_total['class']);
            $current_total_tax = -0.3; // trick out function for test case
            $order->info['tax'] -= $current_total_tax;
        }

Unfortunately, the keyword there is trick; I'm looking for a reliable way to regenerate any tax applied by those order-total modules.

[Dave224]

The "trick" was to demonstrate that the problem is that quantity discounts is not processed properly in function eoGetOrderTotalTax. If MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_TAX_CLASS were defined, the function would get the tax on the discount from the database, and no trick would be required. I'm trying to be helpful. If I'm not, tell me and I'll go away.

[Dave224]

The "trick" was to demonstrate that the problem is that quantity discounts is not processed properly in function eoGetOrderTotalTax. If MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_TAX_CLASS were defined, the function would get the tax on the discount from the database, and no trick would be required. I'm trying to be helpful. If I'm not, tell me and I'll go away.

Should be "...the function would calculate the tax from the discount value in the database, and ...

[lat9]

The "trick" was to demonstrate that the problem is that quantity discounts is not processed properly in function eoGetOrderTotalTax. If MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_TAX_CLASS were defined, the function would get the tax on the discount from the database, and no trick would be required. I'm trying to be helpful. If I'm not, tell me and I'll go away.

Dave, you are being helpful and realize that the issues' source is based on the lack of "standardization" of how various order-total modules choose to apply/remove any tax-based values.

[swguy]

Dave, you are being helpful and realize that the issues' source is based on the lack of "standardization" of how various order-total modules choose to apply/remove any tax-based values.

I think most modules have a _CALC_TAX setting, and the use of "Standard" is pretty common. You could start with that.

[swguy]

If MODULE_ORDER_TOTAL_QUANTITY_DISCOUNT_TAX_CLASS were defined, the function would get the tax on the discount from the database, and no trick would be required.

This is still a trick. As I said earlier, the TAX_CLASS variables were defined to support Credit Notes. You're overloading it to mean something else. This is not a good approach.