Forums / Templates, Stylesheets, Page Layout / Global Column setting not giving desired result in some instances

Global Column setting not giving desired result in some instances

Views: 966

Results 1 to 14 of 14
13 Jun 2018, 4:21 AM
#1
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Global Column setting not giving desired result in some instances

Using Responsive All Business template - I have a couple of sites where admin/configuration/layout settings/Global column right set to zero works fine in that the column disappears as it should and the page content expands across to the limit as it should, on other sites the column disappears BUT the white space remains where the column was.

So of the 5 sites I am working on they all have the same add-ons EXCEPT the 2 that are problematical have Google Merchant Center Feeder installed - but this add-on does not modify any templates so is unlikely to be causing this situation. (?)

I can only conclude that something by way of a modification to a template file is affecting the function, what that file is has me stumped and I have spent a lot of hours trying to figure this out so I am asking for help in finding out what files I should be looking at to then do a file comparison to find the rogue code, likely left from a long ago uninstalled add-on.

So looking for some assistance please.

cheers,
Mike

problematical sites are https://www.harmonyball.net.au and https://www.harmonyballpendant.com

13 Jun 2018, 10:52 AM
#2
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,116
Plugin Contributions:
56

Re: Global Column setting not giving desired result in some instances

Mike, you've got some HTML validation issues (see https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.harmonyballpendant.com%2F) that could be having an effect.

Could you post a screenshot of the top portion of your Configuration->Layout Settings, down to (and including) Column Width: Right?

13 Jun 2018, 11:37 AM
#3
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

lat9:

Mike, you've got some HTML validation issues (see https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.harmonyballpendant.com%2F) that could be having an effect.

Could you post a screenshot of the top portion of your Configuration->Layout Settings, down to (and including) Column Width: Right?

Hi Cindy - thanks for taking a look at this. attached is the screenshot requested.

cheers,
Mike
[Attachment no longer available]

13 Jun 2018, 1:43 PM
#4
rbarbour avatar

rbarbour

Totally Zenned

Join Date:
Feb 2010
Posts:
2,159
Plugin Contributions:
10

Re: Global Column setting not giving desired result in some instances

Does this template add the following:

Admin -> Configuration -> Layout Settings -> Left Column Width
Admin -> Configuration -> Layout Settings -> Center Column Width
Admin -> Configuration -> Layout Settings -> Right Column Width

if so

Admin -> Configuration -> Layout Settings -> Right Column Width should be set to "0"
&
Admin -> Configuration -> Layout Settings -> Center Column Width should pick up the value of
Admin -> Configuration -> Layout Settings -> Right Column Width

13 Jun 2018, 10:42 PM
#5
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

rbarbour:

Does this template add the following:

Admin -> Configuration -> Layout Settings -> Left Column Width
Admin -> Configuration -> Layout Settings -> Center Column Width
Admin -> Configuration -> Layout Settings -> Right Column Width

if so

Admin -> Configuration -> Layout Settings -> Right Column Width should be set to "0"
&
Admin -> Configuration -> Layout Settings -> Center Column Width should pick up the value of
Admin -> Configuration -> Layout Settings -> Right Column Width

Thanks for your response rbarbour.
includes/templates/responsive_all_business/common/tpl_main_page.php has the following regarding center column width;

<?php
 /**
  * decide center column width
  *
  */
if (COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '0' or $flag_disable_left == 'true' && $flag_disable_right == 'true') { ?>
<div class="col12">

<?php }elseif(COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' && $flag_disable_right == 'true'){ ?><div class="col11">

<?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '2' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' && $flag_disable_right == 'true'){ ?><div class="col10">

<?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2'){ ?><div class="col8">

<?php }elseif(COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '3' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' && $flag_disable_right == 'true'){ ?><div class="col9">

<?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3'){ ?><div class="col6">

<?php } ?>
<?php } ?>

In admin >> configuration >> layout settings >> column width - right ; setting to zero makes no difference - in fact making any changes to left or right width or boxes size makes no difference to column width even when global is set to 1.
It seems that these functions are not working at all regardless of global status - I cannot change left or right column width at all.

cheers,
Mike

13 Jun 2018, 11:03 PM
#6
rbarbour avatar

rbarbour

Totally Zenned

Join Date:
Feb 2010
Posts:
2,159
Plugin Contributions:
10

Re: Global Column setting not giving desired result in some instances

shags38:

Thanks for your response rbarbour.
includes/templates/responsive_all_business/common/tpl_main_page.php has the following regarding center column width;

<?php /** * decide center column width * */ if (COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '0' or $flag_disable_left == 'true' && $flag_disable_right == 'true') { ?> <div class="col12"> <?php }elseif(COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' && $flag_disable_right == 'true'){ ?><div class="col11"> <?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '1' or COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '2' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2' && $flag_disable_right == 'true'){ ?><div class="col10"> <?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '2'){ ?><div class="col8"> <?php }elseif(COLUMN_LEFT_STATUS == '0' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '0' && COLUMN_WIDTH == '3' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' && $flag_disable_left == 'true' or COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3' && $flag_disable_right == 'true'){ ?><div class="col9"> <?php }elseif(COLUMN_LEFT_STATUS == '1' && COLUMN_RIGHT_STATUS == '1' && COLUMN_WIDTH == '3'){ ?><div class="col6"> <?php } ?> <?php } ?>
> 
> In admin >> configuration >> layout settings >> column width - right ; setting to zero makes no difference - in fact making any changes to left or right width or boxes size makes no difference to column width even when global is set to 1. 
> It seems that these functions are not working at all regardless of global status - I cannot change left or right column width at all.
> 
> cheers,
> Mike

I am familiar with the code, I wrote it :-)

Look further down in Admin -> Configuration -> Layout Settings ->


Admin -> Configuration -> Layout Settings -> Left Column Width
Admin -> Configuration -> Layout Settings -> Center Column Width
Admin -> Configuration -> Layout Settings -> Right Column Width

These have 12 radio options to choose from.
13 Jun 2018, 11:21 PM
#7
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

rbarbour:

I am familiar with the code, I wrote it :-)

Look further down in Admin -> Configuration -> Layout Settings ->

Admin -> Configuration -> Layout Settings -> Left Column Width
Admin -> Configuration -> Layout Settings -> Center Column Width
Admin -> Configuration -> Layout Settings -> Right Column Width

These have 12 radio options to choose from.

None of the sites I use responsive_all_business template on (Anne - Picaflor Azul) have layout settings of 12 radio options that you are suggesting - (looking at screenshots of the installation readme file validates that) - here is full page screenshot of my site layout settings;

[Attachment no longer available]

13 Jun 2018, 11:36 PM
#8
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

@ rbarbour ... something is niggling at me that it may have something to do with side boxes layout controller function ?? admin/layout_controller.php ?? - I have no basis for thinking that other than a gut feeling - I am not sure if this file has control over the space or not? (or only the content within the space?)

cheers, Mike

14 Jun 2018, 12:09 AM
#9
rbarbour avatar

rbarbour

Totally Zenned

Join Date:
Feb 2010
Posts:
2,159
Plugin Contributions:
10

Re: Global Column setting not giving desired result in some instances

shags38:

@ rbarbour ... something is niggling at me that it may have something to do with side boxes layout controller function ?? admin/layout_controller.php ?? - I have no basis for thinking that other than a gut feeling - I am not sure if this file has control over the space or not? (or only the content within the space?)

cheers, Mike

I'll have to download it and take a look. what version of the template are you using?

14 Jun 2018, 12:18 AM
#10
rbarbour avatar

rbarbour

Totally Zenned

Join Date:
Feb 2010
Posts:
2,159
Plugin Contributions:
10

Re: Global Column setting not giving desired result in some instances

Mike,

I was wrong, it does use my code but a very old version of. I am not at my sandbox to fully install and play with but will try tomorrow and report back.

14 Jun 2018, 1:10 AM
#11
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

rbarbour:

I'll have to download it and take a look. what version of the template are you using?

Template Author : Picaflor Azul (c) 2013

Template Version : Version 1.0

Responsive All Business

3 other sites all using this same version are not having the issue https://www.cliponearrings.net.au https://www.treeoflifejewellery.com https://www.sterlingsilverrings.com.au .

Please take a look at this [previous] thread https://www.zen-cart.com/showthread.php?224082-Questions-re-Modifying-Responsive-All-Business which was a forerunner to this - user 'soxophoneplayer' is having the same issue on template Responsive Sheffield Blue which is another one of Annes (Picaflor Azul) - also appears to be having same issue with Responsive Classic template (another one of Annes??)

I look forward to hearing back from you tomorrow,
cheers,
Mike

14 Jun 2018, 1:48 PM
#12
rbarbour avatar

rbarbour

Totally Zenned

Join Date:
Feb 2010
Posts:
2,159
Plugin Contributions:
10

Re: Global Column setting not giving desired result in some instances

Okay,

I installed this on a clean 155f, copied the sql patches and all installed correctly.

I set
Admin -> Configuration -> Layout Settings -> Column Right Status - Global to "0"
Admin -> Configuration -> Responsive all Business Template -> ACTIVATE Responsive Template by selecting Column Widths to "3"

If ACTIVATE Responsive Template by selecting Column Widths is "0" it leaves a white space.

http://www.zcadditions.com/all_business/zencart-f/

14 Jun 2018, 10:58 PM
#13
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

rbarbour:

Okay,

I installed this on a clean 155f, copied the sql patches and all installed correctly.

I set
Admin -> Configuration -> Layout Settings -> Column Right Status - Global to "0"
Admin -> Configuration -> Responsive all Business Template -> ACTIVATE Responsive Template by selecting Column Widths to "3"

If ACTIVATE Responsive Template by selecting Column Widths is "0" it leaves a white space.

http://www.zcadditions.com/all_business/zencart-f/

Many thanks rbarbour - unfortunately that didn't work, my setting was '2' so changing it to '3' it merely increased the width of left column. All of my sites are set to '2'.

So can you think of anything else that would cause the space that 'right column' occupies to not to disappear when global status is changed ... or for the page not to expand to fill that space?
For example what file does the global column setting alter?
Is there an overriding default template file I should be comparing from a site that works ok to one that doesn't to find code variations?

cheers,
Mike

17 Jun 2018, 10:37 PM
#14
shags38 avatar

shags38

Totally Zenned

Join Date:
Jan 2011
Location:
Adelaide, Australia
Posts:
1,684
Plugin Contributions:
0

Re: Global Column setting not giving desired result in some instances

@ rbarbour - update - I have overcome the white space issue by the installation of 'blackcssdrop' plugin by lat9 - do not ask me how simply adding a drop menu plugin solved the problem but it did. ....... BUT now I have a problem with Mobile Usability according to the Google mobile testing tool - 1. content too wide for the screen and 2. clickable elements too close together - again ALL sites - rendering doesn't show image and right scroll is require to read content fully. Given that about 50% of searches are mobile it is not going to help business.

So the main changes done on each site was to increase the size of the header image and remove some elements from that header 'space', primarily search block and tagline, in an attempt to give the template a more modern look (and of course remove right column, the subject of this thread).

I can only assume that the 'responsive' components of this template (which is old in respect to responsive template design) are not handling the changes.

So with the template in your sandbox can you see any issues with the responsive components relative to the changes I've made? ... or any suggestions of what I should try / look at? is there something in responsive files that should be changed from a defined pixel measurement to a percentage instead for example?

Any assistance will be appreciated.

cheers, Mike

blackcssdrop readme file;

Free Dropdown Versions Module v alpha-release
Release Date: 3/12/2013
Publisher: PRO-Webs, Inc
Released for Zen Cart , v 1.3.9X & v 1.5.X

This installation is considered an INTERMEDIATE level Zen Cart module installation.

DO NOT attempt this install unless you are familiar with PHP, CSS and FTP.

If you need installation, please visit our store here:
http://pro-webs.net/store/index.php?main_page=product_info&cPath=10_27&products_id=414

This module is the framework to add a horizontal dropdown menu to your Zen Cart template.
There are many versions of this module, their styles are all different. The module seeks to
add controllable elements to your dropdown menu such as easy pages, banners, categories
and more.

This version is called Black CSS Drop-Down Menu. The menu can be easily
styled with CSS to suit your particular needs. It is 100% CSS with no
Javascript or similar to drive it.

INSTALLATION INSTRUCTIONS
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

  1. FIRST MAKE A FULL BACKUP OF YOUR WEBSITE'S FILES AND DATABASE!

  2. Upload the files making certain that you change YOUR-TEMPLATE to your own template
    directory name.

  3. In Configuration >> EZ-Pages Settings adjust the following setting to be empty

    EZ-Pages Header Link Separator

  4. Next you will add the include for the menu to your header. (and example file is provided)
    Locate includes >> templates >> your_template >> common >> tpl_header.php

<!--bof pro menu display--> <?php require($template->get_template_dir('tpl_pro_menu.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_pro_menu.php');?> <!--eof pro menu display-->

4a. also locate

<!--bof-header ezpage links--> <?php if (EZPAGES_STATUS_HEADER == '1' or (EZPAGES_STATUS_HEADER == '2' and (strstr(EXCLUDE_ADMIN_IP_FOR_MAINTENANCE, $_SERVER['REMOTE_ADDR'])))) { ?> <?php require($template->get_template_dir('tpl_ezpages_bar_header.php',DIR_WS_TEMPLATE, $current_page_base,'templates'). '/tpl_ezpages_bar_header.php'); ?> <?php } ?> <!--eof-header ezpage links-->

and remove it, we will be utilizing the header easy page menu in your new menu.

  1. If you turn OFF your easy pages header menu in your admin, the entire pages menu
    will also be turned off.

  2. Next you will likley need to edit the width of the menu. This is done the following file.
    includes/templates/your_template/css/stylesheet_dropdown-menu.css
    You will see it noted on line 10. There you can edit the default 750px to your width.

  3. You can edit the images, styles and anything you like.

The categories menu was specifically limited to top level categories only to give
the best device compatibility for your shop.