One-Page Checkout [Support Thread]

[rbarbour]

Figured out the mistake..I want to move the country field up.. Not having good luck figuring out how to do that..

Wow, welcome back!

/includes/templates/template_default/tpl_modules_opc_address_block.php

[lat9]

Wow, welcome back!

/includes/templates/template_default/tpl_modules_opc_address_block.php

Amen to that welcome back!

[getaped]

Hello,

I am unable to change and save an address on the checkout page being a full registered customer, guest checkout is off and I am logged in before checkout page.

I am using a Fresh install of zencart 1.55f with the responsive class template and opc 2.0.1. No changes have been made to either the zen install or opc mod. PHP 7.0.27 MySQL 5.5.5. Tested in Chrome and Firefox.

Changing the street address line, the Add to Address Book checkbox and the cancel and save changes buttons appear. Checking the add to address book and clicking save, the page reloads and the changes are not saved in either the address book or here on this checkout page.

Not saving it to the address book works and it reloads correctly with the change.

[lat9]

@getaped, I'm pretty sure that that issue was corrected in either v2.0.2 or v2.0.3 (now available from the plugins' download).

[getaped]

@getaped, I'm pretty sure that that issue was corrected in either v2.0.2 or v2.0.3 (now available from the plugins' download).

Ok, I've upgraded to 2.0.3 and it still does not work.

[lat9]

@getaped, I'm unable to reproduce your issue running OPC 2.0.3 on zc1.5.5f on PHP 7.1.4.

I logged in as a full-up registered user, changed the billing address, ticked "Save to Address Book" and the "Save" button. That address was recorded for the order and saved in the address-book.

I then changed the shipping address (in the same manner) and that updated shipping address was now associated with the order and saved in the address-book.

You should check to see that all the OPC classes (in /includes/classes, /includes/classes/ajax and /includes/classes/observers) are at the v2.0.3 version. Also verify that any template-override versions of the OPC's templates (they're distributed in the /includes/templates/template_default directory) have also been updated.

[getaped]

@getaped, I'm unable to reproduce your issue running OPC 2.0.3 on zc1.5.5f on PHP 7.1.4.

I logged in as a full-up registered user, changed the billing address, ticked "Save to Address Book" and the "Save" button. That address was recorded for the order and saved in the address-book.

I then changed the shipping address (in the same manner) and that updated shipping address was now associated with the order and saved in the address-book.

You should check to see that all the OPC classes (in /includes/classes, /includes/classes/ajax and /includes/classes/observers) are at the v2.0.3 version. Also verify that any template-override versions of the OPC's templates (they're distributed in the /includes/templates/template_default directory) have also been updated.

Hello,

Yes, everything is new. This is the 3th fresh install I have done and it does not work. They are fresh downloads and installs of zen and opc. No plugins added except opc and whatever defaults with zencart.

- downloaded and installed zencart 1.5.5f with demo data
- created a customer account
- changed 5 template names and admin name on opc install and installed it
- enabled opc
- test order by adding apt 100 in the address line 2 box, clicked add to address box and saved. failed to save, no error message.

You can see the apt 100 in the suburb field, but it doesn't get validated and saved.

2018-06-27 12:54:18 OnePageCheckout: validateAndSaveAJaxPostedAddress(bill, ..), POST: array (
  'securityToken' => 'cb75bcdd6657ee466c50d716852e54e2',
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => 'apt 100',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'shipping_billing' => 'true',
  'add_address' => 'true',
)
2018-06-27 12:54:18 OnePageCheckout: Start validateUpdatedAddress, which = bill:array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => 'apt 100',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
)
2018-06-27 12:54:18 OnePageCheckout: Exiting validateUpdatedAddress.array (
)array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 OnePageCheckout: saveCustomerAddress(bill, 1), shipping=billing array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 OnePageCheckout: findAddressBookEntry, returning (2) for 'testuser123mainstreetanytown20772'array (
  'which' => 'bill',
  'gender' => 'm',
  'company' => '',
  'firstname' => 'Test',
  'lastname' => 'User',
  'street_address' => '123 Main Street',
  'suburb' => '',
  'city' => 'Anytown',
  'state' => 'Maryland',
  'postcode' => '20772',
  'zone_country_id' => '223',
  'country' => '223',
  'zone_id' => '31',
  'zone_name' => 'Maryland',
  'error_state_input' => false,
  'country_has_zones' => true,
  'show_pulldown_states' => false,
  'error' => false,
  'validated' => true,
  'selected_country' => '223',
  'state_field_label' => 'State/Province:',
)
2018-06-27 12:54:18 index: validateAddressValues, returning:array (
  'status' => 'ok',
  'errorMessage' => '',
  'messages' => 
  array (
  ),
)OnePageCheckout::__set_state(array(
   'isGuestCheckoutEnabled' => false,
   'registeredAccounts' => false,
   'guestIsActive' => false,
   'isEnabled' => true,
   'tempAddressValues' => 
  array (
    'ship' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
    'bill' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
  ),
   'guestCustomerInfo' => NULL,
   'guestCustomerId' => 3,
   'tempBilltoAddressBookId' => 3,
   'tempSendtoAddressBookId' => 4,
   'dbStringType' => 'stringIgnoreNull',
   'customerInfoOk' => NULL,
   'billtoTempAddrOk' => true,
   'sendtoTempAddrOk' => NULL,
   'isVirtualOrder' => false,
   'billtoAddressChangeable' => true,
   'shiptoAddressChangeable' => NULL,
   'sendtoAddressChangeable' => true,
))
2018-06-27 12:54:18 checkout_one: CHECKOUT_ONE_ENTRY, version (2.0.3 (2018-06-21)), Zen Cart version (1.5.5f), template (responsive_classic)
2018-06-27 12:54:18 OnePageCheckout: startGuestOnePageCheckout, exit: sendto: 2, billto: 2OnePageCheckout::__set_state(array(
   'isGuestCheckoutEnabled' => false,
   'registeredAccounts' => false,
   'guestIsActive' => false,
   'isEnabled' => true,
   'tempAddressValues' => 
  array (
    'ship' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
    'bill' => 
    array (
      'gender' => '',
      'company' => '',
      'firstname' => '',
      'lastname' => '',
      'street_address' => '',
      'suburb' => '',
      'city' => '',
      'postcode' => '',
      'state' => 'Maryland',
      'country' => 223,
      'zone_id' => 31,
      'zone_name' => 'Maryland',
      'address_book_id' => 0,
      'selected_country' => 223,
      'country_has_zones' => true,
      'state_field_label' => 'State/Province:',
      'show_pulldown_states' => false,
      'error' => false,
      'error_state_input' => false,
      'validated' => false,
    ),
  ),
   'guestCustomerInfo' => NULL,
   'guestCustomerId' => 3,
   'tempBilltoAddressBookId' => 3,
   'tempSendtoAddressBookId' => 4,
   'dbStringType' => 'stringIgnoreNull',
   'customerInfoOk' => NULL,
   'billtoTempAddrOk' => true,
   'sendtoTempAddrOk' => NULL,
   'isVirtualOrder' => false,
   'billtoAddressChangeable' => true,
   'shiptoAddressChangeable' => NULL,
   'sendtoAddressChangeable' => true,
))

[lat9]

Ah, that's a different issue than a general "address not saving". I've replicated the issue where the suburb is not being kept and have created a GitHub issue (https://github.com/lat9/one_page_checkout/issues/143) to track the associated changes.

[lat9]

Ah, that's a different issue than a general "address not saving". I've replicated the issue where the suburb is not being kept and have created a GitHub issue (https://github.com/lat9/one_page_checkout/issues/143) to track the associated changes.

I've got that corrected on GitHub, with an update to /includes/classes/OnePageCheckout.php's validateUpdatedAddress method. Find the following code fragment within that method:

        $street_address = zen_db_prepare_input($address_values['street_address']);
        if (strlen($street_address) < ENTRY_STREET_ADDRESS_MIN_LENGTH) {
            $error = true;
            $messages['street_address'] = $message_prefix . ENTRY_STREET_ADDRESS_ERROR;
        }
        
        $city = zen_db_prepare_input($address_values['city']);
        if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
            $error = true;
            $messages['city'] = $message_prefix . ENTRY_CITY_ERROR;
        }

and insert the highlighted section to provide the correction:

        $street_address = zen_db_prepare_input($address_values['street_address']);
        if (strlen($street_address) < ENTRY_STREET_ADDRESS_MIN_LENGTH) {
            $error = true;
            $messages['street_address'] = $message_prefix . ENTRY_STREET_ADDRESS_ERROR;
        }
        
        if (ACCOUNT_SUBURB == 'true') {
            $suburb = zen_db_prepare_input($_POST['suburb']);
        }
        
        $city = zen_db_prepare_input($address_values['city']);
        if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
            $error = true;
            $messages['city'] = $message_prefix . ENTRY_CITY_ERROR;
        }

[getaped]

I've got that corrected on GitHub, with an update to /includes/classes/OnePageCheckout.php's validateUpdatedAddress method. Find the following code fragment within that method:

......

Great, that worked. The company name field also needs to be fixed.