SitemapXML v.2

[weif]

PHP Fatal error: 1054:Unknown column 'SITEMAPXML_PRODUCTS_REVIEWS_ORDERBY' in 'order clause' ::

PHP Warning: Use of undefined constant SITEMAPXML_CHECK_DUPLICATES - assumed 'SITEMAPXML_CHECK_DUPLICATES'

Looking into this further, it looks like there may be an error or omission in
/YOUR_ADMIN/includes/modules/sitemapxml_install.php

I am not receiving this error, but I am receiving a similar error that TABLE_SITEMAPXML_EXTRAURLS is not defined.

One thing I did find is that on line 24 and 25, it appears that SITEMAPXML_CHECK_DUPLICATES is spelled SITEMAPXML_CHECK_DUBLICATES (note the "B" instead of the "P"). I don't know if this is the cause of the error, or if it is even actually an error.

However, this file appears to both define the variables you are running into errors with, and be the only references I am finding to those variable names...

[torvista]

Regarding url rewriters...

Native url: http://www.site.com/index.php?main_p...oducts_id=2309
Friendly url: www.site.com/widgets/widget1

I would have thought the best option would be to always submit the native url (doesn't change) instead of the friendly url, to avoid links becoming obsolete with minor name changes, which I do often.

What does the panel think?

[weif]

Regarding url rewriters...

Native url: http://www.site.com/index.php?main_p...oducts_id=2309
Friendly url: www.site.com/widgets/widget1

I would have thought the best option would be to always submit the native url (doesn't change) instead of the friendly url, to avoid links becoming obsolete with minor name changes, which I do often.

What does the panel think?

This is another piece of "SEO is complicated."

The URL rewriter should be redirecting visitors to the SEO-friendly URL, among other reasons because you don't want to submit the same content at multiple different URLs (that can have a negative impact on that particular page as well as on the entire site). But you do not want to have the search engines hitting a URL the server immediately tells them is wrong by redirecting them. And you do want the search engines seeing the friendly URLs - that's why you made them search engine friendly in the first place. And you want to tell the search engines what URL to go to (and that should be the one you want them to index). And you don't want to be changing the URLs of pages a lot.

So, the URL in the sitemap should be the friendly, rewritten URL for a number of SEO reasons, but at the same time, while you want to make your URLs as good for SEO as you can (if you're using a friendly URL generator), you really don't wan to be changing them too often.

[jeking]

Regarding url rewriters...

Native url: http://www.site.com/index.php?main_p...oducts_id=2309
Friendly url: www.site.com/widgets/widget1

I would have thought the best option would be to always submit the native url (doesn't change) instead of the friendly url, to avoid links becoming obsolete with minor name changes, which I do often.

What does the panel think?

I also agree the rewritten url (if that is the approach chosen by the store owner) should be used. I have a client that had problems getting indexed. We believe part of the problem was the sitemap submitted was the default url. Google crawls the url getting a 301 to the rewritten url. The canonical was the default. It creates this loop that Google cannot ever index the url it's given via the sitemap or canonical.

While I believe this is the correct answer, it is also why choosing to use rewritten url's is no easy decision. You lock yourself into a url structure. Should the plugin be abandoned, you could be forced to all new urls...unless the new one (say CEON) allows you to set the new ones to match the old, but this is not always possible.

[torvista]

Thanks for the information.

[torvista]

I have a problem, only when using a cron job to rebuild the categories sitemap.

It's php 7.1.26.

This is the debug log:
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 16384 bytes) in /home/XXXXXXXX/public_html/tienda/includes/classes/db/mysql/query_factory.php on line 45
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 16384 bytes) in /home/XXXXXXXX/public_html/tienda/includes/extra_configures/enable_error_logging.php on line 31
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Warning: Unknown: Cannot call session save handler in a recursive manner in Unknown on line 0
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Warning: Unknown: Failed to write session data using user defined save handler. (session.save_path: /home/XXXXXXXX/public_html/tienda/cache) in Unknown on line 0

It builds a file with 1201 entries then dies, every time.

If I reduce the SITEMAP_MAX_ENTRIES in the class to 500, then it creates three files, two complete of 500 and one broken of 28 entries.

Note that my table rows are:
categories: 2,187
categories description: 4,374 (dual language site)
products to categories: 103,235 (not a typo)

Executing the cgi-bin file from the browser works ok, it is only the cron that fails.

[torvista]

...further to this, the cron job can be set to use different versions of php.
When using 5.4/5.5/5.6 it works.
When using 7.0/7.1 it fails.

[echexxxxxxxx10]

Hi everyone, I noticed that in the product sitemap it puts the url to an image that doesn't exist ... I use Image Handler 5

see image here
https://i.postimg.cc/kGf6BFW0/Cattura.jpg

can anyone help with this error?
thank you

[shrimp-gumbo-mmmhhh]

First of all... Thank you guys for a great module......

Zen Cart 1.5.6a
Database Patch Level: 1.5.6
PHP Version: 7.2.17 (Zend: 3.2.0)
<<<modules>>>
backup_mysql
encrypted_master_password
keep_cart
numinix-google-analytics
remember me
usu-3.0
Image Handler 5
SiteMapXML

I had just added SitemapXML to my site and these are the errors I have gotten. 3 Errors total


[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php) called at [/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php:15]
#2 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#3 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#4 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#5 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant SITEMAPXML_SITEMAPINDEX - assumed 'SITEMAPXML_SITEMAPINDEX' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php on line 14.


[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php) called at [/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php:15]
#2 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#3 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#4 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#5 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant SITEMAPXML_SITEMAPINDEX - assumed 'SITEMAPXML_SITEMAPINDEX' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php on line 36.


[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#2 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#3 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#4 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant TABLE_SITEMAPXML_EXTRAURLS - assumed 'TABLE_SITEMAPXML_EXTRAURLS' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php on line 135.




------------------------------------
[24-Apr-2019 21:57:48 America/Chicago] Request URI: /index.php?main_page=sitemapxml&ping=yes, IP address: XX.XX.XX,XX
#1 mysqli_free_result() called at [/home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php:122]
#2 include(/home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php) called at [/home/shrimps/public_html/includes/templates/template_default/sitemapxml/tpl_main_page.php:21]
#3 require(/home/shrimps/public_html/includes/templates/template_default/sitemapxml/tpl_main_page.php) called at [/home/shrimps/public_html/index.php:97]
--> PHP Warning: mysqli_free_result() expects parameter 1 to be mysqli_result, null given in /home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php on line 122.




------------------------------------


[24-Apr-2019 21:57:49 America/Chicago] Request URI: /ADMIN/sitemapxml.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/sitemapxml.php:21]
--> PHP Warning: Use of undefined constant TABLE_SITEMAPXML_EXTRAURLS - assumed 'TABLE_SITEMAPXML_EXTRAURLS' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php on line 135.

[enginarat]

Linux
PHP 7.0.33
My SQL 5.6.43
Fresh install 1.5.6b

Hi,
Does this work on 1.5.6b?
This was the easiest thing to get to work back in the old days. Now I spent last 2 hours on it and I can't seem to get it to work.
I remember with old versions there were blank example XML sitemaps (categories, products, reviews, etc.) to put in store folder (under /public_html)
This is not mentioned in V.2 instructions. I just didn't want to assume that this version would generate those blank XML files and write to them so I put them there like we used to. So I go to the admin panel, work through configuration and try to write to those xml files through admin/tools. AND I get nothing but frozen screen. Please see attached screen shots. All permissions are set 777 including the sitemap folder.





Any help is highly appreciated.