Using PhpStorm

[lankeeyankee]

There is a PHP inspection plugin for Phpstorm called EA Extended: another world of php nitpicking to spend endless hours with, but the principal things it spits out are

recommending strict comparisons when possible.
ie.
if ($action == 'edit')...
to
if ($action === 'edit')...

and using single quotes around sql text chunks

As there are so many of them to initially correct, it's hard to see any real issues (can't see the wood for the trees).

For ongoing code/PR submissions, should I "correct" these things or ignore them?

I'll have to install that, thanks for pointing it out. I think it's important moving forward to future-proof so think making the changes as the code is being worked on would be the best way. That's what I've been doing, and the amount of warnings when the log all errors mod is on is steadily shrinking.