Big Royal Mail 3.0

[flappingfish]

Is this the module i want for integrating with my royal mail online buisness account to make use of 24/48 hr rm?

[brittainmark]

No Sorry. This is for people who use the post office to post their parcels. You could change the descriptions of maybe small parcel and replace first and second class with the appropriate definitions then set the rates to the appropriate weights and values. The routine just calculates the cost of postage based on weight and value.

[cefyn]

I'm using 1.5.7b, bootstrap template, and have updated to BigRoyalMail v3.5, and while everything is working ok, I get this in my error logs

PHP Notice: Undefined variable: shipping_method in /includes/modules/shipping/BigRoyalMail/quote.php on line 199
PHP Notice: Undefined variable: shipping_cost in /includes/modules/shipping/BigRoyalMail/quote.php on line 200

Any ideas anyone? Thanks

[brittainmark]

Not 100% certain but it sounds like you have a mis-defined shipping method. If you have updated from a previous version of big royal mail can you check that you have removed the EU shipping methods (instructions in the docs section). If this is a new install can you let me know which royal mail products you have installed and i'll have a look to see if there is a bug.
Regards
Mark

[cefyn]

Thanks for your reply and your hard work on this module. Yes, I have removed the outdated shipping methods. When I uninstall all the modules except storepickup and proceed to checkout I get
PHP Notice: Malformed value for session-based shipping module; customer will need to re-select: false in /includes/classes/order.php on line 323, though I can check out.
On installing storepickup and RM 1st small parcel I again get,
[08-Feb-2021 13:07:02 Europe/London] PHP Notice: Undefined variable: shipping_method in /includes/modules/shipping/BigRoyalMail/quote.php on line 199
[08-Feb-2021 13:07:02 Europe/London] PHP Notice: Undefined variable: shipping_cost in /includes/modules/shipping/BigRoyalMail/quote.php on line 200

[brittainmark]

Just done a clean install on 1.5.7b with bigroyal mail and all works fine. Could be something left behind from upgrade.
*****Before doing any below please ensure you have backed up your database!!.*****
Are you familiar with PHPMYADMIN. if so could be worth extracting all the royal mail shipping items from the configuration table and exporting them (only necessary if you have made and changes to the default values)

SELECT * FROM configuration WHERE configuration_key LIKE 'MODULES_SHIPPING_RM%';

should give you the list of keys for you to export.
Next I would run

DELETE  FROM configuration WHERE configuration_key LIKE 'MODULES_SHIPPING_RM%'

this should remove all the entries that have been created by big royal mail.
***NB if you use a prefix and are running this in PHPMYADMIN you will need to include the table prefix for the table. so if zen is your prefix configuration becomes zen_configuration

If you do not know phpmyadmin the the delete command will work without the prefix.

then try and ship a product again. if it still does not work then I would suggest it is not big royal mail that is causing the issue.
If it works then try reinstalling one of the modules with Hide Invalid Shipping set to False this should then display the shipping method even if it is not valid for the order. It should also give a reason it is not valid or the rate.
Let me know how this goes.

[brittainmark]

Thanks for your reply and your hard work on this module. Yes, I have removed the outdated shipping methods. When I uninstall all the modules except storepickup and proceed to checkout I get
PHP Notice: Malformed value for session-based shipping module; customer will need to re-select: false in /includes/classes/order.php on line 323, though I can check out.
On installing storepickup and RM 1st small parcel I again get,
[08-Feb-2021 13:07:02 Europe/London] PHP Notice: Undefined variable: shipping_method in /includes/modules/shipping/BigRoyalMail/quote.php on line 199
[08-Feb-2021 13:07:02 Europe/London] PHP Notice: Undefined variable: shipping_cost in /includes/modules/shipping/BigRoyalMail/quote.php on line 200

Forget Last message I think I have found it. It appears to be caused when there is no valid shipping method for the item selected. I'll complete my investigation and probally issue a patch. I suspect that you have error reporting set to all which is why it is appearing. Short temp fix would be to modify the quote.php to include

$shipping_method='';
$shipping_cost=''; 

after line 15 $module = strtoupper($this->code);

Mark

[cefyn]

Thanks for taking all this time to look into it, your module is essential for any uk seller and very much appreciated. That fixed it. I did set error reporting to all, I had some problems after upgrading. Can't switch it off now!

[brittainmark]

no problem. I have found a few things that need updating for php8 so I have made a few more changes. Just need to test it all then I will put up a new version.

For error reporting you could look in the code if that is where you put it for error_reporting or possible display_errors these are the php commands that set error reporting and determine if they are displayed on the screen or not. If you change the server settings and you used cpanel then look for PHP selector the choose options and untick display_errors

Zen cart is pretty good at loging errors and warnings in the logs folder.

[cefyn]

I hadn't noticed that Configuration/logging/report all errors/ was switched on. BTW the ability to set a minimum shipping method in attributes is brilliant. Thanks again for your add-on.