
Originally Posted by
carlwhat
i agree that this method is better...
in general, i am not a fan of these hard coded switches, ie NONE cause the method to exit, but a different topic.
i do not see a problem here. the method only processes one email, and there is nothing done with the return value in the customers.php script (at least that i can tell...)
In this portion of the code:
Code:
// loop thru multiple email recipients if more than one listed --- (esp for the admin's "Extra" emails)...
foreach(explode(',',$to_address) as $key=>$value) {
The theory is that there may be multiple recipients: $to_email_address is the value for the "current" recipient.
At the point of the evaluation of 'NONE', that then current recipient is being "evaluated". If *THAT* recipient isn't to receive the email, then guess what, no one further is to receive it regardless the number of recipients. That is because of `return true` instead of `continue`...
Sooo... Anyone that is having problems with emails being initiated (e.g. no log of an email when logging emails), it is possible that one or more of the recipients had their setting to 'NONE' or 'OUT' such that any previous recipient would have been "sent" the message, but that one and any further would not...
So yes, it processes one email, but considers multiple recipients and that area of the code neglects consideration of any subsequent recipient if the current one doesn't want to receive emails.
Bookmarks