One-Page Checkout [Support Thread]

[jpda]

I can! It's a core-file issue; you'll need to edit /includes/classes/shipping.php's cheapest method:

  function cheapest() {
    if (!is_array($this->modules)) return false;
      $rates = array();

      foreach($this->modules as $value) {
        $class = substr($value, 0, strrpos($value, '.'));
        if (isset($GLOBALS[$class]) && is_object($GLOBALS[$class]) && $GLOBALS[$class]->enabled) {
          $quotes = isset($GLOBALS[$class]->quotes) ? $GLOBALS[$class]->quotes : null;
          if (empty($quotes['methods'])) {
            continue;
          }
          $size = sizeof($quotes['methods']);
          for ($i=0; $i<$size; $i++) {
            if (isset($quotes['methods'][$i]['cost'])){
              $rates[] = array('id' => $quotes['id'] . '_' . $quotes['methods'][$i]['id'],
                               'title' => $quotes['module'] . ' (' . $quotes['methods'][$i]['title'] . ')',
                               'cost' => $quotes['methods'][$i]['cost'],
                               'module' => $quotes['id']
              );
            }
          }
        }
      }

      $cheapest = false;
      $size = sizeof($rates);
      for ($i=0; $i<$size; $i++) {
        if (is_array($cheapest)) {
          // never quote storepickup as lowest - needs to be configured in shipping module
          if ($rates[$i]['cost'] < $cheapest['cost'] and $rates[$i]['module'] != 'storepickup') {
            $cheapest = $rates[$i];
          }
        } else {
          if ($rates[$i]['module'] != 'storepickup') {
            $cheapest = $rates[$i];
          }
        }
      }
      $this->notify('NOTIFY_SHIPPING_MODULE_CALCULATE_CHEAPEST', $cheapest, $cheapest, $rates);
      return $cheapest;
  }

... and change the highlighted line to read:

          if ($size === 1 || $rates[$i]['module'] != 'storepickup') {

That change enables the storepickup to be selected as the cheapest ... if it's the only shipping method available.

Hi Cindy,

If the only shipping method is storepickup AND storepickup contains more than one pickup point, may be with different prices, then $size equals the number of pickup points (not 1).
Thus, $cheapest is false and shipping options are shown but none will be selected.

Tested in:
zc157d
OPC 2.4.6
Site has storepickup as the only shipping method but configured with 5 locations and different prices.
e.g.: Loc_A, 8.5045;Loc_B, 2.5045;Loc_C, 4.5045;Loc_D, 7.5045;Loc_E, 0.5045
To test, I changed shipping.php, round line 216

        } else {
          if ($size === 5 || $rates[$i]['module'] != 'storepickup') {
            $cheapest = $rates[$i];
          } 

Thus, $size === 5.
The 5 locations are shown with bullets in the same order and the first bullet is selected (not cheapest!).
Payment options are shown as well.

Without my change in shipping.php, the shipping locations are shown in the same order, none populated and no Payments options are shown, need to refresh the screen to get the payment options (or set 'Payment-Block Action on Shipping Change' to 'Refresh' i.s.o 'Update').

Any suggestions?


Thanks,

@jpda