One-Page Checkout [Support Thread]

[lat9]

I'll note that this is a 'base' Zen Cart issue, not specific to OPC. I've opened the issue on the Zen Cart GitHub repository: https://github.com/zencart/zencart/issues/6023

[jpda]

I'll note that this is a 'base' Zen Cart issue, not specific to OPC. I've opened the issue on the Zen Cart GitHub repository: https://github.com/zencart/zencart/issues/6023

@lat9

Thank you!

jpda

[lat9]

Hello Cindy,

I should have sent you this before my previous post on october, 25th.

I had changed shipping.php, but the only available shipping method storepickup was not selected as cheapest.
IMHO because storepickup has an option to register more than one pickup point with different prices.

Did some testing described in my post https://www.zen-cart.com/showthread....04#post1397504

Thanks,

@jpda

Please note that DrByte has provided a correction on the Zen Cart GitHub (https://github.com/zencart/zencart/p...b01164048b9c77).

@jpda, could you confirm that those changes correct the issue that you identified?

[jpda]

Please note that DrByte has provided a correction on the Zen Cart GitHub (https://github.com/zencart/zencart/p...b01164048b9c77).

@jpda, could you confirm that those changes correct the issue that you identified?

@lat9
Short answer: no, they didn't.

Explanation:
I am testing on:
zc157d
OPC 2.4.6 (OPC is essential))
shipping method: storepickup with 5 locations, each with their own price.
Problem was: shipping methods are shown but none selected -> payment choices are not shown.

To test the github version of shipping.php, I only replaced its public function cheapest() in the v157d shipping.php.
(The entire github version of shipping.php doesn't work in my v157d environment.)

Tested, but no joy.
Did some debugging:
Changed line 272:

 } elseif ($size === 1) {

in:

} elseif (count($modules_with_quotes) === 1) {

Reason:
module storepickup with more than one location has a $size that equals the number of locations (5 in my example).
Now it works.
Even whith more shipping modules than only storepickup, it is still working.
Tried with flat rate and table and storepickup together.
The lowest price is selected by OPC, even if it is one of the storepickup locations. Payment choices are shown.

Tested without OPC enabled. Three or four page checkout, no cheapest selected, user needs to select shipping to continue to next screen.

Would this be a solution?

Thanks,

jpda

[lat9]

@jpda, would you post your "Pickup Locations" setting for the storepickup module (or send to me via PM) so that I can (a) replicate the issue and (b) give your solution a try?

[jpda]

@jpda, would you post your "Pickup Locations" setting for the storepickup module (or send to me via PM) so that I can (a) replicate the issue and (b) give your solution a try?

@lat9
Of course, copy this string in storepickup:
Loc_A, 9.50;Loc_B, 2.50;Loc_C, 4.50;Loc_D, 7.50;Loc_E, 0.50
and whatever you want for taxes.
I have set CHECKOUT_ONE_ENABLE_SHIPPING_BILLING = true.

Thanks,

@jpda

[jpda]

@lat9
Forgot this:
Shipping Cost
0.00

Tax Basis
Shipping

[lat9]

Thanks for the info, @jpda. I'll look at that over the weekend.

[jpda]

Thanks for the info, @jpda. I'll look at that over the weekend.

The change in shipping.php that I posted was:

 } elseif (count($modules_with_quotes) === 1) {

is not correct if storepickup is not the only method available because count($modules_with_quotes) > 1.

I changed that line to: (rather weird...)

   } elseif (true) {

and then it works also when other shipping methods are available.
The selected price is not always the cheapest.
If I find a better solution, I will let you know.

@jpda

[carlwhat]

...

I changed that line to: (rather weird...)

   } elseif (true) {

...

code is never weird.... it is code... understanding it can be difficult.

without getting into the logic in question here, the above line of code would be better suited as:

   } else {

best.