Edit Orders v4.0 Support Thread

[wsworx]

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?

*****************************************
[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

[wsworx]

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?

*****************************************
[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

[wsworx]

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:

************************************
[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

**************************************************

When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

$define = [
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

I added the following to the file:

'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

[wsworx]

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:

************************************
[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

**************************************************

When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

$define = [
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

I added the following to the file:

'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

I have added these along with several other issues to the github for editorders.

[clam_man]

Whenever an order with sales tax is updated, the sales tax for the city and state no longer appear in the invoices or on the order's info, but it is calculated correctly in the total. I'm on 1.5.8a. What is the fix for this? I need the tax to appear on invoices after an order is edited instead of it just disappearing. I checked my logs and they aren't showing any issues with the page.

[clam_man]

I messaged mcqueenycoins since I was having the exact same behavior as them, however our ot_tax.php is completely unchanged and is the same as the vanilla 1.5.8a ot_tax.php in includes/modules/order_total so I don't have a clue what would be causing that line to no longer show up after an order is edited with Edit Orders 4.7.1

[clam_man]

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?

[lat9]

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?

What order-total modules are in use on the site?

[clam_man]

Currently just using:
ot_coupon, ot_group_pricing, ot_gv, ot_loworderfee, ot_shipping, ot_subtotal, ot_tax, ot_total

[wsworx]

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.

Anyone using EO should not upgrade to 2.1 yet.
I have EO 4.7.1 working in 2.0.1.
EO 4.7.1 does not function correctly in Zen 2.1.
EO 5 is in beta mode currently and is not ready for prime time although lat9 is working hard at getting it ready.
Anyone who has loaded Zen 2.1 and EO5, test sites only DO NOT USE ON LIVE SITE you've been warned lol, and is finding issues are asked to report those issues on the GitHub site for EO 5: EO5 GitHub