Responsive Classic Redesign Support thread

[pilou2]

For what version of ZC is it? Looking at non-template files, it is close to v2.2.2 but different. Class files are not needed at all for ZC v2.2.2 or v3.0.0.
Could you clarify for which ZC range it is designed, please?

[dbltoe]

Looking really good.

https://validator.w3.org/nu/?doc=htt...artdemo.com%2F

https://jigsaw.w3.org/css-validator/...artdemo.com%2F

Unless you are changing the .cart-content font size when going mobile, you may want to jump it up to 16 px. Otherwise, it may be hard to read on mobile.

Other testers are complaining that you have set a min-height but not a min-width on stylesheet.css line 627. Also, the items are covered by stylesheet_zcustom.css on line 1256.

I understand that most folks know what the "hamburger" is for, but you need to have the same cursor change on hover as you do for the other icons in the header. I haven't really looked at mobile or tablet, but remember that there's no mouse involved, which means you have to use some other method to identify "tappable links".

Whether you go with one aria landmark or a landmark for each section of the opening window, it needs at least one.

It's not an error, but you might want to consider adding a closing icon at the bottom of the opening window to avoid having to return to the beginning to close the window.

jQuery CDN is really throwing a monkey wrench into page load. It's not really relevant with today's browsers but if you must, consider adding defer so pages can load much faster. With today's speed, making the customer wait for 3 seconds on a mobile phone is liable to lose them. https://www.zencartdemo.com/index.ph...products_id=21 - Lighthouse shows 3.7s for LCP on a mobile. with jQuery CDN responsible for 1.12 s of that time.

https://www.zencartdemo.com/index.ph...e=checkout_one -- Problems on this page deal with proper labeling of table cells and form fields. Probably with your loaded version of OPC. The actual checkout page has the same table and form problem along with an added color contrast problem for Shipping Address, Same as Billing? (Try #7b11df) and Redemption Code (Try #006120).


Mentioned before - https://www.zencartdemo.com/index.ph...roducts_id=154. You might want to find an image of some rope.

[dbltoe]

The first Shipping Address... on the initial Guest Checkout should be #6001B7.

The first Shipping Address... on the final Guest Checkout should be #7C1DD4.

The Redemption Code color should have been #1B6120

[chadlly2003]

The first Shipping Address... on the initial Guest Checkout should be #6001B7.

The first Shipping Address... on the final Guest Checkout should be #7C1DD4.

The Redemption Code color should have been #1B6120

I would be happy to make the changes. Can you be a little more specific. Not really that clear

[chadlly2003]

I would be happy to make the changes. Can you be a little more specific. Not really that clear

disregard i figured it out

[chadlly2003]

Looking really good.

https://validator.w3.org/nu/?doc=htt...artdemo.com%2F

https://jigsaw.w3.org/css-validator/...artdemo.com%2F

Unless you are changing the .cart-content font size when going mobile, you may want to jump it up to 16 px. Otherwise, it may be hard to read on mobile.

Other testers are complaining that you have set a min-height but not a min-width on stylesheet.css line 627. Also, the items are covered by stylesheet_zcustom.css on line 1256.

I understand that most folks know what the "hamburger" is for, but you need to have the same cursor change on hover as you do for the other icons in the header. I haven't really looked at mobile or tablet, but remember that there's no mouse involved, which means you have to use some other method to identify "tappable links".

Whether you go with one aria landmark or a landmark for each section of the opening window, it needs at least one.

It's not an error, but you might want to consider adding a closing icon at the bottom of the opening window to avoid having to return to the beginning to close the window.

jQuery CDN is really throwing a monkey wrench into page load. It's not really relevant with today's browsers but if you must, consider adding defer so pages can load much faster. With today's speed, making the customer wait for 3 seconds on a mobile phone is liable to lose them. https://www.zencartdemo.com/index.ph...products_id=21 - Lighthouse shows 3.7s for LCP on a mobile. with jQuery CDN responsible for 1.12 s of that time.

https://www.zencartdemo.com/index.ph...e=checkout_one -- Problems on this page deal with proper labeling of table cells and form fields. Probably with your loaded version of OPC. The actual checkout page has the same table and form problem along with an added color contrast problem for Shipping Address, Same as Billing? (Try #7b11df) and Redemption Code (Try #006120).


Mentioned before - https://www.zencartdemo.com/index.ph...roducts_id=154. You might want to find an image of some rope.

Give me a few days and I will make the changes you requested. I may have some questions.
The only problem is with OPC its not a core app. So to make those work with Siteimprove and Wave and pass all the compliance test I will have to edit the opc files. Let me see what i can come up with. Because I only created the css file so people could just slide that file in and have OPC look good on the redesign website

[chadlly2003]

Looking really good.

https://validator.w3.org/nu/?doc=htt...artdemo.com%2F

https://jigsaw.w3.org/css-validator/...artdemo.com%2F

Unless you are changing the .cart-content font size when going mobile, you may want to jump it up to 16 px. Otherwise, it may be hard to read on mobile.

Other testers are complaining that you have set a min-height but not a min-width on stylesheet.css line 627. Also, the items are covered by stylesheet_zcustom.css on line 1256.

I understand that most folks know what the "hamburger" is for, but you need to have the same cursor change on hover as you do for the other icons in the header. I haven't really looked at mobile or tablet, but remember that there's no mouse involved, which means you have to use some other method to identify "tappable links".

Whether you go with one aria landmark or a landmark for each section of the opening window, it needs at least one.

It's not an error, but you might want to consider adding a closing icon at the bottom of the opening window to avoid having to return to the beginning to close the window.

jQuery CDN is really throwing a monkey wrench into page load. It's not really relevant with today's browsers but if you must, consider adding defer so pages can load much faster. With today's speed, making the customer wait for 3 seconds on a mobile phone is liable to lose them. https://www.zencartdemo.com/index.ph...products_id=21 - Lighthouse shows 3.7s for LCP on a mobile. with jQuery CDN responsible for 1.12 s of that time.

https://www.zencartdemo.com/index.ph...e=checkout_one -- Problems on this page deal with proper labeling of table cells and form fields. Probably with your loaded version of OPC. The actual checkout page has the same table and form problem along with an added color contrast problem for Shipping Address, Same as Billing? (Try #7b11df) and Redemption Code (Try #006120).


Mentioned before - https://www.zencartdemo.com/index.ph...roducts_id=154. You might want to find an image of some rope.

I believe the jquery can be removed from the template.

path: common/html_header.php

i can edit out this line

<script src="https://code.jquery.com/jquery-3.7.1.min.js" integrity="sha256-/JqT3SQfawRcv/BIHPThkBvs0OEvtFFmqPF/lYI/Cxo=" crossorigin="anonymous"></script>
<?php if (file_exists(DIR_WS_TEMPLATE . "jscript/jquery.min.js")) { ?>
<script title="jQuery check - template">window.jQuery || document.write('<script src="<?= $template->get_template_dir('.js',DIR_WS_TEMPLATE, $current_page_base,'jscript') ?>/jquery.min.js"><\/script>');</script>
<?php } ?>
<script title="jQuery check - template_default">window.jQuery || document.write('<script src="<?= $template->get_template_dir('.js','template_default', $current_page_base,'jscript') ?>/jquery.min.js"><\/script>');</script>

Since there are no modules installed on the demo template except opc. I believe i can safely remove this. Though how does this impact if people start downing other modules and need jquery in the template? What are your thoughts. i am going to do some test not 100% sure about this

[dbltoe]

Since there are no modules installed on the demo template except opc. I believe i can safely remove this. Though how does this impact if people start downing other modules and need jquery in the template? What are your thoughts. i am going to do some test not 100% sure about this

You will find CDN in the core, but it is generally along side a self-hosted jQuery just in case CDN is down. You can Google Plain jQuery vs jQuery CDN for a more detailed explanation of the differences. There are some advantages, but with e-commerce in mind, the security problems make it a no-no for me.

The only real option any mod developer has in this type of situation is to put a mention in the readme.

But, as many a developer will point out, the shrink wrap is hardly ever broken on a mod's instructions until there's a problem, they complained on the forum, and the developer pointed them to the appropriate spot in the readme/docs.

[lat9]

Re: removing jQuery

There are a bunch of plugins (many that I've offered) that require jQuery for their proper operation; the now in-core POSM being one.

[chadlly2003]

Re: removing jQuery

There are a bunch of plugins (many that I've offered) that require jQuery for their proper operation; the now in-core POSM being one.

I figured that. Best to be left as is