Tabbed Products ''LITE'' version - Delimiter based

[mrmarcus66]

Do I need to create a div container or can I adjust one of the tags in the stylesheet_tablitev2.css stylesheet?

[qhome]

Do I need to create a div container or can I adjust one of the tags in the stylesheet_tablitev2.css stylesheet?

That would be a custom layout for your site so it would need to be another div.. or a wrap a table around the tabs table and attribs and put the tabs in one TD and the Attribs in another TD.

[qhome]

OK. I fixed the bug and added the features I mentioned above.

The new file has been added to the downloads section (version 2.7 now). The download is under the Template category btw.

(Gotta wait till the mods approve it)

This should probably be the last update for a while so if you were gonna merge changes into this.. now would be the best time.

[Woodymon]

Really? I thought I made it easier with 2.6. Well to save you the trouble you should probably hold off until the next patch release.

My apologies. My compare application reported change warnings when it identified all the new comments and the new space indents. I printed out code and walked through the logic and found everything is good.

But I see you have made v. 2.7 available so I will go that route.

Several questions:

The new code is commented with "Core Features Tabs" and "Core Contents Tabs". Can you breifly explain the terminology?

Will the new tabs configuration impact how search engines spider/index the product description data.

Wondering if using CSS would be better approach than the new table html code added into the code?

(Sorry if I am showing too much curiosity/ignorance with my questions).

Thanks, Woody

[qhome]

The new code is commented with "Core Features Tabs" and "Core Contents Tabs". Can you breifly explain the terminology?

The "CORE" parts refer to the "Additional Images", "Product Details", "Customers Also Purchased", and "Add to Cart". As those are tabs for core modules, and not something custom.

Will the new tabs configuration impact how search engines spider/index the product description data.

New tabs do not change anything with the spidered html. Also see answer to next question....

Wondering if using CSS would be better approach than the new table html code added into the code?

The reason I used the table tags was used to implement a similar design as the tab switcher design so that if Jscript is turned off, it shows all the content in each section as a whole. The tables really aren't needed, and I dont necessarily implement them the way Tab Switcher uses them as I dont colorize the background or use borders. I mainly used the table tags for keeping things separate so if you don't add <br> code between tag delimiters, it doesn't run into the next section. It was more of a protection from having to make the user work more and think about it. So it was meant to make things easier.

There is one table I added for the Add To Cart inside the tabs to make sure that it didn't overlap the main image and get out of line. So that one is necessary.

Also, referring back to spiders. The spiders can be sure to see all data as it would also ignore the <!-- tags for html.

Hope that clears it up.

[Woodymon]

I installed v.2.7. I found the page renders fine all the way down to the tabs. However the tab pane now extends to the right margin, and my left column is entirely pushed down to below the tabs and below where "also purchased products" might be displayed (if I had enabled).

If it matters I do not have any "additional images" or any "product details" (qty/weight/model/manuf) to display and display of "also purchased products" is disabled.

And for now I choose to display the "Add to Cart" button below the tabs (default positioning)

Possibly a missing closing div tag or something to do with new table html in the new 2.7 code?

Anyone else observing such?

Note I am using the Future Zen template as basis of my template. But this phenomena did not happen with v2.4 installed.

With the very long tab indents (to help show nested if elses), creating wrapping of long code structures, it is a bit difficult to walk through the code (at least on a 17" monitor or printed on paper). Not a complaint mind you. Just a comment on my working evironment. ;)

BTW what is the standard number of spaces used for tab idents in PHP coding? Or more specifically used/recommended by the Zen Cart dev team for consistency?

Thanks, Woody

[qhome]

I installed v.2.7. I found the page renders fine all the way down to the tabs. However the tab pane now extends to the right margin, and my left column is entirely pushed down to below the tabs and below where "also purchased products" might be displayed (if I had enabled).

If it matters I do not have any "additional images" or any "product details" (qty/weight/model/manuf) to display and display of "also purchased products" is disabled.

And for now I choose to display the "Add to Cart" button below the tabs (default positioning)

Possibly a missing closing div tag or something to do with new table html in the new 2.7 code?

Anyone else observing such?

Note I am using the Future Zen template as basis of my template. But this phenomena did not happen with v2.4 installed.

With the very long tab indents (to help show nested if elses), creating wrapping of long code structures, it is a bit difficult to walk through the code (at least on a 17" monitor or printed on paper). Not a complaint mind you. Just a comment on my working evironment. ;)

BTW what is the standard number of spaces used for tab idents in PHP coding? Or more specifically used/recommended by the Zen Cart dev team for consistency?

Thanks, Woody

In 2.6 I did a decent job of indenting and usually use 4 ... depending on my mood I may also use 2.. but I usually try to stay consistent within each project. Some of the stuff added to 2.7, I use a deep indent just for my sandbox to help separate code while I work on it.. i didn't reset the indents after working on 2.7.


I will take a look at it the tags to see if i missed one.

[qhome]

I installed v.2.7. I found the page renders fine all the way down to the tabs. However the tab pane now extends to the right margin, and my left column is entirely pushed down to below the tabs and below where "also purchased products" might be displayed (if I had enabled).

If it matters I do not have any "additional images" or any "product details" (qty/weight/model/manuf) to display and display of "also purchased products" is disabled.

And for now I choose to display the "Add to Cart" button below the tabs (default positioning)

Possibly a missing closing div tag or something to do with new table html in the new 2.7 code?

Found the bug! Had an If statement closing tag closed too early. Here is the fix:
(just move the closing bracket below the echo statments.)

FIND (Around line 458):

}
echo '</td></tr></table>';
echo '<br /></div>';
$a++;

REPLACE WITH:

echo '</td></tr></table>';
echo '<br /></div>';
$a++;
}

Also, I found a typo I made on line:

Line: 672

$bCustomerAlsoPurchased should be $bCustomersAlsoPurchased

I've attached the fixed tpl file by itself here. I've also uploaded a 2.7a release in the contribs section.

Thanks for lookin out Woody :)

[Alik]

Is there a way to change the font color on tabs ?
i need to make the grey font on unfocused tabs diff. color. ?

[Woodymon]

Found the bug! Had an If statement closing tag closed too early. Here is the fix: (Around line 458)...(just move the closing bracket below the echo statments.) Also, I found a typo I made on line: Line: 672

Very quick and good with your bug fix! All better now. Thanks! I printed the file out and combed thru code with a highlighter ensuring all opening/closing tags for divs, table/tr/td, and nested ifs were properly matched. And all came up fine. I don't think I would have found the logic error. Thanks again.

I need a PHP editor/debugger/developer framework. I understand the Zen Cart devs use Zend Studio. That may be more than I need. But maybe not? What do you recommend?

Woody