Tabbed Products ''LITE'' version - Delimiter based

[Woodymon]

Just downloaded v.2.7a. Besides the two reported diffs between v2.7a and v2.7, I note one other diff which was not previosuly reported. Looks insignificant, but just checking.

2.7 line 476 shows:
echo '</div>'; //ditch-tab-pane-wrap

2.7a line 476 shows:
echo '</div id="duh">'; //ditch-tab-pane-wrap

- Woody

[qhome]

BWAHAHA! that was my way of finding out which div was which lol! When I was trying to find the problem with the table ending, I was trying to see how many times it looped through so I put that little identifier on there

I'll remove it and fix that <? tag for the next version.

I'll also take a look at cross sell. It should be pretty easy to make it a tab and Ill try to document how I do it.

[qhome]

CrossSell added to tabs in 10 steps :)


DEMO: http://www.unbannable.com/zen/index....&products_id=1

Attached a zip.. inside has 10 steps to adding the CrossSell Contrib as a tab. These 10 steps can also be a template to follow for adding any others.

Also included the completed tpl file for those who don't want to take the time adding those steps by themselves.

(Also fixed the <? and duh bugs mentioned above)

Thanks guys!

[ericpeng]

Is this a bug?
In admin panel - product description :

<!--%Product Description%-->
Line1
<!--%Extra Specs%-->
Line2

The 'Extra Specs' tab won't work.(left hand side bottom - error on page.)
But if I add <!--#AdditionalImages#--> to the bottom, then it works fine.

------------------

This is a great contribution, it makes the website looks much much better.
I just think if the tab could be apeared in admin panel(WYSIWYG), it'll be perfect.

Thank you
ERIC

[qhome]

Is this a bug?
In admin panel - product description :

<!--%Product Description%-->
Line1
<!--%Extra Specs%-->
Line2

The 'Extra Specs' tab won't work.(left hand side bottom - error on page.)
But if I add <!--#AdditionalImages#--> to the bottom, then it works fine.

Hmm Im trying this on my demo site and its working fine with and without the <!--#AdditionalImages#--> tag. can you post or PM the full description you are using that doesn't work.

This is a great contribution, it makes the website looks much much better.
I just think if the tab could be apeared in admin panel(WYSIWYG), it'll be perfect.

It originally was. There is a TabbedProducts nonlite version that creates a whole new product type. But that requires a database field to be added for each tab you want. And it was too hard to customize.. thats why I switched to the this "tag" method so it could be done on a per-product level.

[qhome]

ECKK.. i see it now. I removed the text before the tabs and i see the problem you are having now.. crraaaaappp

Ok ill take a look.. you can blame woodymon for needing all these extra features (LOL j/k) :)

[ericpeng]

[QUOTE=qhome]Hmm Im trying this on my demo site and its working fine with and without the <!--#AdditionalImages#--> tag. can you post or PM the full description you are using that doesn't work.

I tried again and same problem.

<!--%Product Description%-->
Detailed Product Description
512M Memory
<!--%Test%-->
This is another tab named test

That's all I have in products description.

[qhome]

Is this a bug?
In admin panel - product description :

<!--%Product Description%-->
Line1
<!--%Extra Specs%-->
Line2

The 'Extra Specs' tab won't work.(left hand side bottom - error on page.)
But if I add <!--#AdditionalImages#--> to the bottom, then it works fine.

FIXED:

FIND (TWICE!!) :

if (($chkTabStart && $chkTabEnd) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased)) {

REPLACE WITH (TWICE!!) :

if (($chkTabStart >= 0 && $chkTabEnd >= 0) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased) {

I was using absolute string value check.. but if the tags weren't used, it sets the value of the chktabstart and end to -1 which is infact a real value...

Thanks eric :)

[ericpeng]

FIXED:

FIND (TWICE!!) :

if (($chkTabStart && $chkTabEnd) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased)) {

REPLACE WITH (TWICE!!) :

if (($chkTabStart >= 0 && $chkTabEnd >= 0) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased) {

I was using absolute string value check.. but if the tags weren't used, it sets the value of the chktabstart and end to -1 which is infact a real value...

Thanks eric :)

I changed on Line# 261 and Line# 415 and it works.
Thank you so much.
I think change the line #133 to <br class="clearBoth" /> will be a good idea(in case of big prodcut image).

Thansks again
ERIC

[denliv]

FYI - don't know if you've noticed this yet (haven't read the whole thread) but the first tab fits nicely in a small browser width but going to the second tab makes it jump off the right side of the screen.