thxOk. I add my edits to your version :)
I tested it myself, but I admitt that that's not a 100% guarantee that it's bugfree ;-)
The purchase price and margin are totally optionally, so I guess testing that part is not really required. It works, but by default it's off, since I guess most people do not want/need it and adding the extra columns into their databases would be a waist then (no sample sql is included yet to add those two columns).
One of the small (but many edits) modifications was converting " to ' and \" to "as much as possible. I think it makes the code easier to read and edit, and following the "Zen coding standards" better.
And currently the styles are in document, but I guess it would be better to move those to a separate stylsheet file (as well as the js?).
Thanks for the essential, great mod!
Two points; first is that it still says it is version 1.3
Second, a feature request! How would I (or could someone) add the "sort order" to the list of columns?
Two points;Yeah I noticed that just after uploading.....first is that it still says it is version 1.3![]()
Hmmm.... might be nice, but not something I will add soon. It reminds me though that I wanted the ability to change the default sort order for the products (or remember the last selected sort order, which should be quite easy I think, I forgot to add it with the last update). My default would be descending on products_id then, showing the latest added products at the top.How would I (or could someone) add the "sort order" to the list of columns?
edit:
Just to get this clear: I understand you want to sort the columns (while my above rambling is about the sort order of the products themselves).
To set the default products sort order to descending on products_id (= new products on top) change:
To:Code://// control string sort page if ($sort_by && !ereg('order by', $sort_by)) $sort_by = 'order by ' . $sort_by ;
(Sorting the columns would involve a lot more changes BTW)Code://// control string sort page if ($sort_by && !ereg('order by', $sort_by)){ $sort_by = 'order by ' . $sort_by ; }else{ $sort_by = 'order by ' . 'products_id DESC' ; }
Thanks, but I didn't explain myself clearly!
I meant, the sort order of the products themselves.
So, for example, supposing I had a category that sold, say, venereal diseases*, and I wanted to group herpes, Chlamydia and syphilis together, but have AIDS, Hepatitis and gonorrhoea also in the same cat, but grouped together, I'd give them a sort order of, say 100,150,200 400,450,500. But having to do this in each product takes a LOT of time!
(*Guess who's just given his 17th blood donation and knows the safety leaflet off by heart, AND wants to improve his spelling! :)
![]()
Now I get it, and no it's not a current feature. Maybe Andrew will add it, while he is working on the module anyway ;-)
I think it would not be very difficult to add, but I do not know from the top of my head where these sort orders are stored, so it might be more complicated than I think atm.
v1.3.6 13.10.2006 5:03
1. Rename files:
/admin/includes/extra_datafiles/qucik_updates_filenames.php ->
/admin/includes/extra_datafiles/quick_updates.php
/admin/includes/languages/english/extra_definitions/quick_update_english.php ->
/admin/includes/languages/english/extra_definitions/quick_update.php
2. Add some edit features;
3. Add sort order column.
Download and test.
Hi Andrew,
I hope to test your new version soon. My version is currently diverting form the public one, because I need to add specific code to import data form a wholesaler website. Maybe I will try to run two versions to be able to use it like I want and still keep things synchronized with the public version.
I do have an improvement for the margin calculations. Originally the marginUpdate was only done on purchase price, but it appears to be very easy to change it to update on products_price and ex and including tax as well. It's a very small code change but a big improvement in usability thmo.
I also removed the "lock" form the specials myself. I think marking it as special is nice and handy, but disabling the field is *not* very handy sometimes. Or is it just me? And should we leave it disabled?
Bookmarks