Google Checkout module for ZC 1.3.x (beta)

[BlessIsaacola]

Here is mine line 145-157 with the code implemented:

<?php
    if (sizeof($selection) > 1) {
      if($selection[$i]['id'] == "googlecheckout")
        continue;
        if (empty($selection[$i]['noradio'])) {
 ?>
<?php echo zen_draw_radio_field('payment', $selection[$i]['id'], ($selection[$i]['id'] == $_SESSION['payment'] ? true : false), 'id="pmt-'.$selection[$i]['id'].'"'); ?>
<?php   } ?>
<?php
    } else {
        
?>
<?php echo zen_draw_hidden_field('payment', $selection[$i]['id']); ?>

[Woodymon]

Hi Ropu-

I assume most folks in the Zen Cart community assume that when a new mod or mod update is released it supports (and/or is based upon core code from) the latest version iof Zen Cart, unless clearly stated otherwise.

And I was previously understanding your mod was updated to support Zen Cart 1.37.

However while comparing the template override files included with v.1.3RC1rev1 of your mod, with the same files in the stock Zen Cart 1.37 distribution, I discovered the three files bundled in your mod are edits of an OLDER Zen Cart version (possibly 1.36), not based on the latest Zen Cart 1.37 version as one would expect.

The result is some newer functionality/features supported by Zen Cart 1.37 are not available if the template override files in your mod are utilized.

Best practice is to make clear in the readme which Zen Cart version your override or edited core files are based upon, and just as important, which Zen Cart version your merge (Option B) instructions are intended for. This will prevent much confusion.

For instance compare the following three files:

1. includes/templates/template_default/templates/tpl_login_default.php

Zen Cart 1.37 Stock shows:
* @version $Id: tpl_login_default.php 5419 2006-12-28 05:56:39Z drbyte $

GC mod v.1.30rc1rev1 shows:
* @version $Id: tpl_login_default.php 2834 2006-01-11 22:16:37Z birdbrain $


2. includes/templates/template_default/templates/tpl_shopping_cart_default.php

Zen Cart 1.37 Stock shows:
* @version $Id: tpl_shopping_cart_default.php 5414 2006-12-27 07:51:03Z drbyte $

GC mod v.1.30rc1rev1 shows:
* @version $Id: tpl_shopping_cart_default.php 4140 2006-08-15 03:37:53Z drbyte $


3. includes/templates/template_default/templates/tpl_checkout_payment_default.php

Zen Cart 1.37 Stock shows:
* @version $Id: tpl_checkout_payment_default.php 5414 2006-12-27 07:51:03Z drbyte $

GC mod v.1.30rc1rev1 shows:
* @version $Id: tpl_checkout_payment_default.php 4332 2006-09-01 04:33:16Z ajeh $

Maybe you could re-release your mod with template files based on Zen Cart 1.37?

Just some ideas to keep in mind in future development efforts.

But you did use the latest version of /admin/orders.php.

Thanks,
Woody

[BlessIsaacola]

Woody,

By ropu's own admission here: http://www.zen-cart.com/forum/showpo...&postcount=951 only admin/orders.php was based on zcv1.3.7. I am sure he will probably update the templates to be zcv1.3.7.

There are a lot of people that have problem because PayPal Express checkout was introduced in zcv1.3.7 and the fact that the templates are based on zcv1.3.7 creates some issues for people not merging code but just overriding templates.

In the interim, if anyone the templates based on zcv1.3.7 I'd gladly provide mine.

[Woodymon]

This has been discussed in previous posts. The reference in the install instruction is actually wrong. Ropu was using a different template than 1.3.7 when that instruction was written and obviously it hasn't been changed. If you want me to email you my tpl_checkout_payment_default.php for comparison I can do that.

Thanks for the info Isaac. My assumption was that would have been fixed in the latest release. Generally before installing a mod I don't read further back in the support thread, further than when the latest version was released. (Unless I'm having issues comprehending the install instructions). The assumption is little things like this would get corrected in the very next release version. Requiring anyone to wade through a thread of a 1000 posts to find out such information is not warranted.

Also, know of the template files are different since version 1.0.5 so if you have a working template with the code changes that is already based on ZC V1.3.7 you're good.

Not sure exactly what you mean here? I have a stock Zen Cart 1.37 I'm testing this mod out on (so I'm installing the mod fresh, not upgrading the mod). And I'm hand merging in the code following Option B instructions in the install readme. So are you now stating I should not follow those guidelines? Egads. I thought this was going to be straight forward, editing four files with five simple snippets of code.

See in my latest post that I found the package still contains older template files.

So I guess it is best that I wait for ropu to release Zen Cart 1.37 template edit instructions.

FYI, I no longer directly upload modified Zen cart files (template overrides or otherwise) provided in a mod package. I've been burned too many times doing it that way. My policy now is to manually compare and manually merge ALL mods and custom code released by anyone (except for Zen Cart dev team releases). And I will never, ever again install a Zen Cart mod on a production server, without first testing on a fresh STOCK Zen Cart installation on a test server. Doing this takes a little more upfront, but almost always saves time and hair-pulling frustration down the road. And you learn more about the mod code which helps in later troubleshooting and with upgrade issues.

Woody

[BlessIsaacola]

Woody,

I completely agree with you that this should have been fixed. What I meant by saying that no changes in the template file since 1.0.5 was simply to say if you already installed any version prior to this with the changes made to your zcv1.3.7 you shouldn't have to change the template files again.

However, if this is a new install on zcv1.3.7 that have not been modified, you will have to apply the changes to the 4 files. Sorry for the confusion. I need to sleep, I have been up for 26 hours.

I just got done dealing with uninstalling ultimate seo url...I think I am staying away from that mod for a long time (even though I contributed towards funding it) Okay, that's a different thread :)

[Woodymon]

By ropu's own admission only admin/orders.php was based on zcv1.3.7. I am sure he will probably update the templates to be zcv1.3.7.

There are a lot of people that have problem because PayPal Express checkout was introduced in zcv1.3.7 and the fact that the templates are based on zcv1.3.7 creates some issues for people not merging code but just overriding templates.

Darn. Some how I missed tj1's post and ropu's follow-up regards to the old template files. Thought I read everything in this thread since the release before installing. Wasted much time documenting the issues I was observing and posting my findings. Argh.

Yes most of the new code in the three 1.37 template files has to do with PayPal Express but some does not. Anyway, although this mod is still beta (or RC which is beta+), I would rather see just a little additional quality control in the releases, rather than the rush to release. Might prevent lots of hair pulling and keep this thread shorter. Not criticizing just an observation from someone who has lost lots of hair while testing out various permutations of this mod since October.

I need an aspirin or three now. Thanks again for the helpful info Isaac. Have a nice rest. zzzzz

Woody

[BlessIsaacola]

Darn. Some how I missed tj1's post and ropu's follow-up regards to the old template files. Thought I read everything in thread since the release before installing. Wasted much time documenting the issues I was observing and posting my findings. Argh.

Yes most of the new code in the three 1.37 template files has to do with PayPal Express but some does not. Anyway, although this mod is still beta (or RC which is beta+), I would rather see just a little additional quality control in the releases, rather than the rush to release. Might prevent lots of hair pulling and keep this thread shorter. Not criticizing just an observation from someone who has lost lots of hair while testing out various permutations of this mod since October.

I need an aspirin or three now.

Woody

Woody,

You have great observations and your contribution to the community is excellent. Personally, I enjoy reading your posts because they are always very thorough and you put so much time and effort into your posts to make them value added.

I was actually telling my wife about you the other day that you remind me so much of a lady I used to work with because of your attention to details. I was actually thinking that you must be a certified quality assurance person :)

Thank you for all you do to make this community a better place. Now if you can just fix all my problems with various mod, you'd be....

[Woodymon]

Question: Does anyone have a login template file supporting ZC 1.37 built-in "split-login" functionality and customized for Google Checkout working?

My edit of the ZC 1.37 /includes/templates/YOUR_TEMPLATE/templates/tpl_login_default.php did not go so well so Google Checkout image not displaying on login page. Then I recalled I had Zen Cart 1.37 "split-login" feature enabled which may be a problem. So I uploaded tpl_login_default.php that comes with the mod and I observed the GC image, but of course everything (the ZC login form, ZC registration form and GC image/link) is jammed onto one single page. Too difficult to navigate and absorb all info on one page.

When I last tested GC, on a ZC 1.36 shop, I put together a custom split login page and made it work nicely with Google checkout. But with ZC 1.37 I would rather utilize 1.37's integrated split-login functionality, and then customize for Google Checkout, as necessary.

But before I attempt to resurrect my login template for ZC 1.36 and try to update it with 1.37 code, I thought best to ask if anyone here already has a working login template file based on ZC 1.37 which supports both "split-login" AND Google Checkout?

Thanks,
Woody

[BlessIsaacola]

Here is my tpl_login_default.php:

<?php
/**
 * Page Template
 *
 * @package templateSystem
 * @copyright Copyright 2003-2007 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: tpl_login_default.php 5523 2007-01-03 09:37:48Z drbyte $
 */
?>
<div class="centerColumn" id="loginDefault">

<h1 id="loginDefaultHeading"><?php echo HEADING_TITLE; ?></h1>

<?php if ($messageStack->size('login') > 0) echo $messageStack->output('login'); ?>


<?php if ( USE_SPLIT_LOGIN_MODE == 'True' || $ec_button_enabled) { ?>
<!--BOF PPEC split login- DO NOT REMOVE-->
<fieldset class="floatingBox back">
<legend><?php echo HEADING_NEW_CUSTOMER_SPLIT; ?></legend>
<?php // ** BEGIN PAYPAL EXPRESS CHECKOUT ** ?>
<?php if ($ec_button_enabled) { ?>
<div class="information"><?php echo TEXT_NEW_CUSTOMER_INTRODUCTION_SPLIT; ?></div>

  <div class="center"><?php require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/paypal/tpl_ec_button.php'); ?></div>
<hr />
<?php  include(DIR_WS_MODULES . 'show_google_components.php');  ?>
<hr />
<?php echo TEXT_NEW_CUSTOMER_POST_INTRODUCTION_DIVIDER; ?>
<?php } ?>
<?php // ** END PAYPAL EXPRESS CHECKOUT ** ?>
<div class="information"><?php echo TEXT_NEW_CUSTOMER_POST_INTRODUCTION_SPLIT; ?></div>

<?php echo zen_draw_form('create', zen_href_link(FILENAME_CREATE_ACCOUNT, '', 'SSL')); ?>
<div class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_CREATE_ACCOUNT, BUTTON_CREATE_ACCOUNT_ALT); ?></div>
</form>
</fieldset>

<fieldset class="floatingBox forward">
<legend><?php echo HEADING_RETURNING_CUSTOMER_SPLIT; ?></legend>
<div class="information"><?php echo TEXT_RETURNING_CUSTOMER_SPLIT; ?></div>

<?php echo zen_draw_form('login', zen_href_link(FILENAME_LOGIN, 'action=process', 'SSL')); ?>
<label class="inputLabel" for="login-email-address"><?php echo ENTRY_EMAIL_ADDRESS; ?></label>
<?php echo zen_draw_input_field('email_address', '', 'size="18" id="login-email-address"'); ?>
<br class="clearBoth" />

<label class="inputLabel" for="login-password"><?php echo ENTRY_PASSWORD; ?></label>
<?php echo zen_draw_password_field('password', '', 'size="18" id="login-password"'); ?>
<br class="clearBoth" />

<div class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_LOGIN, BUTTON_LOGIN_ALT); ?></div>
<div class="buttonRow back important"><?php echo '<a href="' . zen_href_link(FILENAME_PASSWORD_FORGOTTEN, '', 'SSL') . '">' . TEXT_PASSWORD_FORGOTTEN . '</a>'; ?></div>
</form>
</fieldset>
<br class="clearBoth" />
<!--EOF PPEC split login- DO NOT REMOVE-->
<?php } else { ?>
<!--BOF normal login-->
<?php
  if ($_SESSION['cart']->count_contents() > 0) {
?>
<div class="advisory"><?php echo TEXT_VISITORS_CART; ?></div>
<?php
  }
?>
<?php echo zen_draw_form('login', zen_href_link(FILENAME_LOGIN, 'action=process', 'SSL')); ?>
<fieldset>
<legend><?php echo HEADING_RETURNING_CUSTOMER; ?></legend>

<label class="inputLabel" for="login-email-address"><?php echo ENTRY_EMAIL_ADDRESS; ?></label>
<?php echo zen_draw_input_field('email_address', '', zen_set_field_length(TABLE_CUSTOMERS, 'customers_email_address', '40') . ' id="login-email-address"'); ?>
<br class="clearBoth" />

<label class="inputLabel" for="login-password"><?php echo ENTRY_PASSWORD; ?></label>
<?php echo zen_draw_password_field('password', '', zen_set_field_length(TABLE_CUSTOMERS, 'customers_password') . ' id="login-password"'); ?>
<br class="clearBoth" />
</fieldset>

<div class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_LOGIN, BUTTON_LOGIN_ALT); ?></div>
<div class="buttonRow back important"><?php echo '<a href="' . zen_href_link(FILENAME_PASSWORD_FORGOTTEN, '', 'SSL') . '">' . TEXT_PASSWORD_FORGOTTEN . '</a>'; ?></div>
</form>
<br class="clearBoth" />

  <!-- ** GOOGLE CHECKOUT ** -->
    <?php  include(DIR_WS_MODULES . 'show_google_components.php');  ?>
  <!-- ** END GOOGLE CHECKOUT ** -->

<?php echo zen_draw_form('create_account', zen_href_link(FILENAME_CREATE_ACCOUNT, '', 'SSL'), 'post', 'onsubmit="return check_form(create_account);"') . zen_draw_hidden_field('action', 'process') . zen_draw_hidden_field('email_pref_html', 'email_format'); ?>
<fieldset>
<legend><?php echo HEADING_NEW_CUSTOMER; ?></legend>

<div class="information"><?php echo TEXT_NEW_CUSTOMER_INTRODUCTION; ?></div>

<?php require($template->get_template_dir('tpl_modules_create_account.php',DIR_WS_TEMPLATE, $current_page_base,'templates'). '/tpl_modules_create_account.php'); ?>

</fieldset>

<div class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_SUBMIT, BUTTON_SUBMIT_ALT); ?></div>
</form>
<!--EOF normal login-->
<?php } ?>
</div>

[BlessIsaacola]

Hey Woody, I just realized I don't have the split login enabled so I am not sure if this is what you need or not but at least you can compare my file to your 1.3.7 file.