Sales report 2.0

[ARRSE]

Blindside,
I'd also like to offer you my thanks for a module that is now something I use on almost a daily basis (an addict ... moi!). I know you receive a lot of features requests but if you don't mind I'd like to offer a few of my own:

1. Multiple selection for Payment Method, Manufacturer and Current Order Status.

2. An option to show orders by discount code or code(s) used.

3. Finally I'd echo my support for a UK date format!!

Thanks for all the continued work.

[moktar]

Hello,

And I keep getting this error every few Rows..

<b>Warning</b>: Invalid argument supplied for foreach() in <b>/home/.cara/davestra/strandland.com/digitalstore/admin/includes/classes/sales_report.php</b> on line <b>908</b><br />

or this one...

<b>Warning</b>: array_multisort() [<a href='function.array-multisort?zenAdminID=4baf46482870f18dcf2411f16f568494'>function.array-multisort</a>]: Argument #1 is expected to be an array or a sort flag in <b>/home/.cara/davestra/strandland.com/digitalstore/admin/includes/classes/sales_report.php</b> on line <b>915</b><br />

or this one...

<b>Warning</b>: Invalid argument supplied for foreach() in <b>/home/.cara/davestra/strandland.com/digitalstore/admin/includes/classes/sales_report.php</b> on line <b>908</b><br />

I had the same warnings and found a fix that works on my install. I submit it here in case it is usefull to Dave or others. BlindSide, please review the fix and include it in next release if appropriate.

In admin\includes\classes\sales_report.php around line 857, find :

unset($dataset1, $dataset2);
foreach($timeframe['orders'] as $oID => $o_data) { 

Add this line after the unset line:

if (!is_array($timeframe['orders']) ) continue; 

In the CSV output, I also had blank lines between different days with daily timeframe. Here is the fix:

In admin\includes\classes\sales_report.php around line 903, find:

echo CSV_NEWLINE; 

and comment it (or remove):

//echo CSV_NEWLINE; 

[agamic]

I notice that when I use +order line Items that the tax is correct and shipping is also included, but using that method I can not sort by product as I can using the +product line Items. My point is that Im hoping that the answer to the miscalculated tax and lack of shipping lies in the +order line item as it seems to be fine.

I was wondering whether there was a fix for this as I have just loaded the latest report mod running on 1.3.7 and the tax shows as $1 which is incorrect under the product line items filter but correctly at $2.97 under the orders filter.
Thanks Blindside for a great mod nevertheless.

[Mountain Mama]

Hello 'Blindside',

I am running the latest version of zen cart and have downloaded and installed your mod into the top level, as usual. When I go into the admin, I find sales report. When I click on it, I get a blank page. I have downloaded your mod twice and reinstalled it. Everything seems in order.

I am running a local apache webserver on my laptop.

Any ideas? Thank you!

[Stevietheman]

Hello 'Blindside',

I am running the latest version of zen cart and have downloaded and installed your mod into the top level, as usual. When I go into the admin, I find sales report. When I click on it, I get a blank page. I have downloaded your mod twice and reinstalled it. Everything seems in order.

I am running a local apache webserver on my laptop.

Any ideas? Thank you!

Check out my recent previous posts where I describe fixes you can apply. Maybe doing these fixes will work for you.

[Mountain Mama]

Hello Steve,

I tried them all, but still a blank page!

[conor]

Hi,

Just tried this module out this morning and it's pretty handy - thanks!

Being from Ireland, the date formatting issues were a little irritating, but they were extremely simple to fix.

For anyone from the UK/Ireland, this is all you need to change:

In admin/includes/classes/sales_report.php change lines 58 and 59 from:

      $this->sd_raw = mktime(0, 0, 0, substr($sd, 0, 2), substr($sd, 3, 2), substr($sd, 6, 4) );
      $this->ed_raw = mktime(0, 0, 0, substr($ed, 0, 2), substr($ed, 3, 2), substr($ed, 6, 4) ); 

to:

      if (strtolower(DATE_FORMAT) == 'm/d/y') {
        // Use US date format (m/d/Y)
        $this->sd_raw = mktime(0, 0, 0, substr($sd, 0, 2), substr($sd, 3, 2), substr($sd, 6, 4) );
        $this->ed_raw = mktime(0, 0, 0, substr($ed, 0, 2), substr($ed, 3, 2), substr($ed, 6, 4) );
      } else if (strtolower(DATE_FORMAT) == 'd/m/y') {
        // Use UK date format (d/m/Y)
        $this->sd_raw = mktime(0, 0, 0, substr($sd, 3, 2), substr($sd, 0, 2), substr($sd, 6, 4) );
        $this->ed_raw = mktime(0, 0, 0, substr($ed, 3, 2), substr($ed, 0, 2), substr($ed, 6, 4) );
      } 

And in admin/includes/english/stats_sales_report.php change lines 114-118 from:

define('TIME_DISPLAY_DAY', 'n-j-Y');
define('TIME_DISPLAY_WEEK', 'n-j-Y');
define('TIME_DISPLAY_MONTH', 'n-j-Y');
define('TIME_DISPLAY_YEAR', 'n-j-Y');
define('DATE_SPACER', ' thru<br/>&nbsp;&nbsp;&nbsp;'); 

to:

if (strtolower(DATE_FORMAT) == 'm/d/y') {
  // Use US date format (m/d/Y)
  define('TIME_DISPLAY_DAY', 'n-j-Y');
  define('TIME_DISPLAY_WEEK', 'n-j-Y');
  define('TIME_DISPLAY_MONTH', 'n-j-Y');
  define('TIME_DISPLAY_YEAR', 'n-j-Y');
  define('DATE_SPACER', ' thru<br/>&nbsp;&nbsp;&nbsp;');
} else if (strtolower(DATE_FORMAT) == 'd/m/y') {
  // Use UK date format (d/m/Y)
  define('TIME_DISPLAY_DAY', 'jS-M-y');
  define('TIME_DISPLAY_WEEK', 'jS-M-y');
  define('TIME_DISPLAY_MONTH', 'jS-M-y');
  define('TIME_DISPLAY_YEAR', 'jS-M-y');
  define('DATE_SPACER', ' to<br/>&nbsp;&nbsp;&nbsp;');
} 

Of course, the above is assuming that you have changed your admin/includes/language/english.php file to use:

define('DATE_FORMAT', 'd/m/Y');
define('DATE_FORMAT_SPIFFYCAL', 'dd/MM/yyyy'); 

Also, I've used jS-M-y as my preferred date output format... this affects the CSV output as well.

Some of you may prefer to use j-n-Y for more numerical formatting.. it's up to you (check PHP's date function documentation for more formatting options!).


Hope that is of help!


A note to blindside while I'm here...

First off, a great big thanks! :)

Secondly, the lines 693 and 1029 in the main stats_sales_report.php really need changing from <? to <?php - it seems silly to leave these as they are forcing users to have to make modifications.

Lastly, the comments in the Javascript should have the <?php and ?> tags removed from being around them, they result in parse errors here which causes the javascript to fail. Which is a pity because it makes it look as if the module doesn't work out of the box.

Thanks once again!


All the best...

Conor
ceon

[conor]

Hi,

Sorry, hadn't tested the above with a day of the month after the 12th so missed out on noticing that the javascript has to be updated also.

Again it's quite a simple change... if you've done the above, just change the following file as well in the manner described below:

admin/includes/javascript/sales_report.js.php

Change lines 427-429 from:

      if (isDate(sd_array[1], sd_array[0], sd_array[2]) &&
          isDate(ed_array[1], ed_array[0], ed_array[2]) ) {
          // the array is in mm-dd-yyyy format, but isDate needs it in dd-mm-yyyy 

to:

<?php
if (strtolower(DATE_FORMAT) == 'm/d/y') {
  // Use US date format (m/d/Y)
?>
      if (isDate(sd_array[1], sd_array[0], sd_array[2]) &&
          isDate(ed_array[1], ed_array[0], ed_array[2]) ) {
<?php
} else if (strtolower(DATE_FORMAT) == 'd/m/y') {
  // Use UK date format (d/m/Y)
?>
      if (isDate(sd_array[0], sd_array[1], sd_array[2]) &&
          isDate(ed_array[0], ed_array[1], ed_array[2]) ) {
<?php
}
?>

Wee buns!

Happy Easter Everyone!

Conor
ceon

[airtime]

I just installed Sales Report 2.0 on zc1.3.7. First on my test server. It went smooth and appeared to function perfectly. Then on my live server. It installed smooth, but the page is different with mission functionality. The 'sort product by' and 'then sort product by' are missing.
I've attached the two different screen shots.
Thanks,
Airtime.

[BlindSide]

I just installed Sales Report 2.0 on zc1.3.7. First on my test server. It went smooth and appeared to function perfectly. Then on my live server. It installed smooth, but the page is different with mission functionality. The 'sort product by' and 'then sort product by' are missing.
I've attached the two different screen shots.

Just change the "Displayed Information" dropdown; the additional options appear/disappear based on your selection in that box.