Order Editor 1.3.7 Issues

[sunflowertami]

Thanks! Your contribution is very valuable indeed and I hope that they will integrate it on the next version of zencart.

[srturner47]

Thanks sunflowertami. Just to be clear though -- I don't want to take credit where it is not deserved. I didn't write this mod. I've sort of taken it over because no one was updating it and there were lots of bugs, but I didn't write the original code.

redmonds - your issue has been solved. Still working on sunflowertami's problem, and a couple other annoyances I've noticed. Hopefully I'll get it released later this week. :)

[Decostyle]

Hi, Another input to this module. I recently installed this to a store that did not have COWOA. When I tried to update information and send to customer, I got this error:

1054 Unknown column 'COWOA_order' in 'field list'
in:
[select customers_name, customers_email_address, orders_status, date_purchased, COWOA_order from zen_orders where orders_id = '20']


So a quick edit to this is to go into orders.php and take out the field COWOA_order, there are two in line 54 and 91.

In case you are updating this module, it would be best to have a version with COWOA and without COWOA. Thanks!

[srturner47]

Hmmm... This mod doesn't have anything with COWOA in it. I searched the file. It appears you are searching in the orders.php file, which is part of Zen Cart, not the edit orders mod. The edit orders mod is in edit_orders.php.

Did you perhaps install and then uninstall COWOA and forget to remove instances from orders.php?

[spinnywoman]

I've now successfully installed this (thanks to Invision post #135). Or have I? When I go to Edit the order, it seems that the stylesheet flips out? Yes, I can Edit the order and amend the postage but I wonder if I have made a "fat finger" error somewhere? Does that make any sense?

[Decostyle]

Hmmm... This mod doesn't have anything with COWOA in it. I searched the file. It appears you are searching in the orders.php file, which is part of Zen Cart, not the edit orders mod. The edit orders mod is in edit_orders.php.

Did you perhaps install and then uninstall COWOA and forget to remove instances from orders.php?

Oops! yes you are right. Sorry about that. I did install COWOA then decided not to use it. Anyway if any one is in the same situation they now know how to fix it!

[srturner47]

spinnywoman -- make sure all files are in the right directories.

[stevenh76]

Hi srturner47, appreciate your work! It's a great mod.

I'm using version 1.5.3, but still have problems on the calculation of the shipping tax and group discount.

The shipping tax problem has been mentioned in some previous posts, but I didn't find the fix to that. The shipping fee is hard coded in edit_orders.php

  $AddShippingTax = "0.0"; // e.g. shipping tax of 17.5% is "17.5"

Since the shipping tax rate varies according to the shipping address, the shipping tax rate should be retrieved from the database when needed.

The discount problem is also there. When edit an order with group discount in order_total, the mod will add the discount to the total instead of subtracting it from the total. This seems to be easy to get fixed.

BTW, I have a problem making Edit Orders mod and SplitTaxLines mod compatible. SplitTaxLines separates taxes into several lines and saves them by several rows in table order_total with same type 'ot_tax'. When I edit orders, the sum of taxe rates will be applied to each line of tax. As a result, the total tax may be doubled or tripled or more according to the number of tax lines.

Please help me out. Thanks!

[srturner47]

stevenh76 --

I see what you mean about charging tax on shipping. I'm not quite sure how Zen Cart applies taxes to shipping, as I don't tax my shipping. But, I'll look into it.

As for the discount problem, I don't know what a group discount is. The only discounts I am aware of in Zen Cart are coupons and gift certificates. If there is another type of discount, I'd need to know what code Zen Cart uses to store it to fix this problem. Please go to phpMyAdmin in Cpanel, then find your database, and in that database find the table called "zen_orders_total". Click browse, then find a group discount line for an order. What is in the "class" field? The only two class fields that this mod subtracts for are ot_gv for gift certificates and ot_coupon for coupons. If you can give me the class code for group discounts, I can easily fix this problem.

As for the SplitTaxLine mod, it would be very difficult to make this mod compatible with the SplitTaxLine mod. Figuring out how taxes were split up and then duplicating this effort when an order is edited would be exceeding difficult as Zen Cart doesn't store any information about why taxes were added. The mod assumes you only have one tax line per order, which is Zen Cart's usual behavior without the SplitTaxLine mod. There really is no easy way to fix this. Sorry.

[stevenh76]

Hi srturner47, thanks for replying my questions so quick!

I'm working on the shipping tax also. Please keep me updated.

For the discount problem, the class of group pricing is ot_group_pricing. You can set group pricing info at "Customers>Group Pricing", which allows you to define different discount groups for your customers. And then, when editing customers's profile under "Customers>Customers", you can assign one of the discount group to your customer, so that they will always get that discount on their purchases. I guess this problem is easy to fix.

And for the SplitTaxLines mod problem, I had no clue on how to get the two mods compatible either. Finally, I've left SplitTaxLine aside. Since I don't wanna touch the core logic, I wrote some code to split the tax only when display. The taxes are manipulated and stored as it is. When displaying the tax, I just parse the title of the tax, if it's combined by several taxes, I split the title and the value and then display it in lines. In my store, the title combined by multiple taxes always appears like "5% GST #00000 + 8% PST(Ontario):". Several code blocks relating to tax display are modified. This may cause some trouble when upgrading or adding new mod. It's not decent to get this problem fixed like this, but at least I get it done in my case and it's in rush. So I don't recommend this solution to those who have the same problem. Anyway, if I have time later on, I'll try to find a better way to split the taxes.

Cheers

Steve