Order Editor 1.3.7 Issues

[Decostyle]

Great work! Looking forward to it!

[srturner47]

I ended up doing a lot more with this than I originally intended. I've always wanted to implement a better system for handling attributes, and I've done that, as well as fixing the myriad of options that attributes have. Essentially, you can now select an attribute from a pull-down menu and any changes to the price will automatically be made. This took a boat load of new code, as there are a ton of options that Zen Cart has for attributes. Most of these options I've never used, so it took some exploration to learn what they do. Anyway, I think I've fixed them all, implemented the new attribute system, and addressed all other bugs and issues people posted. The code base grew tremendously, so I've tagged this as 2.0.

I've decided to release this exclusively through my website -- see the link in my signature below. It is still completely free (both as in beer and as in freedom), just change the options on my site to the free ones and complete the checkout process. You can always update later by simply logging in and redownloading.

Here is the changelog:

v 2.0 10/15/2008 - Scott Turner
1. Implemented new attributes handling in the following ways:
a) In addition to the more complicated attribute editor, a simpler option is available.
i) Select a new attribute from a drop-down menu in admin.
ii) The new price will be automatically calculated by subtracting the old attribute price and adding the new attribute price.
b) Text attributes now are implemented through a text box.
c) Fixed attribute pricing for the following scenarios:
i) One Time Charges Implemented
ii) Price Factor & Offset Implemented
iii) One Time Price Factor & Offset Implemented
iv) Attributes Qty Price Implemented
v) One Time Attributes Qty Price Implemented
vi) Price Per Word & Free Words Implemented
vii) Price Per Letter & Free Letters Implemented
viii) Specials and Sales Implemented for Attributes When Option is Selected for Attribute
d) Product one time charges are easily editable.
e) You can switch back and forth between the old advanced attribute editor and the easier one using a text-link.
i) The advanced attribute editor allows you to change the price and attribute option and value manually.
ii) The simple attribute editor allows you to choose from the attributes listed in your database.
iii) The advanced attribute editor will not update prices -- it leaves you to do this.
iv) The simple attribute editor updates prices automatically.
v) The simple attribute editor is the preferred method of altering attributes! The advanced is useful for advanced purposes.
f) Downloads are now implemented correctly and will change automatically when using the simple attribute editor.
g) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when an attribute option is changed using the simple attribute editor.
2. Adding products has added a few new features.
a) You can choose whether or not new products use the special or sales price.
b) Text attributes now work with a text box.
c) Many new attribute options are implemented correctly when calculating the price for new products. See 1-c for more info.
d) Downloads are now implemented correctly.
e) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when a new product is added with an attribute.
3. Coupon and group discounts now calculate correctly with taxes. To do so, the mod uses your average tax rate for all the products that were purchased.
4. Fixed problem with quantity discounts adding to total instead of subtracting.
5. Changed behavior so that clicking "details" on the order screen will give you the original edit orders page that Zen Cart has built in.
a) This allows you to choose which page you want to use. Click "details" for just the basics. Click "edit" to make some changes to an order.
6. Fixed problems with data in TABLE_ORDERS_PRODUCTS not updating includng products_price, products_tax, and final_price.
7. You can now enter a value for shipping taxes and this will calculate correctly. Zen Cart doesn't store this info in the database, so this must be changed every time when editing orders. A compromise, but better than nothing.
8. Added lines for edits to orders.php per popular demand on Zen Cart forums.

Enjoy!

[smpeters]

when i click the add product link in the details page i am taken to the admin logon page. can anyone tell me why this is occuring?

[srturner47]

That is very strange. Check the link for the "Add Product" link. It should be for: /edit_orders.php?oID=(ORDERNUMBERHERE)&action=add_product&step=1

Also, try pasting that link directly into the address bar of your browser. Does it still go to the login page?

[redmonds]

Nice catch! :) I'll try to get a bug fix out for this -- hopefully later this week.

Good to see the update released and I can see a huge amount of work was done. I could not see any reference to the Bug I mentioned regarding not updating orders table. Was this fix implemented in the current release?

Also will the new package straight upload over the existing package?

Thanks
Redmonds

[srturner47]

Thanks redmond -- yes, this ended up being a big update. I didn't realize how many little details there were with attributes which could affect a product's price. I also didn't realize how many database entries that weren't mission critical were being ignored by the previous version.

Yes, I fixed that bug. And you are right, I forgot to add it to the changelog. Whoops!

And yes, just overwrite all the files from the previous version.

[redmonds]

Sturner,

Thanks for the update.

I have applied and tested the totals update as per my requirements and it does not appear to have been corrected. That is the Order_total & Order_tax fields are not being updated in the Orders table.

In doing the update I uploaded all of the additional files but did not edit the existing files which I presumed where only adding links to the edit_orders.php page.

It also appears as though the Tax component is not recalculating properly. The old version would recalculate GST including GST in the shipping amount. However the new module calculates GST only on the products and not the shipping. This means that the GST shown is incorrect.

I would love some assistance in fixing both of these issues as I find myself using this component more and more. Again many thanks.

Regards
Redmonds

[srturner47]

redmonds -- nice find! Yes, it appears I didn't completely fix the orders table updating. It will update just fine when using the "update" button, but adding a product won't update the orders table. I'll need to go back and fix this. Look for a new release with this fix in about 1 week (really a week this time -- I'm just going to fix this which should be pretty easy!). In the meantime, you can solve the problem by adding a product, and then clicking the "update" button without changing anything.

As for shipping tax, I don't quite understand how you were getting that behavior with the previous version. From my testing, and as reported by others on this thread, shipping taxes were never applied -- they were hard-coded as 0% in the source code. So, I added a box next to the shipping amount where you can enter a tax percentage. Unfortunately, Zen Cart doesn't store the tax rate for shipping on orders anywhere in the db, so you have to enter this tax rate every time you change an order.

If you charge a consistent tax rate to most or all of your customers, you can set the default tax rate in the source code. The default is currently set to 0%. Then, you just need to change the shipping tax rate when necessary. Look for the following line (I think its line 89) in the source code to do so:

$AddShippingTax = "0.0"; // e.g. shipping tax of 17.5% is "17.5"

Not the most elegant solution, but I thought it was better than the way it was implemented before, which was just to hardcode it as above without the option to change the shipping percentage in Zen Cart on an individual basis when needed. Unless Zen Cart starts recording the shipping tax rate for orders, this seems like the best way to handle this problem.

[spinnywoman]

Version 2.0 - thanks for a great add-on. Works perfectly. As I have the need to refund the difference in postage (from small packet down to letter) or change the attributes of a product (from an out of stock colour to one that is available!) this is a fantastic and truly useful modification. Thanks again!

[TrvlFox]

Just to confirm, this version of Order Editor works with 1.3.7? That hasn't changed, right? I'm going by the subject line.

Vicky