[Done v1.3.9] Discount groups and tax calc problem with tax-included pricing

[pupsandpets]

No worries, thanks for trying

[Crunch]

Directed here from the 1.3.8a bug fix thread...

This thread is a mess...

Is this the correct UPDATED code (being used in 1.3.9) for includes/modules/order_total/ot_group_pricing.php ???????

  function get_order_total() {
    global  $order;
    $order_total_tax = $order->info['tax'];
    $order_total = $order->info['total'];
    if ($this->include_shipping != 'true') $order_total -= $order->info['shipping_cost'];
    if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];
    if ($this->include_tax != "true" && $this->include_shipping != 'true') $order_total += $order->info['shipping_tax'];
    if ($this->include_tax != 'true') $order_total -= $order->info['tax'];
    $orderTotalFull = $order_total;
    $order_total = array('totalFull'=>$orderTotalFull, 'total'=>$order_total, 'tax'=>$order_total_tax);

    return $order_total;
  }

And shouldn't this thread have [Done v1.3.9] prefixed ?????

[DivaVocals]

Actually it wasn't much of a mess at all if you followed Wilt's posts and ignore all the other posts in tis thread (some of which don't appear to have followed all of Wilt's instructions) I followed Wilt's posts and made ALL the changes and mods he recommended in this thread since after his posted changes, the person reporting the issue verified that the application of his posts were what worked..:

http://www.zen-cart.com/forum/showpo...72&postcount=2
http://www.zen-cart.com/forum/showpo...24&postcount=4
http://www.zen-cart.com/forum/showpo...45&postcount=9

Directed here from the 1.3.8a bug fix thread...

This thread is a mess...

Is this the correct UPDATED code (being used in 1.3.9) for includes/modules/order_total/ot_group_pricing.php ???????

  function get_order_total() {
    global  $order;
    $order_total_tax = $order->info['tax'];
    $order_total = $order->info['total'];
    if ($this->include_shipping != 'true') $order_total -= $order->info['shipping_cost'];
    if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];
    if ($this->include_tax != "true" && $this->include_shipping != 'true') $order_total += $order->info['shipping_tax'];
    if ($this->include_tax != 'true') $order_total -= $order->info['tax'];
    $orderTotalFull = $order_total;
    $order_total = array('totalFull'=>$orderTotalFull, 'total'=>$order_total, 'tax'=>$order_total_tax);

    return $order_total;
  }

And shouldn't this thread have [Done v1.3.9] prefixed ?????

[swguy]

Same issue occurs with coupons; fixes posted here:

http://www.zen-cart.com/forum/showthread.php?t=150689

Scott

[Crunch]

The fix is to add this line

    if ($this->include_tax != "true" && $this->include_shipping != 'true') $order_total += $order->info['shipping_tax']; 

This should be added after the similar lines we changed earlier to adjuts the shipping tax.

I now get

Sub-Total:£100.00
Flat Rate (Best Way):£10.00
Group Discount:-£5.00
VAT 15%:£13.70
Total:£105.00

Which file do I add this line to (order, ot_shipping, ot-group_pricing) ? It's not clear to me. Thanks!

[swguy]

If you look at the thread

http://www.zen-cart.com/forum/showthread.php?t=150689

you will see all the required fixes summarized.

[Crunch]

you will see all the required fixes summarized.

Thanks!!! Exactly what I needed.