I'm on Zen-Cart 1.3.9d with Better Together Marketing 2.3 and thought I should share a small HTML tag compliance issue I found today in the following files:
includes\templates\CUSTOM_TEMPLATE\templates\tpl_better_together_marketing.php
includes\templates\CUSTOM_TEMPLATE\templates\tpl_better_together_marketing_image s.php
Inside the for loop, the php echo that generates the span tag has a double quote ( " ) in the closing span tag. See below:
tpl_better_together_marketing.php:
PHP Code:
for ($i=0, $n=count($marketing_data); $i<$n; $i++) {
echo '<div class="discountText">';
echo $marketing_data[$i]['data'];
echo '<span class="bbn_button_noimg">' . $marketing_data[$i]['bbn_string'] . '</span">';
echo '</div>';
}
tpl_better_together_marketing_images.php:
PHP Code:
for ($i=0, $n=count($marketing_data); $i<$n; $i++) {
echo '<hr />';
echo '<div class="discountText">';
echo $marketing_data[$i]['data'];
echo '</div>';
echo '<div class="discountImages">';
echo
$marketing_data[$i]['first_href'] .
$marketing_data[$i]['first_image'] . '</a>' .
'<span class="product_plus">+</span>' .
$marketing_data[$i]['disc_href'] .
$marketing_data[$i]['second_image'] . '</a>';
if (isset($marketing_data[$i]['bbn_string'])) {
echo '<span class="bbn_button">' . $marketing_data[$i]['bbn_string'] . '</span">';
}
echo '</div>';
}
The double quote needs to be removed as it causes formatting issues in the final DOM display that permeates through the balance of the page. Basically, it prevents the echo of the two closing div tags. Found this using the developer tools in IE8, viewed the source for the Page DOM and spotted the missing closing div tags.
Search for: and replace it with: BTW: Thanks to Software Guy for this great add-on.
Bookmarks