Image Handler 2 (for ZC v1.3.8 ONLY) Support

[nigelt74]

Ok Corrected version - sorry was having issues with browser caching


This isn't an image handler thing, it is to do with Zencarts support for accessibility

But any way, it appears IE8 supports the alt tag correctly (a mod couldn't dlete my last to posts please), by not showing an image hover.

Find your \includes\functions\html_output.php file make a backup of the file

around line 197

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
    $image = '<img src="' . zen_output_string($src) . '" alt="' . zen_output_string($alt) . '"';

    if (zen_not_null($alt)) {
      $image .= ' title=" ' . zen_output_string($alt) . ' "';
    }

and replace it with this

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
    $image = '<img src="' . zen_output_string($src) . '" alt="' . zen_output_string($alt) . '"';

    if (zen_not_null($alt)) {
      $image .= ' title=""';
    }

The above should work in all browsers except IE6, and it doesn't really effect the accessibility because the alt tag is still in place

[Earnest-Enterprises]

Thanks much, nigelt74, for such a thorough response. While it isn't a big issue I noticed it could be a slight irritation to some (like me...).

Thanks again!

Rod

[carol2848]

I have installed Image Handler, and nothing works! All my images are in a SUBfolder in the Images folder -- is that a problem?

[nigelt74]

I have installed Image Handler, and nothing works! All my images are in a SUBfolder in the Images folder -- is that a problem?

No, thats not a problem, because the image location is stored in the Zencart database when you add the product and image handler uses that database to find the images.

It appears from the link in your signature you have got it working now, is that correct?

[carol2848]

I thought IH was supposed to generate larger pop-up images when small images were hovered over? Is there something else I should have done so that will happen?

[nigelt74]

I thought IH was supposed to generate larger pop-up images when small images were hovered over? Is there something else I should have done so that will happen?

Its not working because you haven't uploaded all the files,

I can tell this by looking at the head section of your code, some of files are missing

you need to upload the contents of the image handler /includes/templates/YOUR TEMPLATE/ to the template you are using (mystore)

You are missing the javascript file that runs the mouseover and possibly others

there should be a javascript file located in
/includes/templates/mystore/jscript/

in fact the should be one in the default directory as well

[Earnest-Enterprises]

Thanks, nigelt74, for posting the fix for the alt product descript popping up on images but it didn't work. I made the change exactly as you posted above. You did say you made no guarantees and I appreciate that. I also appreciate your efforts in trying to rectify my problem. Maybe there's something down the road that will pop up (besides the alt descript...) that'll take care of it.

Rod

[nigelt74]

Thanks, nigelt74, for posting the fix for the alt product descript popping up on images but it didn't work. I made the change exactly as you posted above. You did say you made no guarantees and I appreciate that. I also appreciate your efforts in trying to rectify my problem. Maybe there's something down the road that will pop up (besides the alt descript...) that'll take care of it.

Rod

Umm are you sure?

Which line did you make the change on?
because i had a look at your page source code and the title is still there

title=" Jolly Roger Fedora Hat " alt="Jolly Roger Fedora Hat"

can you post the section of code that you changed basically this section
(there are 2 very similar sections one around line 122 and the other around line 197)
this is the one around 197

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
    $image = '<img src="' . zen_output_string($src) . '" alt="' . zen_output_string($alt) . '"';

    if (zen_not_null($alt)) {
      $image .= ' title=" ' . zen_output_string($alt) . ' "';
    }

you can also change around line 124 ish?

where it says

    
if (zen_not_null($alt)) {
      $image .= ' title=" ' . zen_output_string($alt) . ' "';
    }

to

if (zen_not_null($alt)) {
      $image .= ' title=""';
    }

[Earnest-Enterprises]

Umm are you sure?

No, I'm never sure when I'm making changes in ZC...

Your last suggestion did the trick, Nigel. The alt description no longer pops up. There are actually two other lines that have your last change in the original html_output.php file that was distributed with 139d (besides your original fix at line 197). My line numbers were different as I have another mod that uses this file thus changes the line numbers.

To put this all in a clear perspective, here's what I did with your suggestions (assuming my line numbers remained the same as the original file) to keep the alt description from popping up over images. In the includes/functions/html_output.php file:

I replaced the code at line 124 from this:

if (zen_not_null($alt)) {
      $image .= ' title=" ' . zen_output_string($alt) . ' "';
    }

to this:

if (zen_not_null($alt)) {
      $image .= ' title=""';
    }

I did exactly the same with the above at line 200 as the code is the same (needs to be changed in two places).

At line 197 I replaced this:

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
    $image = '<img src="' . zen_output_string($src) . '" alt="' . zen_output_string($alt) . '"';

    if (zen_not_null($alt)) {
      $image .= ' title=" ' . zen_output_string($alt) . ' "';
    }

With this:

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
    $image = '<img src="' . zen_output_string($src) . '" alt="' . zen_output_string($alt) . '"';

    if (zen_not_null($alt)) {
      $image .= ' title=""';
    }

Works like a charm, Nigel, and I thank you for your help!

Rod

[iddy]

Hi

I've read through all of the posts since v1.3.9 has been released and have noticed a few requesting a copy of the merged files from someone who has it running on their shop.

I cant read php so I'm also looking for a copy of each merged file unless somebody can confirm that its a case of opening both files in winmerge and copying all highlighted differences from the original mod files to the 139 files.

I've had problems meging files meant for 138 so this merging from 138 to 139 is definately out of my league.

Thanks in advance