[Done v1.3.9] Linkpoint - problem with coupons in v1.3.8

[Jeff_Mash]

So what's happening is that the chargetotal variable is correct......that is the amount we want to charge. But when you add up the subtotal, tax, and shipping, it doesn't factor in the MISSING AMOUNT deducted because of the ot_coupon.

We need to have the api modified so that the chargetotal amount doesn't have to equal subtotal+shipping + tax. Either that, or the subtotal+shipping+tax needs to factor in the ot_coupon discount before doing the comparison.

[DrByte]

More correctly, it's necessary to skip sending the subtotal if there are discounts involved.

I've attached updated code to deal with the issue described, as well as handle other order-total discrepancies more efficiently.

(Note: this fix ALSO includes the ot_loworderfee fix posted previously, and thus supercedes the previous fix)


NOTE: linkpoint_api-138-march06-2008.zip ATTACHMENT REPLACED BELOW ... see later post:
http://www.zen-cart.com/forum/showth...462#post520462

[Jeff_Mash]

DrByte -

Good news and bad news. (First off, thanks for getting on top of this!)

The good news is that it works for discount coupons. I placed a test order and it went through like a charm!

The bad news is that if a transaction uses the ot_gv (gift certificate), it gives the same error:

Subtotal miscalculation. Please notify the storeowner.
SGS-002301: Invalid subtotal.

So here is where we stand:

Purchase w/ Coupon ONLY - WORKS
Purchase w/ GV ONLY - NO
Purchase w/GV & Coupon - NO

[DrByte]

The bad news is that if a transaction uses the ot_gv (gift certificate), it gives the same error:

Subtotal miscalculation. Please notify the storeowner.
SGS-002301: Invalid subtotal.

So here is where we stand:

Purchase w/ Coupon ONLY - WORKS
Purchase w/ GV ONLY - NO
Purchase w/GV & Coupon - NO

I'm not able to replicate this problem using the same code.

[Jeff_Mash]

Is there any sort of log or php file you would need me to post in order to help troubleshoot this?

NOTE: I didn't uninstall/reinstall the module the last time I replaced the linkpoint_api.php file because I didn't think I needed to. If that is a prerequisite, let me know and I can do that.

The way I originally did my test is I had an item that was $3.00, then applied a $1.00 balance from my gift certificate, and proceeded to the checkout. I didn't use any coupons, just the store credit leaving a remainder of $1.00. That failed with the error. If need be, I can post the linkpoint log or any other file.

[Jeff_Mash]

DrByte - THANK YOU for the help. For whatever reason, after I did an uninstall and reinstall of the linkpoint_api module, things worked for gift certificates as well as coupons.

You've been a great help to me, and I can't thank you enough.

[Ajeh]

/me hums along to DrByte Rulez da World ...

[DrByte]

Phew! I was having trouble thinking of what else could be wrong!

[DrByte]

Another update, to include the free-shipping fix from a previous thread:
http://www.zen-cart.com/forum/showthread.php?t=87388


Updated module attached, which includes:
- ot_loworderfee fix
- coupon, gv fix
- free shipping fix


NOTE: Use the updated module found at this link: http://www.zen-cart.com/forum/showth...490#post563490

The file formerly attached here is now outdated.

[bogie]

Hey, thanks - I was getting rejected from linkpoint when buyers would buy enough that they'd kick SWGuy's quantity discount mod into action... This fixed that.